Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUS-393: Align Gateways serviceAccount with Consoles #124

Closed

Conversation

BStarmerSmith
Copy link
Contributor

We had a discrepancy between Gateway and Console, where console allowed you to define annotations and also had more options for labels for your service account.

This PR brings the two product much closer in terms of linking our product to your service accounts. Adding many more values to the Gateway Helm Chart such as:

  • serviceAccount.annotations
  • serviceAccount.automountServiceAccountToken

@BStarmerSmith
Copy link
Contributor Author

See example of me using these new values and the serviceaccount they create:

# Source: conduktor-gateway/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: Service Account 1
  namespace: "conduktor"
  labels:
    helm.sh/chart: conduktor-gateway-3.3.1
    app.kubernetes.io/name: conduktor-gateway
    app.kubernetes.io/instance: conduktor-gateway
    app.kubernetes.io/version: "3.3.1"
    app.kubernetes.io/managed-by: Helm
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::123456789012:role/role-name
automountServiceAccountToken: true

Copy link
Member

@qboileau qboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BStarmerSmith
Copy link
Contributor Author

New PR with correct ticket and branch name: #125

@BStarmerSmith BStarmerSmith deleted the ops-459-rework-renovate-in-gitops-to-work-with-oci branch October 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants