Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUS-393: Align Gateways serviceAccount with Consoles #124

Closed
wants to merge 9 commits into from
Closed

CUS-393: Align Gateways serviceAccount with Consoles #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c7d396
Changed bitnami source to use oci.
BStarmerSmith Oct 2, 2024
9c191ee
Merge branch 'main' of github.com:conduktor/conduktor-public-charts i…
BStarmerSmith Oct 2, 2024
8b56fd7
Pointed renovate links that use bitnami to use the new OCI address. T…
BStarmerSmith Oct 2, 2024
f6674f6
Reverted defaults
BStarmerSmith Oct 3, 2024
ae73355
Updated gateway chart readme.
BStarmerSmith Oct 3, 2024
5606754
Removed fromm gateway serviceaccount as its a legacy gateway label
BStarmerSmith Oct 8, 2024
9943b67
Reverted makefile changes
BStarmerSmith Oct 18, 2024
8305e59
Fixed merge
BStarmerSmith Oct 18, 2024
86baa73
Updated readme.
BStarmerSmith Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions charts/gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,16 @@ Gateway embed metrics to be installed within you cluster if your have the correc

Shared Kubernetes configuration of the chart.

| Name | Description | Value |
| ----------------------- | -------------------------------------------------------------- | ------- |
| `serviceAccount.create` | Create Kubernetes service account. Default kube value if false | `false` |
| `serviceAccount.name` | Service account name to attach to the Gateway deployment | `""` |
| `commonLabels` | Labels to be applied to all resources created by this chart | `{}` |
| `nodeSelector` | Container node selector | `{}` |
| `tolerations` | Container tolerations | `[]` |
| `affinity` | Container affinity | `{}` |
| Name | Description | Value |
| --------------------------------------------- | ---------------------------------------------------------------- | ------ |
| `serviceAccount.create` | Specifies whether a ServiceAccount should be created | `true` |
| `serviceAccount.name` | The name of the ServiceAccount to use. | `""` |
| `serviceAccount.annotations` | Additional Service Account annotations (evaluated as a template) | `{}` |
| `serviceAccount.automountServiceAccountToken` | Automount service account token for the server service account | `true` |
| `commonLabels` | Labels to be applied to all resources created by this chart | `{}` |
| `nodeSelector` | Container node selector | `{}` |
| `tolerations` | Container tolerations | `[]` |
| `affinity` | Container affinity | `{}` |

### Dependencies

Expand Down
14 changes: 14 additions & 0 deletions charts/gateway/templates/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,19 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "conduktor-gateway.serviceAccountName" . }}
namespace: {{ include "common.names.namespace" . | quote }}
labels: {{ include "conduktor-gateway.labels" . | nindent 4 }}
{{- if .Values.commonLabels }}
{{- include "common.tplvalues.render" ( dict "value" .Values.commonLabels "context" $ ) | nindent 4 }}
{{- end }}
{{- if or .Values.serviceAccount.annotations .Values.commonAnnotations }}
annotations:
{{- if .Values.commonAnnotations }}
{{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
{{- end }}
{{- if .Values.serviceAccount.annotations }}
{{- include "common.tplvalues.render" (dict "value" .Values.serviceAccount.annotations "context" $) | nindent 4 }}
{{- end }}
{{- end }}
automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}
{{- end -}}
19 changes: 14 additions & 5 deletions charts/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,22 @@ metrics:
## Shared Kubernetes configuration of the chart.
## @descriptionEnd

## ServiceAccount configuration for the Conduktor Gateway pods
##
serviceAccount:
## @param serviceAccount.create Create Kubernetes service account. Default kube value if false
# Specifies whether a service account should be created
# If AWS IAM is used, need to have create: false
create: false
## @param serviceAccount.name Service account name to attach to the Gateway deployment
## @param serviceAccount.create Specifies whether a ServiceAccount should be created
##
create: true
## @param serviceAccount.name The name of the ServiceAccount to use.
## If not set and create is true, a name is generated using the common.names.fullname template
##
name: ""
## @param serviceAccount.annotations Additional Service Account annotations (evaluated as a template)
##
annotations: {}
## @param serviceAccount.automountServiceAccountToken Automount service account token for the server service account
##
automountServiceAccountToken: true

## @param commonLabels Labels to be applied to all resources created by this chart
commonLabels: {}
Expand Down
Loading