FIX: Add (optional) timeout to parent sync Ethereum API queries #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
requested review from
cryptoAtwill,
raulk,
maciejwitowski and
fridrik01
… the infra scripts
aakoshh
force-pushed
the
fix-sync-add-timeout
branch
from
87685d4
to
4a99eaa
Compare
maciejwitowski
approved these changes
Feb 29, 2024
| @@ -67,7 +67,7 @@ const ETH_PROVIDER_POLLING_TIME: Duration = Duration::from_secs(1); | |||
| const TRANSACTION_RECEIPT_RETRIES: usize = 200; | |||
|
|
|||
| /// The majority vote percentage for checkpoint submission when creating a subnet. | |||
| const SUBNET_MAJORITY_PERCENTAGE: u8 = 60; | |||
| const SUBNET_MAJORITY_PERCENTAGE: u8 = 67; | |||
There was a problem hiding this comment.
In contract this default is set as 70. Would it make sense to unify it one way or another so it's at least simpler to answer the question "what is the default?"
There was a problem hiding this comment.
From Byzantine literature it has to be n * 2/3 + 1, which if we go from 1 to 100 is 67. Not sure where 60 came from, or why it should be 70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #755
The setting is added as optional so that existing deployments won't get an error if it's missing, and that I don't have to hardcode some default. Instead it's added in the infra scripts, so we can see if it has any effect.
It also fixes the default majority to be larger than 2/3, which is standard in Byzantine settings.