Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Add (optional) timeout to parent sync Ethereum API queries #758

Merged
merged 3 commits into from
Feb 29, 2024
Merged

FIX: Add (optional) timeout to parent sync Ethereum API queries #758

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
034e9f9
FIX: Use Http::new_with_client
aakoshh Feb 29, 2024
d6d705a
FIX: 60 is not +2/3 super majority
aakoshh Feb 29, 2024
4a99eaa
FIX: Add an optional timeout to Ethereum API queries, with 60s set in…
aakoshh Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipc/provider/src/manager/evm/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const ETH_PROVIDER_POLLING_TIME: Duration = Duration::from_secs(1);
const TRANSACTION_RECEIPT_RETRIES: usize = 200;

/// The majority vote percentage for checkpoint submission when creating a subnet.
const SUBNET_MAJORITY_PERCENTAGE: u8 = 60;
const SUBNET_MAJORITY_PERCENTAGE: u8 = 67;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In contract this default is set as 70. Would it make sense to unify it one way or another so it's at least simpler to answer the question "what is the default?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Byzantine literature it has to be n * 2/3 + 1, which if we go from 1 to 100 is 67. Not sure where 60 came from, or why it should be 70.


pub struct EthSubnetManager {
keystore: Option<Arc<RwLock<PersistentKeyStore<EthKeyAddress>>>>,
Expand Down