writer: Set errno #263

eriksjolund · 2024-03-19T20:19:32Z

According to errno(3) a function that succeeds is allowed to change errno.
What if memdup() succeeds?

I changed the code to match how it's written here

Line 1472 in d5ffbeb

errno = ENOMEM;

Set errno in the same way as it's done further down in the same file https://github.com/containers/composefs/blob/d5ffbeb6844cdbe029f9c10cfa98239e2d6b1570/libcomposefs/lcfs-writer.c#L1472 Set errno after munmap() to avoid overwriting the original errno. Signed-off-by: Erik Sjölund <[email protected]>

eriksjolund · 2024-03-20T06:04:00Z

I added another small errno modification and rewrote the commit message.

cgwalters · 2024-03-20T12:14:46Z

At least systemd has a handy PRESERVE_ERRNO macro that I've used in other places too, and I think is a nicer approach. We could add that here.

eriksjolund force-pushed the writer-set-errno branch from 6b02e3a to 25ab634 Compare March 19, 2024 20:33

eriksjolund force-pushed the writer-set-errno branch from 25ab634 to 9b417be Compare March 20, 2024 05:58

cgwalters approved these changes Mar 20, 2024

View reviewed changes

cgwalters merged commit 2cb505b into containers:main Mar 20, 2024
9 of 10 checks passed

eriksjolund deleted the writer-set-errno branch March 20, 2024 18:26

Provide feedback