Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS-5125: Add support for resumable downloads #918

Merged
merged 1 commit into from
Dec 31, 2024
Merged

HMS-5125: Add support for resumable downloads #918

merged 1 commit into from
Dec 31, 2024

Conversation

Andrewgdewar
Copy link
Member

@Andrewgdewar Andrewgdewar commented Dec 11, 2024 •
edited
Loading

Summary

Adds support for resumable downloads.

Can test with this front-end PR.

Testing steps

  • Create an upoad repository.
  • Select an item for upload, allow it to upload around halfway and then immediately hit refresh.
  • After refresh, choose the same item, you should be able to see that item continue where you left off.
  • After this item has been completed, upload it, and create another upload repository.
  • Choose the same file, it should instantly be available.

@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/HMS-5125

@Andrewgdewar Andrewgdewar force-pushed the HMS-5125 branch 2 times, most recently from 88c56b8 to c509dfd Compare December 13, 2024 21:15
@Andrewgdewar Andrewgdewar marked this pull request as ready for review December 13, 2024 21:50
@Andrewgdewar Andrewgdewar mentioned this pull request Dec 13, 2024
Merged
@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/Fixes 5125

@jlsherrill jlsherrill changed the title Fixes 5125: Add support for resumable downloads HMS-5125: Add support for resumable downloads Dec 18, 2024
@Andrewgdewar Andrewgdewar mentioned this pull request Dec 19, 2024
Merged
2 tasks
@dominikvagner dominikvagner self-requested a review December 20, 2024 12:23
dominikvagner
dominikvagner requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@dominikvagner dominikvagner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change needed in the API spec, otherwise looks good, nice job! 😄👏🏼
everything works as expected 👍🏼

(tiny nit about style/formatting: in Go the if err != nil check usually follow the err assignment without a new line in between them, makes it more clear what error they are checking)

pkg/api/pulp.go Outdated Show resolved Hide resolved
@mayurilahane mayurilahane merged commit a594190 into content-services:main Dec 31, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikvagner dominikvagner dominikvagner approved these changes

@jlsherrill jlsherrill Awaiting requested review from jlsherrill

Assignees
No one assigned
Labels
qe-testing-needed Ready for QE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andrewgdewar @jlsherrill @dominikvagner @mayurilahane