CORE-15310: Use custom SLF4J bundle in OSGi tests #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main principle is that `net.corda.slf4jv1` bundle and `slf4j.api` should be mutually exclusive. I.e. `slf4j.api` is used during production Workers run, including Combined Worker. Whereas `net.corda.slf4jv1` bundle is used for any OSGi testing. But these bundles should never be used together as this causes OSGi conflicts like: ``` "Uses constraint violation. Unable to resolve resource micrometer-core [micrometer-core [37](R 37.0)] because it is exposed to package 'org.slf4j.spi' from resources net.corda.slf4jv1 [net.corda.slf4jv1 [142](R 142.0)] and slf4j.api [slf4j.api [209](R 209.0)] via two dependency chains. Chain 1: micrometer-core [micrometer-core [37](R 37.0)] import: (&(osgi.wiring.package=org.slf4j.spi)(version>=1.7.0)(!(version>=2.0.0))) | export: osgi.wiring.package: org.slf4j.spi net.corda.slf4jv1 [net.corda.slf4jv1 [142](R 142.0)] Chain 2: micrometer-core [micrometer-core [37](R 37.0)] import: (&(osgi.wiring.package=org.slf4j)(version>=1.7.0)(!(version>=2.0.0))) | export: osgi.wiring.package=org.slf4j; uses:=org.slf4j.spi slf4j.api [slf4j.api [209](R 209.0)] import: (&(osgi.wiring.package=org.slf4j.spi)(version>=2.0.13)(!(version>=3.0.0))) | export: osgi.wiring.package: org.slf4j.spi slf4j.api [slf4j.api [209](R 209.0)]" ```
|
|
Jenkins build for PR 6248 build 1 Build Successful: |
4 tasks
filipesoliveira
approved these changes
Jul 2, 2024
|
build e2e |
|
Building E2E Tests on PR-6248 |
josephzunigadaly
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main principle is that
net.corda.slf4jv1bundle andslf4j.apishould be mutually exclusive.I.e.
slf4j.apiis used during production Workers run, including Combined Worker. Whereasnet.corda.slf4jv1bundle is used for any OSGi testing.But these bundles should never be used together as this causes OSGi conflicts like: