Add the possibility to configure the upstream protocol in the nginx configuration for the cortex upstream #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finn-evers
force-pushed
the
feature/tls-upstream
branch
from
fa5329b
to
cab3e75
Compare
…or the cortex upstream Signed-off-by: Finn Evers <[email protected]>
Signed-off-by: Finn Evers <[email protected]>
finn-evers
force-pushed
the
feature/tls-upstream
branch
from
cab3e75
to
5597ec4
Compare
nschad
approved these changes
Aug 26, 2024
kd7lxl
approved these changes
Aug 26, 2024
| @@ -1196,6 +1196,8 @@ nginx: | |||
| mainSnippet: "" | |||
| # -- arbitrary snippet to inject in the server { } section of the nginx config | |||
| serverSnippet: "" | |||
| # -- protocol for the communication with the upstream | |||
| upstream_protocol: http | |||
There was a problem hiding this comment.
I was going to suggest to make it camelCase to match the others, but then I noticed there is already a mix of camelCase and snake_case 🤦♂️
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add the possibility to configure the protocol for the upstream URLs in the nginx configuration.
Which issue(s) this PR fixes:
When preparing to upgrade to TLS communication we ran into the problem that the nginx upstream URLs are hard-coded to http.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]