Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pgjdbc 42.7.1 #288

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Update to pgjdbc 42.7.1 #288

merged 3 commits into from
Jan 10, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 29, 2023 •
edited
Loading

@amotl amotl mentioned this pull request Nov 29, 2023
Closed
@amotl
Copy link
Member Author

amotl commented Nov 30, 2023

The build currently fails.

@amotl amotl mentioned this pull request Nov 30, 2023
Closed
@amotl amotl changed the title Update to pgjdbc 42.7.0 Update to pgjdbc 42.7.1 Jan 9, 2024
@amotl
pgjdbc: Update to 42.7.1
2ade95d
@amotl
pgjdbc: Skip test about getDefaultTransactionIsolation()
5c102ca 
Starting with version 42.7.0, the driver issues a query statement like

  SELECT *
  FROM pg_catalog.pg_settings
  WHERE name=default_transaction_isolation

This is not supported by CrateDB.
@amotl amotl mentioned this pull request Jan 9, 2024
Merged
@amotl amotl marked this pull request as ready for review January 9, 2024 21:54
@amotl
pgjdbc: Adjust test for updates to conn.getMetaData().getCatalogs()
27e206f 
As before, the inquiry of the available catalogs returned `doc` on the
first slot.

It looks actually correct now in 42.7, as `doc` is the schema, but not
the catalog. The SQL statement to inquire the available catalogs returns
`crate`, not `doc`.

  SELECT DISTINCT table_catalog FROM information_schema.tables 

This item on the upstream release notes seems to be relevant:

  feat: return all catalogs for getCatalogs metadata query closes
  ISSUE #2949 PR #2953

  -- https://jdbc.postgresql.org/changelogs/2023-11-20-42.7.0-release/
@amotl amotl merged commit b435847 into master Jan 10, 2024
1 check passed
@amotl amotl deleted the pgjdbc-42.7.0 branch January 10, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfussenegger mfussenegger mfussenegger approved these changes

@hammerhead hammerhead hammerhead approved these changes

@matriv matriv matriv approved these changes

@seut seut Awaiting requested review from seut

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amotl @mfussenegger @hammerhead @matriv