Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #556

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Drop support for Python 3.8 #556

merged 1 commit into from
Jan 22, 2025

Conversation

tomach
Copy link
Contributor

@tomach tomach commented Jan 22, 2025

Summary of the changes / Why this is an improvement

Python 3.8 reached EOL. and it is causing dependency upgrades to fail GH-546, GH-551

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???

@tomach tomach marked this pull request as ready for review January 22, 2025 10:15
plaharanne
plaharanne approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also refresh DEVELOP.rst that contains a lot of old examples with python 3.6 and 3.7. Otherwise, it looks good.

@tomach
Copy link
Contributor Author

tomach commented Jan 22, 2025

You could also refresh DEVELOP.rst that contains a lot of old examples with python 3.6 and 3.7. Otherwise, it looks good.

good catch, thank you! I've updated DEVELOP.rst

@tomach tomach merged commit 64f09a6 into master Jan 22, 2025
11 checks passed
@tomach tomach deleted the ta/drop-py38 branch January 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaharanne plaharanne plaharanne approved these changes

@juanpardo juanpardo Awaiting requested review from juanpardo

@Taliik Taliik Awaiting requested review from Taliik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomach @plaharanne