Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #556

Merged
merged 1 commit into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
fail-fast: false
matrix:
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Changes for croud
Unreleased
==========

- Dropped support for Python 3.8.

1.13.0 - 2025/01/07
===================

Expand Down
20 changes: 10 additions & 10 deletions DEVELOP.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Setup
Pip
---

Python >= 3.6 is required. Run ``croud`` within a virtual python environment::
Python >= 3.9 is required. Run ``croud`` within a virtual python environment::

python -m venv env
source env/bin/activate
Expand All @@ -32,7 +32,7 @@ Alternatively, you can clone this repository, install it into a virtualenv and
add the executable to your PATH environment variable::

git clone [email protected]:crate/croud.git && cd croud/
python3.6 -m venv env
python3.12 -m venv env
env/bin/pip install -e .
export PATH=$PATH:$(pwd)/env/bin/croud

Expand All @@ -52,9 +52,9 @@ versions run::
tox

Alongside ``--`` it's possible to pass ``pytest`` args e.g. to run only a
fraction of tests with python3.6::
fraction of tests with python3.12::

tox -e py36 -- -k test_rest
tox -e py312 -- -k test_rest

The test setup uses `pytest-random-order`_ to ensure better test separation.
By default, the order will be random on the Python module level. That means,
Expand All @@ -64,20 +64,20 @@ When running tests using ``tox`` or ``py.test``, `pytest-random-order`_ will
emit a seed value at the beginning which can be used to rerun tests with the
specific order::

$ tox -e py37
$ tox -e py312
...
py37 run-test-pre: PYTHONHASHSEED='2789788418'
py37 run-test: commands[0] | pytest
py312 run-test-pre: PYTHONHASHSEED='2789788418'
py312 run-test: commands[0] | pytest
======================== test session starts =========================
platform linux -- Python 3.7.3, pytest-3.10.1, py-1.8.0, pluggy-0.12.0
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
Using --random-order-bucket=module
Using --random-order-seed=240261
...

One can rerun a random test setup by passing ``--random-order-seed=<seed>`` to
py.test::

$ tox -e py37 -- --random-order-seed=240261
$ tox -e py312 -- --random-order-seed=240261


Debugging API calls
Expand Down Expand Up @@ -160,7 +160,7 @@ The documentation is written using `Sphinx`_ and `ReStructuredText`_.
Working on the documentation
----------------------------

Python 3.7 is required.
Python 3.9 or higher is required.

Change into the ``docs`` directory:

Expand Down
4 changes: 1 addition & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,14 @@
"mypy<1.15",
],
},
python_requires=">=3.8",
python_requires=">=3.9",
classifiers=[
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Topic :: Database",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py38,py39,py310,py311,py312,py313
envlist = py39,py310,py311,py312,py313

[testenv]
deps = -e{toxinidir}[testing]
Expand Down
Loading