hwbench: generic vendor: make monitoring file optional #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisse
force-pushed
the
generic-optional-monitoring
branch
from
b184a0c to
0e8da7c
Compare
anisse
force-pushed
the
generic-optional-monitoring
branch
from
0e8da7c to
e28d062
Compare
anisse
force-pushed
the
generic-optional-monitoring
branch
from
e28d062 to
de72583
Compare
Since we moved to the generic vendor, we no longer use the mockedvendor by default (it's now only for tests). So when running hwbench on a desktop/laptop for local testing, it requires setting the monitoring file, which wasn't the case before. This change makes the monitoring file optional in this case, with a fallback when it is not provided to the MockedBMC.
anisse
force-pushed
the
generic-optional-monitoring
branch
from
de72583 to
88b51b1
Compare
ErwanAliasr1
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved to the generic vendor, we no longer use the mockedvendor
by default (it's now only for tests). So when running hwbench on a
desktop/laptop for local testing, it requires setting the monitoring
file, which wasn't the case before.
This change makes the monitoring file optional in this case, with a
fallback when it is not provided to the MockedBMC.