Problem: zksync-web3.js does not support custom gas token #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
reviewed
Jul 26, 2023
| console.log(`[${tag}]ETH balance L2: `, ethers.utils.formatEther(balance)); | ||
| } | ||
|
|
||
| const test = async () => { |
There was a problem hiding this comment.
im not sure if we should commit this file, otherwise need to clean it a bit
thomas-nguy
reviewed
Jul 26, 2023
sdk/zksync-web3.js/src/adapters.ts
Outdated
| @@ -54,9 +54,10 @@ export function AdapterL1<TBase extends Constructor<TxSender>>(Base: TBase) { | |||
|
|
|||
| async getL1BridgeContracts() { | |||
| const addresses = await this._providerL2().getDefaultBridgeAddresses(); | |||
| // TODO: wethL1 is not returned at the moment | |||
There was a problem hiding this comment.
not sure if we can remove it if its not a big change?
thomas-nguy
reviewed
Jul 26, 2023
thomas-nguy
approved these changes
Jul 26, 2023
thomas-nguy
changed the title
thomas-nguy
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15