Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux getrandom failure in interpreted code #15035

Merged

Conversation

HertzDevil
Copy link
Contributor

Fixes #15034.

@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 25, 2024
@straight-shoota
Copy link
Member

thought: Alternatively, we could modify the behaviour of the interpreter implementation of Crystal::System::Syscall.getrandom to return the error value directly, just like the syscall variant.
It probably doesn't make much difference, but it would concentrate all interpreter special stuff in one place.

@straight-shoota straight-shoota merged commit d58ede5 into crystal-lang:master Sep 26, 2024
65 checks passed
@HertzDevil HertzDevil deleted the bug/interpreter-getrandom branch September 29, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getrandom.cr fails in Alpine under Docker (crystal 1.13.2)
3 participants