Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux getrandom failure in interpreted code #15035

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix Linux getrandom failure in interpreted code #15035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6d0d8
Fix Linux `getrandom` failure in interpreted code
HertzDevil Sep 25, 2024
8dd245e
fixup
HertzDevil Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/crystal/system/unix/getrandom.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ require "./syscall"

# TODO: Implement syscall for interpreter
def self.getrandom(buf : UInt8*, buflen : LibC::SizeT, flags : UInt32) : LibC::SSizeT
LibC.getrandom(buf, buflen, flags)
# the syscall returns the negative of errno directly, the C function
# doesn't, so we mimic the syscall behavior
read_bytes = LibC.getrandom(buf, buflen, flags)
read_bytes >= 0 ? read_bytes : LibC::SSizeT.new(-Errno.value.value)
end
end
{% end %}
Expand Down
Loading