Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix energy_bias_resolution_from_energy_dispersion #268

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 19, 2023

This function still assumed the wrong normalization of the energy dispersion fixed in pyirf 0.10.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbacc33) 95.35% compared to head (9a4baa1) 95.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   95.35%   95.36%   +0.01%     
==========================================
  Files          60       60              
  Lines        3097     3109      +12     
==========================================
+ Hits         2953     2965      +12     
  Misses        144      144              
Files Coverage Δ
pyirf/benchmarks/energy_bias_resolution.py 76.00% <100.00%> (+1.53%) ⬆️
pyirf/benchmarks/tests/test_bias_resolution.py 71.21% <100.00%> (+4.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe force-pushed the fix_bias_resolution_from_edisp branch from ee4e8ea to d72925a Compare October 19, 2023 09:44
This function still assumed the wrong normalization of
the energy dispersion fixed in pyirf 0.10.
@maxnoe maxnoe force-pushed the fix_bias_resolution_from_edisp branch from d72925a to 29bd509 Compare October 19, 2023 09:44
Tobychev
Tobychev previously approved these changes Oct 19, 2023
@maxnoe
Copy link
Member Author

maxnoe commented Oct 19, 2023

@Tobychev the mistake was obvious (the function was overlooked in the update), but could you anyway maybe check with your plot in #267 ?

@Tobychev
Copy link
Contributor

In case there is nothing in an energy bin energy_bias_resolution_from_energy_dispersion will return the upper limit of the dispersion axis. It is probably better to return NaN

Tobychev
Tobychev previously approved these changes Oct 27, 2023
@maxnoe maxnoe merged commit 5346e00 into main Oct 27, 2023
9 checks passed
@maxnoe maxnoe deleted the fix_bias_resolution_from_edisp branch October 27, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants