-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unhelpful upgrade message for [scheduling][dependencies]graph
#5874
Conversation
a0b0772
to
1f58728
Compare
Something's gone wrong git-wise |
cb78b5f
to
9d13c1c
Compare
9d13c1c
to
06700e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These validation tests are getting quite fragmented. We now have
- tests/integration/test_config.py
- tests/integration/scripts/test_validate_integration.py
- tests/integration/validate/test_outputs.py
- tests/integration/test_upgrade_warning.py
All of which do pretty much the same kind of tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look and see if I can do any rationalization in this PR, but I think that there is definately scope for keeping tight reigns on the integration tests, lest they become a sprawing mess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved my new tests so that they aren't at least creating a new test file, and only modifying one test file. I think further rationalization is out of scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[scheduling]
initial cycle point = 2012
[[dependencies]]
graph = foo
[[[T00]]]
graph = bar
[runtime]
[[foo,bar]]
$ cylc validate cylc7-simple/
WARNING - deprecated graph items were automatically upgraded in "workflow definition":
* (8.0.0) [scheduling][dependencies]graph -> [scheduling][graph]R1
It's missing the T00
upgrade from the warning
[scheduling][dependencies]graph
Somewhat surprised that's valid at all! Fixed with 2d868cf |
Deal with scenario where ``` [scheduling] graph = foo [[P1D]] graph = bar ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will do
Don't get me wrong, it's wierd and complex now. I'm not thrilled. I also cannot justify spending too much time on code which I want to delete before the end of 2026. |
Kicking tests |
… foo=>bar
Closes #5810
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).improves documentation, doesn't change functioning.CHANGES.md
entry?.?.x
branch.