Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empy support #6476

Merged
merged 1 commit into from
Nov 19, 2024
Merged

remove empy support #6476

merged 1 commit into from
Nov 19, 2024

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 13, 2024 •
edited
Loading

  • Closes EmPy: Drop support #6458
  • EmPy support is currently broken.
  • As there are no users of this integration and concerns over the future of the package, we have decided to drop support rather than fixing it.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/776.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
remove empy support
fa687e8 
* Closes cylc#6458
* EmPy support is currently broken.
* As there are no users of this integration and concerns over
  the future of the package, we have decided to drop support
  rather than fixing it.
@oliver-sanders oliver-sanders self-assigned this Nov 13, 2024
@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Nov 13, 2024
@oliver-sanders oliver-sanders mentioned this pull request Nov 13, 2024
Merged
1 task
@oliver-sanders oliver-sanders marked this pull request as ready for review November 13, 2024 13:34
hjoliver
hjoliver approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably needs an associated small doc update. (fail)

@hjoliver
Copy link
Member

One review will do for this.

@hjoliver hjoliver merged commit 140bef3 into cylc:master Nov 19, 2024
38 of 39 checks passed
@oliver-sanders oliver-sanders deleted the 6458 branch November 20, 2024 09:42
This was referenced Nov 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

EmPy: Drop support
2 participants
@oliver-sanders @hjoliver