fileinstall: remove asyncio logic

[oliver-sanders]

This is one of a triplet of PRs which closes #274

• post_configure: ensure asyncio tasks created by plugins are awaited cylc-flow#5868
• fileinstall: run coros in the background if loop already running metomi/rose#2744

---

• Rose will now take over the role of managing its event loop.
• Addresses reinstall + fileinstall: async clash #274

---

See the cylc-flow PR for testing instructions.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• CHANGES.md no - unreleased bug
• Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[oliver-sanders]

Note: this one needs to be merged before this can be tested: #292

[MetRonnie]

Kicking tests Oh wait, still need cylc/cylc-flow#5868 and metomi/rose#2744

[wxtim]

• Read changes
• Run tests locally
• Tried to break various components of this

[MetRonnie]

Now kicking tests

[oliver-sanders]

:(

[MetRonnie]

Strange that it's passing locally. Does it want something like this?

diff --git a/tests/functional/test_rose_stem.py b/tests/functional/test_rose_stem.py
index 0e23a73..ebf15f7 100644
--- a/tests/functional/test_rose_stem.py
+++ b/tests/functional/test_rose_stem.py
@@ -373,14 +373,14 @@ class TestProjectOverride():
             "SOURCE_FOO_MIRROR=\"fcm:foo.xm/trunk@1\"",
         ]
     )
-    def test_project_override(self, project_override, expected):
+    async def test_project_override(self, project_override, expected):
         """Check that assorted variables have been exported.
         """
         if expected == 'run_ok':
             assert project_override['run_stem'].returncode == 0
         else:
             expected = expected.format(
-                workingcopy=project_override['workingcopy'],
+                workingcopy=(await project_override)['workingcopy'],
                 hostname=HOST
             )
             assert expected in project_override['jobout_content']

[oliver-sanders]

This ticket is the gift that just keeps giving 🤦

Shouldn't need to await a fixture, doesn't make sense.

It doesn't look like pytest-asyncio is actually installed?!

[oliver-sanders]

I'm not convinced these tests were being run properly before.

Note pytest-asyncio wasn't installed in CI (it is for us locally because of cylc-flow).

I've now added pytest-asyncio back in as a test dependency and addressed some unrelated fixture scoping issues that were causing some failures.

[oliver-sanders]

These test classes aren't achieving anything since they each contain only one test and don't manage any resources.

Test classes date back to unittest, fixtures are more modern solution. Working with module-scoped fixtures and class-scoped tests gets tricky.

[MetRonnie]

All's well that ends well

[oliver-sanders]

@wxtim, you might want to take a quick look at the test changes since you last reviewed. I've added pytest-asyncio as a test dependency (I have no idea what the tests were doing before?) and dealt with some fixture scoping issues that required some test changes.

[wxtim]

Re-reviewed! 😄