Adding id and slug search to CLI #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 14.94% 14.85% -0.10%
==========================================
Files 24 24
Lines 1485 1494 +9
==========================================
Hits 222 222
- Misses 1263 1272 +9 |
|
I mentioned this on Discord, but, again... Thank you for your contribution, @CERLgit ! It's genuinely really awesome to see ;D Btw, don't worry about the codecov thing failing. I don't really care. I really just have it thre to ensure our test coverage doesn't go down tremendously. |
danbugs
requested changes
Feb 22, 2024
Signed-off-by: Carlos R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 3.
Decided to quickly add slug support as well since sending people to PGstats to grab ID seems a bit strange when the slug is easily found on start.gg profiles (they even copy when clicked).
Used using "smithe id <id>" or "smithe slug <slug>" respectively.
Output from each is identical to output of original player tag search command.