Dont set group for optional fields
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetanu
approved these changes
Oct 16, 2023
cetanu
pushed a commit
that referenced
this pull request
Oct 16, 2023
cetanu
pushed a commit
that referenced
this pull request
Oct 16, 2023
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing
.protofiles,protocmakes each optional field part of a distinct group. This is probably for backwards compatibility since the proto3 optional feature was only added later. Since betterproto supports this feature, it seems natural to me to ignore these artificial group names of optional fields. This change also fixes #523.