Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: privacy plist & zenledger strings #646

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Apr 9, 2024

Issue being fixed or feature implemented

Per Apple requirements, we need to declare a privacy info plist with NSPrivacyAccessedAPITypes group.

What was done?

  • Added the plist and declared required categories
  • Generated ZenLedger localization strings

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf April 9, 2024 12:30
@Syn-McJ Syn-McJ self-assigned this Apr 9, 2024
<string>NSPrivacyAccessedAPICategorySystemBootTime</string>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>8FFB.1</string>
Copy link
Member Author

@Syn-McJ Syn-McJ Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit tricky to figure out which reasons to specify exactly, especially when some of the categories like BootTime seem to be used by third-party libraries like GoogleDataTransport.

This reference seems to match our use case pretty well: FlutterFlow/flutterflow-issues#2527 (comment)
All reasons are here: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Syn-McJ Syn-McJ merged commit d77a240 into dashpay:develop Apr 10, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the chore/privacy-plist branch April 10, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants