Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: privacy plist & zenledger strings #646

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: privacy plist & zenledger strings #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df76351
fix: zenledger request text
Syn-McJ Apr 6, 2024
10fb868
feat: localization
Syn-McJ Apr 6, 2024
f85e3cd
chore: add and fill privacy plist
Syn-McJ Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions DashWallet.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,9 @@
75889B792AD2A04900C17F5D /* CoinJoinInfoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 75889B752AD296E700C17F5D /* CoinJoinInfoViewController.swift */; };
75889B7F2AD2D7F800C17F5D /* CoinJoin.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 75889B812AD2D7F800C17F5D /* CoinJoin.storyboard */; };
75889B892AD2DF0200C17F5D /* CoinJoin.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 75889B812AD2D7F800C17F5D /* CoinJoin.storyboard */; };
758CE59C2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 758CE59B2BC566DE0062AF53 /* PrivacyInfo.xcprivacy */; };
758CE59D2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 758CE59B2BC566DE0062AF53 /* PrivacyInfo.xcprivacy */; };
758CE59E2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 758CE59B2BC566DE0062AF53 /* PrivacyInfo.xcprivacy */; };
7592AA7C2B9B08C000417F9E /* SupportedTopperPaymentMethods.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7592AA7B2B9B08C000417F9E /* SupportedTopperPaymentMethods.swift */; };
7592AA7D2B9B08C000417F9E /* SupportedTopperPaymentMethods.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7592AA7B2B9B08C000417F9E /* SupportedTopperPaymentMethods.swift */; };
759C8F9F2B593589004B1305 /* CrowdNodeAPYView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 759C8F9E2B593589004B1305 /* CrowdNodeAPYView.swift */; };
Expand Down Expand Up @@ -2461,6 +2464,7 @@
757E09981ADB8EEB006FD352 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/Localizable.strings; sourceTree = "<group>"; };
75889B752AD296E700C17F5D /* CoinJoinInfoViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CoinJoinInfoViewController.swift; sourceTree = "<group>"; };
75889B802AD2D7F800C17F5D /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/CoinJoin.storyboard; sourceTree = "<group>"; };
758CE59B2BC566DE0062AF53 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
7592AA7B2B9B08C000417F9E /* SupportedTopperPaymentMethods.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SupportedTopperPaymentMethods.swift; sourceTree = "<group>"; };
759816E519357D6F005060EA /* BRBubbleView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BRBubbleView.h; sourceTree = "<group>"; };
759816E619357D6F005060EA /* BRBubbleView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BRBubbleView.m; sourceTree = "<group>"; };
Expand Down Expand Up @@ -6196,6 +6200,7 @@
2ADC722723B5547000D9DD37 /* Localizable.stringsdict */,
75D5F3CD191EC270004AB296 /* main.m */,
75D5F3CF191EC270004AB296 /* DashWallet-Prefix.pch */,
758CE59B2BC566DE0062AF53 /* PrivacyInfo.xcprivacy */,
);
name = "Supporting Files";
sourceTree = "<group>";
Expand Down Expand Up @@ -7872,6 +7877,7 @@
C9F42FB629DD8702001BC549 /* BackupInfoItemView.xib in Resources */,
47AE8BB028BFF28700490F5E /* explore.db in Resources */,
0F36937F2919A70B007F4E91 /* Coinbase.storyboard in Resources */,
758CE59C2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */,
2A10EB3E2358BDA500C38B61 /* ImportWalletInfo.storyboard in Resources */,
C9F42FAD29DC115A001BC549 /* ReceiveContentView.xib in Resources */,
2AD1CE8622DC9B7300C99324 /* VerifySeedPhrase.storyboard in Resources */,
Expand Down Expand Up @@ -7932,6 +7938,7 @@
2A741DC223639A9700840ADF /* TodayExtension.storyboard in Resources */,
BA54D3CE1B2EA74000C9CB28 /* TodayExtensionAssets.xcassets in Resources */,
2A741DC323639C7E00840ADF /* Localizable.strings in Resources */,
758CE59E2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */,
2ADF840023633121008459A7 /* SharedAssets.xcassets in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -7982,6 +7989,7 @@
C9D2C92E2A320AA000D15901 /* ImportWalletInfo.storyboard in Resources */,
C9D2C92F2A320AA000D15901 /* ReceiveContentView.xib in Resources */,
C9D2C9302A320AA000D15901 /* VerifySeedPhrase.storyboard in Resources */,
758CE59D2BC566DE0062AF53 /* PrivacyInfo.xcprivacy in Resources */,
753FDBEC2AECF4CC0005EEC3 /* VotingHeaderView.xib in Resources */,
C9D2C9312A320AA000D15901 /* DWSecurityStatusView.xib in Resources */,
C9D2C9322A320AA000D15901 /* About.storyboard in Resources */,
Expand Down
36 changes: 36 additions & 0 deletions DashWallet/PrivacyInfo.xcprivacy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyTracking</key>
<false/>
<key>NSPrivacyAccessedAPITypes</key>
<array>
<dict>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>1C8F.1</string>
</array>
</dict>
<dict>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategoryFileTimestamp</string>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>C617.1</string>
<string>0A2A.1</string>
</array>
</dict>
<dict>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategorySystemBootTime</string>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>8FFB.1</string>
Copy link
Member Author

@Syn-McJ Syn-McJ Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit tricky to figure out which reasons to specify exactly, especially when some of the categories like BootTime seem to be used by third-party libraries like GoogleDataTransport.

This reference seems to match our use case pretty well: FlutterFlow/flutterflow-issues#2527 (comment)
All reasons are here: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

</array>
</dict>
</array>
</dict>
</plist>
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Menu/Tools/ZenLedger/ZenLedgerInfoSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct ZenLedgerInfoSheet: View {
)
} else {
Alert(
title: Text(NSLocalizedString("Allow send all transactions from Dash Wallet to ZenLedger?", comment: "ZenLedger")),
title: Text(NSLocalizedString("Allow sending all transactions from Dash Wallet to Zenledger?", comment: "ZenLedger")),
primaryButton: .default(Text(NSLocalizedString("Allow", comment: "ZenLedger"))) {
export()
},
Expand Down
24 changes: 24 additions & 0 deletions DashWallet/ar.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@
/* CrowdNode */
"All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device." = "سيتم إجراء جميع عمليات النقل من وإلى CrowdNode من هذا الجهاز باستخدام عنوان Dash أدناه من هذا الجهاز.";

/* ZenLedger */
"Allow" = "Allow";

/* No comment provided by engineer. */
"Allow camera access in Settings" = "Allow camera access in Settings";

/* No comment provided by engineer. */
"Allow Face ID access in Settings" = "Allow Face ID access in Settings";

/* ZenLedger */
"Allow sending all transactions from Dash Wallet to Zenledger?" = "Allow sending all transactions from Dash Wallet to Zenledger?";

/* No comment provided by engineer. */
"Allow Touch ID access in Settings" = "Allow Touch ID access in Settings";

Expand Down Expand Up @@ -428,6 +434,9 @@
/* No comment provided by engineer. */
"Connect with third party exchanges" = "اتصال مع منصات الطرف الثالث";

/* ZenLedger */
"Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions." = "Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions.";

/* Buy Sell Portal
Coinbase Entry Point */
"Connected" = "تم الاتصال";
Expand Down Expand Up @@ -751,6 +760,9 @@
/* No comment provided by engineer. */
"Explore Dash" = "اكتشف داش";

/* ZenLedger */
"Export all transactions" = "Export all transactions";

/* No comment provided by engineer. */
"Extended Public Keys" = "Extended Public Keys";

Expand Down Expand Up @@ -1998,6 +2010,9 @@
/* CrowdNode Portal */
"Sign up to finish setting up account" = "قم بالتسجيل للانتهاء من إنشاء الحساب";

/* ZenLedger */
"Simplify your crypto taxes" = "Simplify your crypto taxes";

/* No comment provided by engineer. */
"Skip" = "تخطي";

Expand Down Expand Up @@ -2130,6 +2145,9 @@
/* Usernames */
"There was a network error, you can try again at no extra cost" = "There was a network error, you can try again at no extra cost";

/* ZenLedger */
"There was an error when exporting your transaction history to ZenLedger" = "There was an error when exporting your transaction history to ZenLedger";

/* Coinbase */
"There was an error while obtaining new address" = "There was an error while obtaining new address";

Expand Down Expand Up @@ -2432,6 +2450,9 @@
/* Voting */
"Voting:" = "Voting:";

/* ZenLedger */
"Wait until the chain is fully synced, so we can review your transaction history." = "Wait until the chain is fully synced, so we can review your transaction history.";

/* No comment provided by engineer. */
"Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up." = "انتظر حتى تتم مزامنة السلسلة بالكامل ، حتى نتمكن من مراجعة سجل معاملاتك. قم بزيارة موقع CrowdNode لتسجيل الدخول أو التسجيل.";

Expand Down Expand Up @@ -2714,3 +2735,6 @@

/* No comment provided by engineer. */
"Your wallet is secured now. You can use your recovery phrase anytime to recover your account on another device." = "محفظتك مؤمنة الآن. يمكنك استخدام عبارة الاسترداد في أي وقت لاسترداد حسابك على جهاز آخر.";

/* No comment provided by engineer. */
"ZenLedger" = "ZenLedger";
24 changes: 24 additions & 0 deletions DashWallet/bg.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@
/* CrowdNode */
"All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device." = "All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device.";

/* ZenLedger */
"Allow" = "Allow";

/* No comment provided by engineer. */
"Allow camera access in Settings" = "Разреши достъпа до камерата в Настройки";

/* No comment provided by engineer. */
"Allow Face ID access in Settings" = "Разреши достъпа до Face ID в Настройки";

/* ZenLedger */
"Allow sending all transactions from Dash Wallet to Zenledger?" = "Allow sending all transactions from Dash Wallet to Zenledger?";

/* No comment provided by engineer. */
"Allow Touch ID access in Settings" = "Разреши достъпа до Touch ID в Настройки";

Expand Down Expand Up @@ -428,6 +434,9 @@
/* No comment provided by engineer. */
"Connect with third party exchanges" = "Свързване към трета страна за обмяна";

/* ZenLedger */
"Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions." = "Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions.";

/* Buy Sell Portal
Coinbase Entry Point */
"Connected" = "Connected";
Expand Down Expand Up @@ -751,6 +760,9 @@
/* No comment provided by engineer. */
"Explore Dash" = "Explore Dash";

/* ZenLedger */
"Export all transactions" = "Export all transactions";

/* No comment provided by engineer. */
"Extended Public Keys" = "Extended Public Keys";

Expand Down Expand Up @@ -1998,6 +2010,9 @@
/* CrowdNode Portal */
"Sign up to finish setting up account" = "Sign up to finish setting up account";

/* ZenLedger */
"Simplify your crypto taxes" = "Simplify your crypto taxes";

/* No comment provided by engineer. */
"Skip" = "Пропусни";

Expand Down Expand Up @@ -2130,6 +2145,9 @@
/* Usernames */
"There was a network error, you can try again at no extra cost" = "There was a network error, you can try again at no extra cost";

/* ZenLedger */
"There was an error when exporting your transaction history to ZenLedger" = "There was an error when exporting your transaction history to ZenLedger";

/* Coinbase */
"There was an error while obtaining new address" = "There was an error while obtaining new address";

Expand Down Expand Up @@ -2432,6 +2450,9 @@
/* Voting */
"Voting:" = "Voting:";

/* ZenLedger */
"Wait until the chain is fully synced, so we can review your transaction history." = "Wait until the chain is fully synced, so we can review your transaction history.";

/* No comment provided by engineer. */
"Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up." = "Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up.";

Expand Down Expand Up @@ -2714,3 +2735,6 @@

/* No comment provided by engineer. */
"Your wallet is secured now. You can use your recovery phrase anytime to recover your account on another device." = "Вашият портфейл сега е защитен. Можете да използвате вашата фраза за възстановяване по всяко време, за да възстановите акаунта си на друго устройство.";

/* No comment provided by engineer. */
"ZenLedger" = "ZenLedger";
24 changes: 24 additions & 0 deletions DashWallet/ca.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@
/* CrowdNode */
"All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device." = "All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device.";

/* ZenLedger */
"Allow" = "Allow";

/* No comment provided by engineer. */
"Allow camera access in Settings" = "Allow camera access in Settings";

/* No comment provided by engineer. */
"Allow Face ID access in Settings" = "Allow Face ID access in Settings";

/* ZenLedger */
"Allow sending all transactions from Dash Wallet to Zenledger?" = "Allow sending all transactions from Dash Wallet to Zenledger?";

/* No comment provided by engineer. */
"Allow Touch ID access in Settings" = "Allow Touch ID access in Settings";

Expand Down Expand Up @@ -428,6 +434,9 @@
/* No comment provided by engineer. */
"Connect with third party exchanges" = "Connect with third party exchanges";

/* ZenLedger */
"Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions." = "Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions.";

/* Buy Sell Portal
Coinbase Entry Point */
"Connected" = "Connected";
Expand Down Expand Up @@ -751,6 +760,9 @@
/* No comment provided by engineer. */
"Explore Dash" = "Explore Dash";

/* ZenLedger */
"Export all transactions" = "Export all transactions";

/* No comment provided by engineer. */
"Extended Public Keys" = "Extended Public Keys";

Expand Down Expand Up @@ -1998,6 +2010,9 @@
/* CrowdNode Portal */
"Sign up to finish setting up account" = "Sign up to finish setting up account";

/* ZenLedger */
"Simplify your crypto taxes" = "Simplify your crypto taxes";

/* No comment provided by engineer. */
"Skip" = "Skip";

Expand Down Expand Up @@ -2130,6 +2145,9 @@
/* Usernames */
"There was a network error, you can try again at no extra cost" = "There was a network error, you can try again at no extra cost";

/* ZenLedger */
"There was an error when exporting your transaction history to ZenLedger" = "There was an error when exporting your transaction history to ZenLedger";

/* Coinbase */
"There was an error while obtaining new address" = "There was an error while obtaining new address";

Expand Down Expand Up @@ -2432,6 +2450,9 @@
/* Voting */
"Voting:" = "Voting:";

/* ZenLedger */
"Wait until the chain is fully synced, so we can review your transaction history." = "Wait until the chain is fully synced, so we can review your transaction history.";

/* No comment provided by engineer. */
"Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up." = "Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up.";

Expand Down Expand Up @@ -2714,3 +2735,6 @@

/* No comment provided by engineer. */
"Your wallet is secured now. You can use your recovery phrase anytime to recover your account on another device." = "Your wallet is secured now. You can use your recovery phrase anytime to recover your account on another device.";

/* No comment provided by engineer. */
"ZenLedger" = "ZenLedger";
24 changes: 24 additions & 0 deletions DashWallet/cs.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@
/* CrowdNode */
"All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device." = "All transfers to and from CrowdNode from this device will be performed with the below Dash address from this device.";

/* ZenLedger */
"Allow" = "Allow";

/* No comment provided by engineer. */
"Allow camera access in Settings" = "Povolte přístup k fotoaparátu v nastavení";

/* No comment provided by engineer. */
"Allow Face ID access in Settings" = "Povolte přístupk k Face ID v nastavení";

/* ZenLedger */
"Allow sending all transactions from Dash Wallet to Zenledger?" = "Allow sending all transactions from Dash Wallet to Zenledger?";

/* No comment provided by engineer. */
"Allow Touch ID access in Settings" = "Povolote přístup k Touch ID v nastavení";

Expand Down Expand Up @@ -428,6 +434,9 @@
/* No comment provided by engineer. */
"Connect with third party exchanges" = "Spojte se s burzami třetích stran";

/* ZenLedger */
"Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions." = "Connect your crypto wallets to the ZenLedger platform. Learn more and get started with your Dash Wallet transactions.";

/* Buy Sell Portal
Coinbase Entry Point */
"Connected" = "Připojeno";
Expand Down Expand Up @@ -751,6 +760,9 @@
/* No comment provided by engineer. */
"Explore Dash" = "Prozkoumejte Dash";

/* ZenLedger */
"Export all transactions" = "Export all transactions";

/* No comment provided by engineer. */
"Extended Public Keys" = "Rozšířené veřejné klíče";

Expand Down Expand Up @@ -1998,6 +2010,9 @@
/* CrowdNode Portal */
"Sign up to finish setting up account" = "Sign up to finish setting up account";

/* ZenLedger */
"Simplify your crypto taxes" = "Simplify your crypto taxes";

/* No comment provided by engineer. */
"Skip" = "Přeskočit";

Expand Down Expand Up @@ -2130,6 +2145,9 @@
/* Usernames */
"There was a network error, you can try again at no extra cost" = "There was a network error, you can try again at no extra cost";

/* ZenLedger */
"There was an error when exporting your transaction history to ZenLedger" = "There was an error when exporting your transaction history to ZenLedger";

/* Coinbase */
"There was an error while obtaining new address" = "There was an error while obtaining new address";

Expand Down Expand Up @@ -2432,6 +2450,9 @@
/* Voting */
"Voting:" = "Voting:";

/* ZenLedger */
"Wait until the chain is fully synced, so we can review your transaction history." = "Wait until the chain is fully synced, so we can review your transaction history.";

/* No comment provided by engineer. */
"Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up." = "Wait until the chain is fully synced, so we can review your transaction history. Visit CrowdNode website to log in or sign up.";

Expand Down Expand Up @@ -2714,3 +2735,6 @@

/* No comment provided by engineer. */
"Your wallet is secured now. You can use your recovery phrase anytime to recover your account on another device." = "Peněženka je teď zabezpečena. Frázi pro obnovení můžete kdykoliv použít pro obnovení na jiném zařízení.";

/* No comment provided by engineer. */
"ZenLedger" = "ZenLedger";
Loading