Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network information to listValidEnvironments #986

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jan 18, 2024

Feature or Bugfix

  • Bugfix

Detail

Missing API output definition to list environment networks in creation of notebooks

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor Author

dlpzx commented Jan 18, 2024

Testing:

  • CICD pipeline succeeds
  • network information appears in UI when creating notebooks

@noah-paige
Copy link
Contributor

Testing (1st Iteration):

  • CICD pipeline succeeds
  • Network information appears in UI when creating notebooks
    • Received error since the EnvironmentSimplified return type did not include networks related fields

@noah-paige
Copy link
Contributor

Testing Second Iteration:

  • CICD pipeline succeeds
  • Network information appears in UI when creating notebooks

@dbalintx
Copy link
Contributor

LGTM!

Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving

@noah-paige noah-paige linked an issue Jan 19, 2024 that may be closed by this pull request
@noah-paige noah-paige merged commit 4732e4e into main Jan 19, 2024
8 checks passed
@dlpzx dlpzx deleted the fix/notebook-network-dropdown branch February 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network drop down selection on Notebook creation page
3 participants