Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for the /telemetry-ext endpoint #2259

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Conversation

shreyas-goenka
Copy link
Contributor

Changes

Followup from #2209 (review).

This PR adds an integration test to validate that the API type bindings work against the telemetry endpoint.

Tests

N/A

@shreyas-goenka shreyas-goenka changed the base branch from main to proto-bundle-telemetry January 29, 2025 11:49
@shreyas-goenka shreyas-goenka marked this pull request as draft January 29, 2025 11:49
@shreyas-goenka shreyas-goenka changed the base branch from proto-bundle-telemetry to main January 29, 2025 11:49
@shreyas-goenka shreyas-goenka marked this pull request as ready for review January 29, 2025 11:50
respB := telemetry.ResponseBody{}

err = apiClient.Do(ctx, "POST", "/telemetry-ext", nil, nil, reqB, &respB)
require.NoError(t, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're building a client for this that performs the marshalling, make sure to update the call site here as well.

@shreyas-goenka shreyas-goenka added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit c3a6e11 Jan 29, 2025
9 checks passed
@shreyas-goenka shreyas-goenka deleted the test-protos branch January 29, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants