Added filter block to databricks_instance_profiles data source
#2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehab-eb
commented
Dec 4, 2023
1 task
ehab-eb
force-pushed
the
filter_instance_profiles
branch
3 times, most recently
from
248f98d
to
8732f62
Compare
nkvuong
force-pushed
the
filter_instance_profiles
branch
from
8732f62
to
b1c0f85
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
+ Coverage 84.14% 84.17% +0.03%
==========================================
Files 159 159
Lines 13897 13912 +15
==========================================
+ Hits 11694 11711 +17
+ Misses 1534 1533 -1
+ Partials 669 668 -1
|
alexott
requested changes
Jan 9, 2024
Comment on lines
+49
to
+53
| var fieldNames []string | ||
| val := reflect.ValueOf(instanceProfileData{}) | ||
| for i := 0; i < val.Type().NumField(); i++ { | ||
| fieldNames = append(fieldNames, val.Type().Field(i).Tag.Get("json")) | ||
| } |
There was a problem hiding this comment.
We can avoid having this if we expose listAllFields function implemented in #3044 - in this case it will handle inherited fields correctly
Comment on lines
+55
to
+57
| if data.Filter.Name == "" { | ||
| return fmt.Errorf("field `name` cannot be empty") | ||
| } |
There was a problem hiding this comment.
I think that we can move this condition after the line 48
| _ = json.Unmarshal(m, &ipMap) | ||
| val := ipMap[filter.Name] | ||
| stringVal := fmt.Sprint(val) | ||
| re := regexp.MustCompile(filter.Pattern) |
There was a problem hiding this comment.
It's better to use .Compile and check for the error. Also, it's very inefficient - it's better to check validity of the regexp earlier, around line 46, compile regexp, and pass it explicitly. Otherwise we'll compile it on each function invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds filtering capabilities to the
databricks_instance_profilesdata source. A new optional blockfilteris introduced that exposes two arguments:name: This takes the name of the instance profile attribute to filter onpattern: This takes a regex pattern to use for filtering based on the field specified in thenameargumentOnly one
filterblock can be specified.Tests
make testrun locallydocs/folderinternal/acceptance