Moved contains function to common package
#2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mgyucht
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Just curious, can we use https://pkg.go.dev/golang.org/x/exp/slices#Contains? I think it is almost exactly the same thing.
|
I see no reason not to. The repo is already part of the project so there will be no new dependencies and the functionality is exactly what's needed. I've gone ahead and replaced it. I only opened this PR to aid with my other PR #2988 - If I'm omitting the custom function altogether then this PR is no longer a dependency, but maybe it's worth just dealing with it now since we're on the topic :) |
ehab-eb
force-pushed
the
move_contains_to_common
branch
2 times, most recently
from
46763b5
to
fce534f
Compare
ehab-eb
force-pushed
the
move_contains_to_common
branch
from
fce534f
to
480a5d0
Compare
mgyucht
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moving the
containsfunction from thecatalogmodule tocommonto be used across packagesTests
make testrun locally[ ] relevant change indocs/folder[ ] covered with integration tests ininternal/acceptance[ ] relevant acceptance tests are passing[ ] using Go SDK