[Feature] Add databricks_query resource instead of databricks_sql_query
#4103
+637
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
requested review from
renaudhartert-db and
mgyucht
and removed request for
a team
mgyucht
reviewed
Oct 17, 2024
| * `description` - (Optional, String) General description that conveys additional information about this query such as usage notes. | ||
| * `run_as_mode` - (Optional, String) Sets the "Run as" role for the object. | ||
| * `tags` - (Optional, List of strings) Tags that will be added to the query. | ||
| * `parameter` - (Optional, Block) Query parameter definition. Consists of following attributes (one of `*_value` is required): |
There was a problem hiding this comment.
Just curious: in other docs, these blocks are often documented as their own headings. Is there any need for consistency around these aspects?
There was a problem hiding this comment.
that's a good question - sometimes, moving to a separate block will add an unnecessary context switch. But agree, we need to unify this
alexott
force-pushed
the
new-query-resource
branch
from
e226dca
to
8e12ef7
Compare
…alert` New resource use the [new Alerts API](https://docs.databricks.com/api/workspace/alerts/create) instead of legacy one that will be deprecated. New resource has slightly different set of parameters, so it was decided to create new resource and deprecate old one. This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented).
…query` This PR is built on top of #4051 that should be merged first. The new resource uses the new [Queries API](https://docs.databricks.com/api/workspace/queries/create) instead of the legacy one that will be deprecated. Since the new resource has a slightly different set of parameters, it was decided to create a new resource and deprecate the old one. This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented). TODOs: - Add documentation - Need to discuss how to handle permissions - `sql_query` permissions look like working, but not sure if we should continue to use that API - Support in the exporter will be in a separate PR
alexott
force-pushed
the
new-query-resource
branch
from
1eab187
to
73f19a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is built on top of #4051 which should be merged first.
The new resource uses the new Queries API instead of the legacy one that will be deprecated. Since the new resource has a slightly different set of parameters, it was decided to create a new resource and deprecate the old one.
This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented).
TODOs:
sql_querypermissions look like working, but not sure if we should continue to use that APITests
make testrun locallydocs/folderinternal/acceptance