Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add databricks_query resource instead of databricks_sql_query #4103

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Feature] Add databricks_query resource instead of databricks_sql_query #4103

wants to merge 10 commits into from
+637 −43

Commits on Oct 19, 2024

  1. [Feature] Add databricks_alert resource to replace `databricks_sql_… 

    …alert`

New resource use the [new Alerts API](https://docs.databricks.com/api/workspace/alerts/create)
instead of legacy one that will be deprecated. New resource has slightly different set of
parameters, so it was decided to create new resource and deprecate old one.

This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented).
    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9107638 View commit details
    Browse the repository at this point in the history

  2. Started to add unit tests

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9793b54 View commit details
    Browse the repository at this point in the history

  3. Add an example of permissions for alerts

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a46b16f View commit details
    Browse the repository at this point in the history

  4. [Feature] Add databricks_query resource instead of `databricks_sql_… 

    …query`

This PR is built on top of #4051 that should be merged first.

The new resource uses the new [Queries API](https://docs.databricks.com/api/workspace/queries/create) instead of the legacy one that will be deprecated. Since the new resource has a slightly different set of parameters, it was decided to create a new resource and deprecate the old one.

This resource uses old TF SDK to be compatible with TF exporter (until #4050 is implemented).

TODOs:

- Add documentation
- Need to discuss how to handle permissions - `sql_query` permissions look like working, but not sure if we should continue to use that API
- Support in the exporter will be in a separate PR
    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5f47bb8 View commit details
    Browse the repository at this point in the history

  5. Add documentation

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    60d0d5f View commit details
    Browse the repository at this point in the history

  6. Fix integration test

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9e641a0 View commit details
    Browse the repository at this point in the history

  7. Adjust migration documentation, update permissions test

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e680e99 View commit details
    Browse the repository at this point in the history

  8. Fix integration test, adjust docs

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    11082ab View commit details
    Browse the repository at this point in the history

  9. Added suppress diff for notify setting in alert

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    15967bf View commit details
    Browse the repository at this point in the history

  10. notify_on_ok is true by default

    @alexott
    alexott committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    73f19a0 View commit details
    Browse the repository at this point in the history