Fix flaky domains.js and managed_ingestion.js tests #8492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Jul 25, 2023
| @@ -23,7 +23,7 @@ describe("add remove domain", () => { | |||
| cy.waitTextVisible("Add assets") | |||
| cy.clickOptionWithText("Add assets") | |||
| cy.get(".ant-modal-content").within(() => { | |||
| cy.get('[data-testid="search-input"]').click().invoke("val", "cypress_project.jaffle_shop.").type("customer") | |||
| cy.get('[data-testid="search-input"]').type("cypress_project.jaffle_shop.customer") | |||
There was a problem hiding this comment.
Just a question - Can you elaborate on why this helps the test to pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
managed_ingestion.js - We use 30 seconds "Succeeded" search timeout for ingestion and I've reproduced the timeout reach few times locally, other times ingestion took 27-29 seconds(close to timeout limit). I've increased the timeout to 40 seconds in attempt to fix flakyness.
domains.js - this test fails after reaching element search timeout after user enters search keyword. In attempt to fix this I've used .type() method for whole search text and not just 'customers' after using .invoke('va', 'text')
Checklist