Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky domains.js and managed_ingestion.js tests #8492

Closed
wants to merge 7 commits into from
Closed

Fix flaky domains.js and managed_ingestion.js tests #8492

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
584dfaa
Fix flaky domains.js and managed_ingestion.js tests
kkorchak Jul 24, 2023
01523cd
Merge branch 'master' into origin/FixFlakyDomainsAndManagedIngestionT…
jjoyce0510 Jul 25, 2023
4078a38
Merge branch 'master' into origin/FixFlakyDomainsAndManagedIngestionT…
kkorchak Aug 2, 2023
bf7786d
revert changes to domains.js
kkorchak Aug 2, 2023
0fb5604
Merge branch 'master' into origin/FixFlakyDomainsAndManagedIngestionT…
kkorchak Aug 2, 2023
0c352dd
Increasing timeout
kkorchak Aug 3, 2023
c1c941f
Merge branch 'master' into origin/FixFlakyDomainsAndManagedIngestionT…
kkorchak Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smoke-test/tests/cypress/cypress/e2e/mutations/domains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe("add remove domain", () => {
cy.waitTextVisible("Add assets")
cy.clickOptionWithText("Add assets")
cy.get(".ant-modal-content").within(() => {
cy.get('[data-testid="search-input"]').click().invoke("val", "cypress_project.jaffle_shop.").type("customer")
cy.get('[data-testid="search-input"]').type("cypress_project.jaffle_shop.customer")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question - Can you elaborate on why this helps the test to pass?

cy.contains("BigQuery")
cy.get(".ant-checkbox-input").first().click()
cy.get("#continueButton").click()
Expand Down
2 changes: 1 addition & 1 deletion smoke-test/tests/cypress/cypress/e2e/mutations/managed_ingestion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe("run managed ingestion", () => {
cy.waitTextVisible(testName)

cy.contains(testName).parent().within(() => {
cy.contains("Succeeded", {timeout: 30000})
cy.contains("Succeeded", {timeout: 40000})
cy.clickOptionWithTestId("delete-button");
})
cy.clickOptionWithText("Yes")
Expand Down
Loading