-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): disable access management ui when no roles are linked to entity #9610
feat(UI): disable access management ui when no roles are linked to entity #9610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable! quick check to see if you'd prefer to do the check if there's any roles at all for the dataset.
also - do you think it would make more sense to hide the tab entirely if there's no roles associated with it? i could go either way
I don’t mind either way :) would you want a 2nd (or 3rd) opinion on this? If so, feel free to @ Otherwise I’d probably keep it as-is. Wdyt? |
I guess since there was no veto regarding disabling the tab instead of hiding it, I'd keep it as-is? Then this behaves the same as e.g. the Validation tab |
Unfortunately Cypress seems to have some issue currently:
|
any updates? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the one comment change and then we'll be good to merge! sorry for the delay on this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
…tity (datahub-project#9610) Co-authored-by: Hendrik Richert <[email protected]>
Disable access management ui when no roles are linked to entity
See https://datahubspace.slack.com/archives/CV2UXSE9L/p1704699920392329 for reference.
Checklist