[#40, #54] Configuration file with computed fields and include/exclude file options #84
Conversation
|
mohamedsalem401
changed the title
|
@mohamedsalem401 does this reflect the comments in the PR yesterday re the definition in the README PR of this feature? |
There was a problem hiding this comment.
I can already see at least one issue is that the system should continue to work without a config folder.
In general, i'd strongly recommend (as discussed last week) that we get an example working without the config folder stuff but just with passing config to the relevant class or function e.g. buildMarkdownDB or whatever it is called.
once that API is well shaped adding config in a file is relatively straightforward ...
| // TODO get these from markdowndb.config.js or something | ||
| const dbPath = "markdown.db"; | ||
| const ignorePatterns = [/Excalidraw/, /\.obsidian/, /DS_Store/]; | ||
| const [contentPath] = process.argv.slice(2); | ||
| const [contentPath, configFilePath] = process.argv.slice(2); |
There was a problem hiding this comment.
What happens if you don't have a config file - this stuff should work with defaults ...
There was a problem hiding this comment.
@rufuspollock
OK, but what should be defaulted?
-
Currently, it defaults to searching for
markdowndb.config.jsif no config path is passed. -
If
markdowndb.config.jsis missing, it defaults to - no custom fields - and includes all files. -
If a config path is passed but doesn't exist, then it raises an error:
Error loading configuration file from....
|
@mohamedsalem401 another general comment - i'd have kept the include/exclude feature for a separate PR. It makes the review easier and faster ... |
|
I will close this for now |
Closes #40
Closes #54