Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#40, #54] Configuration file with computed fields and include/exclude file options #84
[#40, #54] Configuration file with computed fields and include/exclude file options #84
Changes from 5 commits
cf8636a
7f95118
7e42ae2
156f79f
48b38c4
a27ff6f
b15bf09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 3 in src/bin/index.js
GitHub Actions / Lint & format check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you don't have a config file - this stuff should work with defaults ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rufuspollock
OK, but what should be defaulted?
Currently, it defaults to searching for
markdowndb.config.js
if no config path is passed.If
markdowndb.config.js
is missing, it defaults to - no custom fields - and includes all files.If a config path is passed but doesn't exist, then it raises an error:
Error loading configuration file from...
.Check warning on line 5 in src/lib/CustomConfig.ts
GitHub Actions / Lint & format check
Check warning on line 26 in src/lib/markdowndb.ts
GitHub Actions / Lint & format check
Check failure on line 45 in src/lib/markdowndb.ts
GitHub Actions / Lint & format check
Check warning on line 73 in src/lib/markdowndb.ts
GitHub Actions / Lint & format check
Check warning on line 279 in src/lib/markdowndb.ts
GitHub Actions / Lint & format check
Check failure on line 22 in src/lib/process.ts
GitHub Actions / Lint & format check