Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: checks using emoji [DO NOT MERGE] #43

Closed
wants to merge 1 commit into from
Closed

Conversation

david-allison
Copy link
Owner

This orders all of the 'checks' together
and makes 'Sync Translations' easier to recognize

Before:

  • Code Quality Checks
  • Emulator Tests
  • Publish
  • Sync Translations
  • Unit Tests

After:

  • 🚀 Publish
  • 🌐 Sync Translations
  • 🛠️ Code Quality Checks
  • 🛠️ Emulator Tests
  • 🛠️ Unit Tests

Purpose / Description

Describe the problem or feature and motivation

Fixes

  • Fixes #

Approach

How does this change address the problem?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

This orders all of the 'checks' together
and makes 'Sync Translations' easier to recognize

Before:

* Code Quality Checks
* Emulator Tests
* Publish
* Sync Translations
* Unit Tests

After:

* 🚀 Publish
* 🌐 Sync Translations
* 🛠️ Code Quality Checks
* 🛠️ Emulator Tests
* 🛠️ Unit Tests

----

Conflict scan & Labels sometimes appear on the PRs checks,
so icons were added for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant