Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Git Provider should support multiple identities for the same user #777

Closed
abhishek818 opened this issue Jul 15, 2024 · 24 comments
Closed
Labels
💎 Bounty enhancement New feature or request help wanted Extra attention is needed 💰 Rewarded

Comments

@abhishek818
Copy link
Contributor

abhishek818 commented Jul 15, 2024

Is your feature request related to a problem? Please describe.
With reference to discussions in the issue, Users having multiple accounts or multiple access tokens for a git provider (each with their own permissions, access to different organizations and repos) might need the requirement to have the ability to use repos and organizations limited for a specific token.
(Can have multiple access tokens within the same account also, ex - separate tokens for public and private repos)

Currently, the command for adding a new git provider just asks for a access token and overrides any existing token (if exists). To move back to previous identity, he/she will need to add back the corresponding token for a git provider. This requires the user to remember the access tokens (last used) for their specific needs. Overall, only a single identity is supported at a time.

Describe the solution you'd like
daytona gp add command must ask user to provide unique identity names for each token.
And subsequently daytona create command will need the user to input the identity name first.

Describe alternatives you've considered
None or N/A

Additional context
The implementation plan is open to suggestions, nothing is finalized yet.

Edit: Also includes #777 (comment)

@abhishek818 abhishek818 added the enhancement New feature or request label Jul 15, 2024
@Tpuljak Tpuljak added the backlog backlog until further notice label Jul 16, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Jul 16, 2024

One more thing to consider here:
When the user runs daytona create REPO_URL, the server must "auto-select" the appropriate provider identity as well.

@lbrecic lbrecic removed the backlog backlog until further notice label Jul 17, 2024
@lbrecic
Copy link
Contributor

lbrecic commented Jul 17, 2024

/bounty $200

Copy link

algora-pbc bot commented Jul 17, 2024

💎 $300 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #777 with your implementation plan
  2. Submit work: Create a pull request including /claim #777 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Please respect others by working on PRs that you are allowed to submit attempts to.

e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR.

If you can not submit an attempt, you will not receive your payout.

Thank you for contributing to daytonaio/daytona!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @abhishek818 Jul 17, 2024, 11:56:36 AM WIP
🟢 @onyedikachi-david Aug 8, 2024, 11:32:00 AM WIP
🟢 @the-johnwick Aug 15, 2024, 5:24:06 PM #1032

@abhishek818
Copy link
Contributor Author

Can you assign me this since i have created the issue and totally understand it!

@abhishek818
Copy link
Contributor Author

abhishek818 commented Jul 17, 2024

/attempt #777

Algora profile Completed bounties Tech Active attempts Options
@abhishek818    5 daytonaio bounties
+ 8 bounties from 5 projects
JavaScript, TypeScript
﹟727
Cancel attempt

@abhishek818
Copy link
Contributor Author

Cancelling my attempt until #763 (comment)

@abhishek818
Copy link
Contributor Author

Since there is almost no work left on my remaining PRs and couple got completed, Can i take a crack at this?

@Tpuljak
Copy link
Member

Tpuljak commented Jul 25, 2024

@abhishek818 have at it 😄

@RS-labhub
Copy link
Contributor

300 usd 😮🤑

@harkiratsm
Copy link
Contributor

@abhishek818 are you currently working on this ?

@abhishek818
Copy link
Contributor Author

yes

@cryptjohel
Copy link

I need to get my hands to work 😞 my system is faulty as from Monday I finish it all 💪🏽😌

@onyedikachi-david
Copy link
Contributor

onyedikachi-david commented Aug 8, 2024

/attempt #777

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david 5 bounties from 2 projects
JavaScript, Shell
Cancel attempt

@the-johnwick
Copy link
Contributor

Hey @abhishek818, are you still working on this issue? I've completed most of the work on this issue, and if you're okay with it, I can go ahead and raise a PR to help resolve it. Let me know what you think!

@abhishek818
Copy link
Contributor Author

@the-johnwick sure go ahead, removing my assignment.
Sorry to all others if they have been waiting due to me, it's just things are going bad on my side recently...

@the-johnwick
Copy link
Contributor

@abhishek818 No worries at all, it's totally understandable. If there's anything I can do to help out or if you need support with anything else, just let me know. Take care, and I hope things get better for you soon!

@Tpuljak
Copy link
Member

Tpuljak commented Aug 12, 2024

I'll leave the issue unassigned for now since we have a draft PR up and @the-johnwick is close to submitting the PR as well.

We'll assign someone once we have a chance to do an initial review

@the-johnwick
Copy link
Contributor

PR closed accidentally i am still working on it.

@Tpuljak
Copy link
Member

Tpuljak commented Aug 13, 2024

PR closed accidentally i am still working on it.

I can't reopen it because your branch contains no new changes. Btw, it will be much easier to work if you open a PR from another branch in your repo, not main.

@the-johnwick
Copy link
Contributor

I will reopen the PR from different branch

@the-johnwick
Copy link
Contributor

the-johnwick commented Aug 15, 2024

/attempt #777

Algora profile Completed bounties Tech Active attempts Options
@the-johnwick    1 daytonaio bounty
+ 1 bounty from 1 project
Cancel attempt

@the-johnwick
Copy link
Contributor

@Tpuljak Submitted the PR but checks are filling I tried ran docs generation and still it is failling

Copy link

algora-pbc bot commented Sep 3, 2024

💡 @the-johnwick submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Oct 9, 2024

🎉🎈 @the-johnwick has been awarded $300! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty enhancement New feature or request help wanted Extra attention is needed 💰 Rewarded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants