-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi-profile support for git providers(#777) #1032
Conversation
10bcb9a
to
cace993
Compare
@the-johnwick the PR is ready for review but there's nothing in the description and one of the checks is failing. |
@Tpuljak yes I already commented the problem #777 (comment) |
That comment should go on the PR and not the issue. Please include a description in the PR before requesting a review. The description should be filled out according to the template and be enough to describe all the changes made in the PR. |
Did you run |
@Tpuljak Sure I will add detailed description. |
Yes, twice |
@Tpuljak No, I wasn't using Daytona and in last commit those two files were modified but still failling the checks |
Please rerun it and commit (without forcing) separately. |
@Tpuljak ok I will try |
@Tpuljak No differnce. it is still failing with the same error |
@the-johnwick can you please record your screen while running
|
sure i will record |
Thanks for the video. I noticed that you're running this on windows. That's the issue. Please run with |
I will try it again 🙂 |
e3cfb24
to
baa3fbb
Compare
@Tpuljak You check the PR now I have added the description and all checks are passing now. |
baa3fbb
to
bbd6821
Compare
@Tpuljak You can check the PR now I have resolved the merge conflicts and added the detailed description of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started with the review but I got a FATAL
error when running dtn gp ls
.
I had git providers set on the main branch and then switched to yours.
I assume that this branch is a breaking change due to changes in the GitProviderConfig struct.
Please add a breaking change description to the PR and BREAKING CHANGE: <description>
above the signoff in the commit (you should squash the commits into one). The description in the PR should include steps on how to act after upgrading, while the description in the commit should only include what "broke".
@Tpuljak Thank you for the review. Could you please share a screenshot of the error so I can better understand what happened? The expected behavior is that it should work perfectly across all branches since the changes I made are branch-independent. Additionally, I believe we don't have separate Git configurations for different branches from the same repository. |
Git providergp.mp4Project Config Addpc.mp4Project creationcreate.mp4 |
75b4951
to
94bd8a9
Compare
@Tpuljak Can I Spilt this PR in to part since it is big PR and it implements more than one features and it would be easy for you to review as well. |
There are more than 180 conversation items here and it's close to done. No need to split this into 2 PRs since it's only one feature that it implements. |
0deebd5
to
d6ee4f7
Compare
BREAKING CHANGES: Remove All git provider config and readd it. Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
81c6bda
to
e0824f3
Compare
Signed-off-by: John Wick <[email protected]>
e0824f3
to
2181b0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this. Everything seems to be working as it should now.
Added 3 more small comments that should be addressed and then I can approve.
Signed-off-by: John Wick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Signed-off-by: John Wick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your time! @the-johnwick
Support for Multiple Git Provider Tokens and Auto-Selection
Description
This update allows users to add multiple tokens for the same Git provider and specify which token to use with the
--git-provider-config-id="..."
flag or let the system auto-select the appropriate token.Key Changes:
Git Provider Config Struct:
Alias
: Token alias for better identification.ProviderId
: Git provider name (e.g., GitHub, GitLab).UUID
.Project and Project Config:
GitProviderConfigId
field to associate a specific Git provider config with the project or project config.Token Selection Logic:
Breaking Change:
Id
of the Git provider config is now a randomly generatedUUID
.ProviderId
now represents the Git provider name instead of an identifier.This PR addresses issue #777
/claim #777