Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-profile support for git providers #925

Closed

Conversation

the-johnwick
Copy link
Contributor

Git providers support multiple identities for the same user.

Description

Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

This PR addresses issue #777
/claim #777

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

Signed-off-by: the-johnwick <[email protected]>
@the-johnwick
Copy link
Contributor Author

@Tpuljak all other things are completed. Now I am working on auto selection logic
I have some cases in mind :

  • Case 1: User has org level token (single/multiple)
  • Case 2: User has repo level token (single/multiple)
  • Case 3: User has admin level token (single)

Would like to add any other case to this ?

@Tpuljak
Copy link
Member

Tpuljak commented Aug 19, 2024

Would like to add any other case to this?

You are free to suggest the best approach. I have nothing to add at this point.

@the-johnwick
Copy link
Contributor Author

Would like to add any other case to this?

You are free to suggest the best approach. I have nothing to add at this point.

We need a way to figure out how to select a global access token if there are multiple for the same git provider.

Signed-off-by: the-johnwick <[email protected]>
@Tpuljak
Copy link
Member

Tpuljak commented Aug 19, 2024

We need a way to figure out how to select a global access token if there are multiple for the same git provider.

I suggest you try to find a tool that has a similar feature (handling multiple git provider tokens) and find inspiration there.

Signed-off-by: the-johnwick <[email protected]>
@the-johnwick the-johnwick force-pushed the multi-profile-git-provider branch 2 times, most recently from b0bc76d to 0282030 Compare August 29, 2024 12:53
Signed-off-by: the-johnwick <[email protected]>
@the-johnwick
Copy link
Contributor Author

closing this PR. #1032

@the-johnwick the-johnwick deleted the multi-profile-git-provider branch September 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants