Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent logs #432

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: agent logs #432

merged 1 commit into from
Apr 25, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Apr 25, 2024

Agent Logs

Description

This PR introduces the daytona agent logs [-f] command that can be used inside a project to view agent logs.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related Issue(s)

Closes #431

@Tpuljak Tpuljak requested a review from a team as a code owner April 25, 2024 09:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 389 files.

Valid Invalid Ignored Fixed
268 1 120 0
Click to see the invalid file list
  • pkg/agent/log.go
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

pkg/agent/log.go Show resolved Hide resolved
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Can we lose the log type tags and keep just the text?

User can now get agent logs inside the project with the agent logs command

Signed-off-by: Toma Puljak <[email protected]>
@Tpuljak
Copy link
Member Author

Tpuljak commented Apr 25, 2024

Can we lose the log type tags and keep just the text?

You're right. I amended an update where the tags are left out of the creation screen but kept in daytona agent logs.

Screenshot 2024-04-25 at 14 32 56

@Tpuljak Tpuljak merged commit d6c2418 into main Apr 25, 2024
5 checks passed
@Tpuljak Tpuljak deleted the agent-logs branch April 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent logs command
3 participants