Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config linting for CI #25

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Config linting for CI #25

merged 6 commits into from
Jan 17, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #10

Add linting to CI. All python versions are tested. The run time/cost are insignificant and there is value in at least testing the oldest and newest versions for typing.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jan 16, 2024
@mikealfare
Copy link
Contributor Author

This requires #22 to be merged first as it depends on an action in that PR.

@mikealfare mikealfare changed the title Config linting for ci Config linting for CI Jan 16, 2024
@mikealfare mikealfare requested a review from a team January 16, 2024 22:28
.github/lint.yml Outdated Show resolved Hide resolved
.github/lint.yml Outdated Show resolved Hide resolved
@mikealfare mikealfare dismissed emmyoop’s stale review January 17, 2024 20:42

I resolved the issue

@mikealfare mikealfare merged commit fb6d0ac into main Jan 17, 2024
5 checks passed
@mikealfare mikealfare deleted the config/ci/lint branch January 17, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI workflows
2 participants