Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra symbol in log message #825

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

haojiongwang
Copy link

@haojiongwang haojiongwang commented Feb 18, 2025

resolves #
this issue

Problem

Solution

after removing the backtick log message looks correct:

06:01:55  Failure in model customer_with_order_cnt_v1 (models/customer_with_order_cnt_v1.sql)
06:01:55    Compilation Error in model customer_with_order_cnt_v1 (models/customer_with_order_cnt_v1.sql)
  Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: ['number_of_orders']

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link

cla-bot bot commented Feb 18, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @haojiongwang

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-adapters package. For details on how to document a change, see the Contributing Guide.

@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Feb 18, 2025
@cla-bot cla-bot bot temporarily deployed to dbt-snowflake February 18, 2025 13:04 Inactive
@haojiongwang
Copy link
Author

hi @colin-rogers-dbt , thanks for taking a look! The BigQuery integration test timed out in the last build, but it doesn’t seem related to my PR. Also, the pre-commit check failed after merging main into this PR. Could you review when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants