Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra symbol in log message #825

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix extra symbol in log message #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8dd840e
fix extra symbol in log message
haojiongwang Feb 18, 2025
5da0b18
changelogs
haojiongwang Feb 18, 2025
1115d4e
Merge branch 'main' into bugfix/extra-symbol-log-result
haojiongwang Feb 19, 2025
1833227
Merge branch 'main' into bugfix/extra-symbol-log-result
colin-rogers-dbt Mar 3, 2025
977ed08
Merge branch 'main' into bugfix/extra-symbol-log-result
haojiongwang Mar 4, 2025
9e4648c
Merge branch 'main' into bugfix/extra-symbol-log-result
haojiongwang Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dbt-adapters/.changes/unreleased/Fixes-20250218-080104.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix the extra '`' symbol in the log
time: 2025-02-18T08:01:04.66106-05:00
custom:
Author: haojiongwang
Issue: "196"
2 changes: 1 addition & 1 deletion dbt-adapters/src/dbt/include/global_project/macros/adapters/columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
{%- if (col_err | length) > 0 -%}
{{ exceptions.column_type_missing(column_names=col_err) }}
{%- elif (col_naked_numeric | length) > 0 -%}
{{ exceptions.warn("Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: " ~ col_naked_numeric ~ "`") }}
{{ exceptions.warn("Detected columns with numeric type and unspecified precision/scale, this can lead to unintended rounding: " ~ col_naked_numeric) }}
{%- endif -%}
{% endmacro %}

Expand Down
Loading