This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
feat(ingress): experimental native ingress #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding documentation changes for Kubernetes ingress support. Non breaking change, as users must opt-in to the feature.
Remove extra spaces to clean up deploy-an-app.md Non breaking change.
A few semantic changes, and supporting enabled/disable in requirements.yaml Non breaking change.
We changed the helm charts for this, just updating docs to match Non breaking change.
s/engress/ingress Breaking change (as the feature wasn't working before the typo fix)
Go back to working if statements, until we can resolve helm/helm#2111 Non breaking change
Changing documentation per the code review, mostly typos and wordsmithing. Non breaking change
Fixing typo in `experimental` Non breaking change
Fixing extraneous new lines, and wordsmithing. Non breaking change
|
@slack, @Joshua-Anderson and @bacongobbler are potential reviewers of this pull request based on my analysis of |
|
Since this is just a rebasing of #732, I'm going to consider those LGTMs also to apply here. 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rebase of #732 to see if we can avoid the CI issues it was running into. All credit goes to @kris-nova of course.
Work for experimental native ingress. Run the documentation to see how to use the new feature.
Requires deis/controller#1243
Requires deis/builder#495
Requires deis/router#316