Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/appeals 34965 #22154

Draft
wants to merge 569 commits into
base: main
Choose a base branch
from
Draft

Feature/appeals 34965 #22154

wants to merge 569 commits into from

Conversation

cacevesva
Copy link
Contributor

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to Jira Issue/Test Plan Link or list them below
  • For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

HunJerBAH and others added 30 commits April 29, 2024 14:29
* added migrations to refactor correspondence intake relationship to task instead of user/correspondence

* updated model relations and controller check for an open intake

* updated specs to reflect code changes.

* removed leftover pry
* draft pr

* Completing AC for ticketing for styling and error portion of page. Now doing feature test

* added ability for user to search by css id

* added feature tests for using search bar

* reverted changes in package.json

* removed added file

* removed linting error

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
* working checkboxes and permissions area

* latest changes for sharing

* changing css styling and moving stuff over to .scss file

* added state tracking for nod checkbox

* Added superuser checkbox functionality

* moving scss to dedicated file

* changing padding to add with checkbox padding for total of 30px

* removing console logs and adding back top border

* permissions now come through props

* updated to dynamically render checkboxes

* generating nod checkbox if parent exists

* Adding column default_for_admin on organization_permissions

* reducing payload for organizationPermissions

* Fixing checkboxes to behave when different boxes are checked

* Proptypes addition for linting

* creating route for patch

* WIP user permissions

* Getting started on spec writing. Not working yet!

* reverted organization_permissions to hopefully avoid everyone running a make reset for this data.

* reworked the remove and add permissions patch method.

* added a little documentation to OrganizationUserPermissionChecker

* Moving to correct spec, and working on other ways of writing the test to get it to pass

* checkboxes now read state off the backend

* checkboxes partially working

* fixed state bug

* implemented superuser checkbox and disabling of it.

* schema change and re-adding default admin column

* created basic feature tests for inbound ops team management

* continuing working on the controller spec

* moved user permission/admin check to user model

* house keeping

* added conditional for admin permission checkbox rendering.

* working superuser checkbox restriction

* fixed checkbox default value bug

* refactored permission shape

* removed old methods

* checkboxes fixed (I think)

* set up admin check to return bool instead of obj

* refactored organization permissions and updated test factories to stage permissions

* working seed data

* removed binding prys

* fixed checkbox logic. needs suggestion changes though

* created feature test for inbound ops team

* changed list to div

* fixed several parts of code based on feedback

* added conditional rendering

* refactored glamor style into javascript object for checkbox

* fixed schema

* reverted org permissions json file to its intended design

* reverted valid_permission_names back to its intended state.

* fixed seed data

* linting fix

* mostly refactored

* included new frontend data (not wired)

* data population refactor finished

* fixed color

* Added a customizable per page task limitation attribute to QueueTab that is used by task_pager to allow an adjustable maximum number of tasks per tab. (#21594)

Co-authored-by: = <[email protected]>

* fixed lingering css

* APPEALS-42958: Consolidated Superuser Permissions Check (#21454)

* consolidated backend checks to use inbound_ops_team_superuser over mail_superuser

* updated superuser namespace in the frontend

* APPEALS-44391: Intake Correspondence Rerouting (#21447)

* cleaned up magic string usage

* updated cancel routing for superusers

* fixed linting issues

* added rerouting for users that cannot access a specific intake

* updated Review Package task to be the same user that was assigned the Intake

* resolved linting issues

* updated inbound ops team superuser check

* refactored intake controller test

* refactored reassign package task specs and reassignment on cancel

* refactored task specs to be more DRY

* added intake task fix to intake_form_spec

* cleaned up test failures related to intake task within intake.

* refactored related correspondence spec tests

* updated test to click correct section

* updated failing snapshots

* fixed typo on prop validations

* added prop to hide dropdown if review package has an efolder failed task (#21497)

* APPEALS-44390: Soft Delete Correspondence Intake (#21508)

* added migrations to refactor correspondence intake relationship to task instead of user/correspondence

* updated model relations and controller check for an open intake

* updated specs to reflect code changes.

* removed leftover pry

* APPEALS-43421: Attorney Selection Sticking on Dropdown after Assignment (#21401)

* redo init commit

* updated imp. logic

* attorney widget fix

---------

Co-authored-by: Calvin <[email protected]>

* Add ruby CE API Gem

* remove correspondence changes from schema.rb (#21468)

* Revert "Add ruby CE API Gem" (#21479)

This reverts commit c78afe3.

* Override SCT Bulk Assign Page task limit (#21465)

* Override SCT Bulk Assign Queue 15 case limit & Adjust SCT attorney assign task action label

* feature/APPEALS-35707-29633-29632 (prodtest) (#21485)

* 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record`

* 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances

* 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash

* feature/APPEALS-44871 Steps for installing node in the Caseflow demo environment  (#21483) (#21484)

* Changed dockerfile to install node through NVM

* Update env.sh with node 14.20 path

* Removed unused node env

* Update Dockerfile Removed unused node env variable

* Revert "feature/APPEALS-44871 Steps for installing node in the Caseflow demo …" (#21489)

This reverts commit a626200.

* Sbashamoni/appeals 44871 node14 demo fixes (#21490) (#21495)

* Changed dockerfile to install node through NVM

* Update env.sh with node 14.20 path

* Removed unused node env

* Update Dockerfile Removed unused node env variable

* Removed unused node env

* add error rules to demo builds (#21496) (#21498)

Co-authored-by: davis-dwayne <[email protected]>

* added back in schema changes removed from master

* draft pr (#21509)

* draft pr

* Completing AC for ticketing for styling and error portion of page. Now doing feature test

* added ability for user to search by css id

* added feature tests for using search bar

* reverted changes in package.json

* removed added file

* removed linting error

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>

* draft pr

* searchable by 2 characters instead of 1

* added ability for user to search by css id

* reverted changes in package.json

* removed added file

* fixed params.permit issue

* removed organization made with includes

* reverted gemfile to master branch version

* Fixed linting. fixed get request back to patch

* removed unused glamor

* pulled gemfile from feature

* removed old tests that were cancelled. fixed typo

* added dryness to seed data, and fixed rubocop warnings.

* fixed method name

* disable_permission helper method added

* added enable permission helper method

* linting fix. removed lingering unused tests

* fixed reek issues, moved several methods to private

* moved other seed helper methods into private

* removed unused variable i

* experimental schema fix

* fixed failing test

* fixed bug so that props is now used as fallback

* fixed bug for finding org users

* removed permission because constants file was reverted

* removed old constants file reworks now that they're reworked

* bugfix for admin checked value, improved linting

* removed stray comment

---------

Co-authored-by: Ryan Marshall <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: Robert Travis Pierce <[email protected]>
Co-authored-by: = <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: Isaiah Saucedo <[email protected]>
Co-authored-by: Calvin <[email protected]>
Co-authored-by: youfoundmanesh <[email protected]>
Co-authored-by: Craig Reese <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: sbashamoni <[email protected]>
Co-authored-by: davis-dwayne <[email protected]>
Co-authored-by: IsaiahBar <[email protected]>
Co-authored-by: IsaiahBar <[email protected]>
Co-authored-by: cacevesva <[email protected]>
Co-authored-by: Rnmarshall93 <[email protected]>
…21558)

* updated styling for correspondence cases and tasks related/not to appeals

* fixed linting issue

* updated class styling to be an array to match props

* updated css in intake, add appeal view, and add evidence submission view

* added missing div

* moved css for add task view, add appeal tasks view, and unrelated tasks view

* updated existing appeal tasks view

* Modified the scss file with defined variable

* Modified the scss file with defined variable for other colors

* adjusted button padding

---------

Co-authored-by: divyadasari-va <[email protected]>
* seedcreating superusers

* changing superuser definitions

* auto assign seed work

* updating superuser test factory for spec tests

* fixing tests

* fixing linting and DB column conflicts

* verifying inbound ops superusers have the new superuser permission

* updating fixing the seed file
* updated mail_supervisor? to inbound_ops_team_supervisor?

* added admin check for inbound ops team supervisor permission

* updated isMailSupervisor namespace to isInboundOpsSupervisor

* updated userIsCorrespondenceSupervisor to userIsInboundOpsSupervisor

* added inbound_ops_team_supervisor and added to correspondence cases spec.

* fixed some tests, left binding pry to mark where it starts failing again

* fixed failing tests

* fixed all failing tests

* fixed failing va dor field failure

* fixed search bar spec

* fixed more failing tests

* fixed failing specs

* fixed failing tests

* fixed failing tests

* fixed failing tests

* fixed failures that emerged with fixes

* potentially fixed several rspecs

* resolved failing test

* fixed autotext modal test

* fixed more failing tests

* fixed failing controller tests by changing where user is treated as supervisor

* fixed failing test

* fixed failing test

* fixed timeout on test

* several linting fixes

* additional linting fixes

* linting fix

* linting fixes

* linting fix for spacing

* css and linting fix

* fixed failing rspec

* maybe fixed failing prs on knapsack

* attempted intake_spec fix

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
* added component. component renders permissions.

* added userPermissions to OrganizationPermissions

* updated changes

* unstuck sticky checkboxes

* added additional fix for checkboxes

* added prop to OrganizationPermissions. Added db reading for checkbox values.

* set up organization permission checkboxes to appear in correct order

* fixed checkbox state.

* added checkboxes children  handling

* removed console log

* fixed checkboxes rendering when super user permission was enabled by admin

* removed leftover code in OrganizationUsers, resolved linting errors.

* added clarifying comment

* removed unused code

* added conditional check for org permissions to display checkboxes

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
* Removes unnecessary columns from correspondences table

* Updated the datatype bigint

* Commit for spec failuers

* Lint fixes and some spec fixes

* Revert the changes for correspondence_task_helpers.rb

* Updated back with previous changes

* Revert the changes for client/app/queue/correspondence/intake/components/ReturnToQueueModal.jsx

* Updated the PG::ForeignKeyViolation: ERROR for package_document_types

---------

Co-authored-by: HunJerBAH <[email protected]>
* added component. component renders permissions.

* added userPermissions to OrganizationPermissions

* updated changes

* unstuck sticky checkboxes

* added additional fix for checkboxes

* added prop to OrganizationPermissions. Added db reading for checkbox values.

* set up organization permission checkboxes to appear in correct order

* fixed checkbox state.

* added checkboxes children  handling

* removed console log

* fixed checkboxes rendering when super user permission was enabled by admin

* removed leftover code in OrganizationUsers, resolved linting errors.

* added clarifying comment

* updated seed data to include default_for_admin on superuser

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
Fix for merge conflict
* Moved the 3 checks to public method initial commit

* Modified the code as per the suggestions

* Lint fixes

* Updated the spec fixes
* fixed css causing searchbar errors

* removed dead css attributes

* improved edge matching on searchbar width
* Inital commit for Remove of MAX_QUEUED_ITEMS

* Modified current_user

* added auto assign permission check to process_tasks_if_applicable

* Banner modifications for unassignable_reason in auto_assignable_user_finder.rb file

* fixed duplicate warnings

* bug fix for user permission checker

* updated NOD error message to reflect ACs

* removed redundant permission check

* updated the error message for bulk capacity failure.

* Updated sensitivity error message

* Updated the spec file issues

* fixed failing tests

* Nod permission check spec

* changed query type

---------

Co-authored-by: divyadasari-va <[email protected]>
* new branch for inbound_ops_team_user changes

* more changes

* changes for database

* updated changes for InboundOpsTeam

* update inbound name

* update name

* update spec test

* remove comma

* namespace validation

* fixed plurality

* change namespace for correspondence verification

* fix plurality changes

* remove brackets

* fixing spec test

* update naming

* update spec tests... again :)

* update affilaited

* updated correspondence access check to handle if no user is present, and removed old checks that are not needed

* excluded admins from inbound ops team user check

* added comment for validation check

* added check for system users and allow system users to create correspondence tasks

* updated seeds and correspondence validation to check current session user

* fixed linting issues

* updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation.

* reverted mail team change from inbound ops

* added saftey operator to system user check

* removed factory changes and added validations to correspondence create_from_params methods

* moved created methods to self and updated failing test

* fixed failing tests

* fixed failing correspondence tests

* fixed failing tests by adding test user back into MailTeam org

* fixed failing test in review package spec by adding back in MailTeam or  assignment

* updated failing tests and linting issues in tests

* fix linting issues in organization users scss

* pshing up linting fixes for correspondence.scss

* finish lint clean up

* fixed test failures

* resolved linting issues in stylesheet

* resolved failing test in intake spec

* resolved failing test

* fixed permission check to check current user

* fixed styling issue with pagination buttons

* removed Jolly Postman from seed data

* upped wait time.

* updated verify_correspondence_access to accept a user param

* fixed linting issues in _correspondence.scss

* fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet

* fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473)

* APPEALS-41707 - Functionality and some CSS

* APPEALS-41707 - Updates

* APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes

* APPEALS-41707 - Additional Linting

* APPEALS-41707 - More Clean up

* APPEALS-42281 - displaying NOD of correspondence in review package page (#21528)

* APPEALS-42281 - displaying NOD of correspondence in review package page

* fixing package document type alignment

* Khalin/appeals 41705 (#21450)

* WIP

* VA DOR update

* VA DOR date text area working as intended

* Functionality working as intended

* Styling

* CPM info removed

* Fixed some failing tests

* WIP

* VA DOR Read Only Styling

* Edit CMP Test Passing

* Fix Jest Job Test

* Jest test fix WIP

* Jest test fix WIP #2

* ReviewForm.test.js Provider Store Update

* Styling

* style

* styling

* remove unused

---------

Co-authored-by: vinner57 <[email protected]>
Co-authored-by: KiMauVA <[email protected]>

* Package document type styling (#21546)

* bug fix for NOD update (#21544)

* bug fix for NOPD update

* APPEALS-42281-bug-fix  - fix to update the nod on selection of correspondence document

* Add data for VA 10182 (#21553)

* Review Package General Info Section Spacing Change (#21559)

* Review Package text spacing (#21560)

* Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571)

* APPEALS-45367 - Fixed Linting. Fixed unnecessary delete

* Rspec fixes

* update package document type NOD/NON-NOD (#21584)

* update NOD

* fix rubocop issues

* Khalin/appeals 45567 Request Package Action Modals Updated (#21590)

* Functionally complete

* Jest test fix

* Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572)

* 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed

* Fix faling tests wip

* Fixed test

* Update correspondence_intake_processor.rb

* Update tasks.js

---------

Co-authored-by: cacevesva <[email protected]>

* Mail Task Position Correction (#21597)

* added changes to display intake appeal button based on NOD NON-NOD (#21618)

* added changes to display intake appeal button based on NOD NON-NOD

* updated to display intake appeal button after editing the document type

* fixing lint issues

* Update correspondence_review_package_controller.rb

Updated syntax instead of each to find_each

---------

Co-authored-by: cacevesva <[email protected]>

* Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619)

* Bug Fixed NOD/Non-NOD Functioning Correctly

* Triggering test

---------

Co-authored-by: cacevesva <[email protected]>

* Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664)

* NOD/Non-NOD status Fix

* Kicking off tests

* Kicing off tests

* Caceves/appeals 46003 (#21661)

* Add inbound ops super user & adjust inbound ops normal user, disable  VA DOR logic for super user

* Add automatic seeding of inbound ops team super user

* fix for continue button on select of yes no (#21721)

* Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763)

* #44110 - moved all ReceiptDatePicker styles to correspondence scss file

* #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file

* #44110 - moved all AddLetter styles to correspondence scss file

* #44110 - moved all NewLetter styles to correspondence scss file

* #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file

* Khalin/appeals 45867 (#21703)

* WIP

* Reverting changes

* Save Changes Bug Fixed

* Return To Queue button working as intended

* Prevents save action in case of errorMessage

* WIP

* WIP

* Working as intended

* Removing comments

* fixing tests

* fixing lint error

---------

Co-authored-by: vinner57 <[email protected]>

* Sivakesh/appeals 44110 (#21775)

* #44110 - moved all ReceiptDatePicker styles to correspondence scss file

* #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file

* #44110 - moved all AddLetter styles to correspondence scss file

* #44110 - moved all NewLetter styles to correspondence scss file

* #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file

* #44110 - lint errors

* Remove old seed data (#21780)

---------

Co-authored-by: Ki Mau <[email protected]>
Co-authored-by: vinner57 <[email protected]>
Co-authored-by: Dev-KRedd <[email protected]>
Co-authored-by: psivakeshva <[email protected]>
* added previous work to new branch

* removed magic strings
divyadasari-va and others added 15 commits September 19, 2024 12:27
* Initial commit- Added the Add letter button and reusing the newletter componet

* Added  submit logic

* Able to add response letter

* Modified the updated function

* Modified the updated redux function

* Updated the redux store with values

* Modified the code according to DRY

* Lint fixes

* Added feature test specs

* Updating the feature tests for this feature

* Lint fixes

* Removed the line that is twice added

* Modified the routes file
* #APPEALS-42568 - Saving Related correspondences to database

* #APPEALS-42568 - added inbound ops check

* #APPEALS-42568 - fixed sorting issue

* #APPEALS-42568 - removed tab change functionality

* #APPEALS-42568 - removed tab change functionality

* #APPEALS-42568 - removed redundant action

* #APPEALS-42568 - Jest Tests

* #APPEALS-42568 - rspecs

* #APPEALS-42568 - lint

* #APPEALS-42568 - fixed failing rspecs
* creating correspondences and the tasks for the spec tests

* adding in other task data for Ryan's work

* changing to 3 correspondence with each task type

* working on writing tests, and still working on the test data

* adding in changes for verifying the routes for the other four tests

* attempting to fix the data creation duplication issue

* Update data setup and added remaining test cases

* Use regex for label text matching

* changing the expect to make sure every page shows up regardless of what other tasks are present

* editing the expect to hopefully fix if there is a finnicky test

* adding regex in case of weird newline edge cases for more accurate matching, and separated test cases

* removing extraneous code and comments

* fixing jest and lint errors unrelated to my work

* missed a semicolon

---------

Co-authored-by: Kevin Ma <[email protected]>
Co-authored-by: cacevesva <[email protected]>
…als: Can link additional appeals (#22872)

* conflicts resolved

* Adding the spec for save correspondence appeals

* conflicts resolved

* conflicts resolved

* #APPEALS-42568 - Saving Related correspondences to database

* conflicts resolved

* #APPEALS-42568 - removed redundant action

* conflicts resolved

* #APPEALS-42568 - rspecs

* #APPEALS-42568 - lint

* #APPEALS-42568 - fixed failing rspecs

* conflicts resolved

* fix failing specs

* lint fix

* fixing the select order of checkboxes

* fix lint errors

* fix lint and rubocop

---------

Co-authored-by: Razor Talent <[email protected]>
Co-authored-by: psivakeshva <[email protected]>
* Working but the checkboxes ceep shifting around

* Front-end changes working as intended & started backend functionality

* Handle save button WIP

* route info update

* Functionality working as intended

* Removing flash banner on update

* small fixes

* Tests WIP

* Working test and code clean up

* More complete test

* Working with latest changes in feature.

* code climate fixes

* current_user is needed sor the update to save

* Fixing linting errors
* Added datepicker feature date restriction

* trying to fix the flakey test

* trying to fix the flakey test by adding wait time for the button

* Modified spec changes to resolve the flakey test fix

* Modified spec changes to resolve the flakey test fix

---------

Co-authored-by: cacevesva <[email protected]>
#22938)

* fixing the checkbox sorting issue

* remove duplicate spec

* fixing the jest cases

* fixing the unchecked issue

* show success banner
* Initial commit for Navigation Updates for Existing Appeals

* Lint fixes

* Lint fixes for styles

* Trying to fix the flakey test spec

* Trying to fix the flakey test spec

* Trying to fix the flakey test spec for response letter

* Trying to fix the flakey test spec for response letter

* Trying to fix the flakey test spec for response letter

* Trying to fix the flakey test spec for response letter

* Fixing the flakey test spec that is failing

* lint fixes

* Trying to fix the flakey test for response letters spec

* Added skip to one of the test spec

* Lint fixes
* Added a quick for expanded and collapsed section

* Added jest file modification
* Checkbox sorting is fixed

* Save button fix

---------

Co-authored-by: cacevesva <[email protected]>
@cacevesva cacevesva changed the base branch from feature/APPEALS-13579-v1 to main September 26, 2024 20:37
divyadasari-va and others added 14 commits September 26, 2024 14:14
… Information (#22937)

* filtered related correspondece values

* added new correspondence_details serializer

* created new appeal serializer and updated frontend to handle new values

* added correspondence type to serializer

* fixed bug where appeal id was not matching with previously linked appeals

* fixed failing test

* fixed failing tests
* #APPEALS-58115 - added collapsible header

* #APPEALS-58115 - updated box border color

* #APPEALS-58115 - added a jest test to verify there is plus button

* #APPEALS-58115 - added a jest test to verify there is plus button

* #APPEALS-58115 - fixed a failing a jest test

* #APPEALS-58115 - fixed a failing a spec
* WIP all styles have been moved

* Fixing linting warnings

* Aria-label added

* Kicking off tests

---------

Co-authored-by: cacevesva <[email protected]>
* mostly fixed

* fixed css issues on grey timeline.

* fixed missing key issue

* fixed labels and data shape.

* Fixed staged data to use real data.

* removed redundant prop

* Fixed task action dropdown

* fixed linting issue

* Kev ma/appeals 55015 (#22764)

* Typo fix

* Added safe navigation operator

* Remove permissions from ruby view props

* Update component to save value to state instead of from props

* rename hash key

* updated var ref to state

* Update for code spacing

* Bugfix for sticky checkbox logic

* Div/appeals 57463 (#22779)

* Added missing columns in the serializer prepareAppealForSearchStore function

* Removed console log

* Removed unused imports

---------

Co-authored-by: cacevesva <[email protected]>

* added polymorphic association to correspondence task Correspondence relation

* fixed null task issue

* updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence.

* setup way to load appeals into the Queue redux store to display task actions

* created logic to load serialized tasks into store (but they overwrite each other)

* created logic to add appeal tasks to the redux store.

* added TaskSnapshot to display appeal task actions

* pushed up fix that resolved routing crashes from correspondence

* removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements.

* Refactored component to use different name.

* fixed 6 failing tests

* fixed several failing tests.

* changed shape of mocked data in details test

* adding more data to staged props in test

* fixed task display for tasks added when empty

* reverted jest test files from their extreme size.

* added back in correspondenceAppeal map

* removed console log

* fixed dead import.

* fixed failing tests from div wrappers hiding task actions

* updated tests to be less flaky

---------

Co-authored-by: Kevma50287 <[email protected]>
Co-authored-by: divyadasari-va <[email protected]>
Co-authored-by: cacevesva <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
… Edit Information (#22944)

* APPEALS-42563 - Working Modal, minus Save patch request

* APPEALS-42563 - Fixed Modal, missing ApiSave

* APPEALS-42563 - ApiUtil fix

* APPEALS-42563

* Test Updates

* Remove loadCorrespondence

* Removed unused correspondenceInfo action; linting

---------

Co-authored-by: cacevesva <[email protected]>
Co-authored-by: HunJerBAH <[email protected]>
* unlinked checkboxes now sort by vaDateOfReceipt

* Post method added

---------

Co-authored-by: cacevesva <[email protected]>
* Fixed the duplication of correspondence appeals adding to the database

* Removed puts

* fixing the jest fails

* fixing the jest fails

* Trying to fix the lint issues

---------

Co-authored-by: cacevesva <[email protected]>
* Provided the instructional text

* Jest fixes

* Adjusted the paragraph text

---------

Co-authored-by: cacevesva <[email protected]>
* bug fixes

* fix rspec

* fix rspec

---------

Co-authored-by: cacevesva <[email protected]>
…ng an appeal (#23045)

* fix to the sorting issue

* resolving bugs

* resolved conflicts with branch changes and feature changes

* added state refresh logic to CaseListTable

---------

Co-authored-by: HunJerBAH <[email protected]>
Co-authored-by: cacevesva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.