Feature/appeals 34965 #22154

* draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* ccc * gggg * gggg

* working checkboxes and permissions area * latest changes for sharing * changing css styling and moving stuff over to .scss file * added state tracking for nod checkbox * Added superuser checkbox functionality * moving scss to dedicated file * changing padding to add with checkbox padding for total of 30px * removing console logs and adding back top border * permissions now come through props * updated to dynamically render checkboxes * generating nod checkbox if parent exists * Adding column default_for_admin on organization_permissions * reducing payload for organizationPermissions * Fixing checkboxes to behave when different boxes are checked * Proptypes addition for linting * creating route for patch * WIP user permissions * Getting started on spec writing. Not working yet! * reverted organization_permissions to hopefully avoid everyone running a make reset for this data. * reworked the remove and add permissions patch method. * added a little documentation to OrganizationUserPermissionChecker * Moving to correct spec, and working on other ways of writing the test to get it to pass * checkboxes now read state off the backend * checkboxes partially working * fixed state bug * implemented superuser checkbox and disabling of it. * schema change and re-adding default admin column * created basic feature tests for inbound ops team management * continuing working on the controller spec * moved user permission/admin check to user model * house keeping * added conditional for admin permission checkbox rendering. * working superuser checkbox restriction * fixed checkbox default value bug * refactored permission shape * removed old methods * checkboxes fixed (I think) * set up admin check to return bool instead of obj * refactored organization permissions and updated test factories to stage permissions * working seed data * removed binding prys * fixed checkbox logic. needs suggestion changes though * created feature test for inbound ops team * changed list to div * fixed several parts of code based on feedback * added conditional rendering * refactored glamor style into javascript object for checkbox * fixed schema * reverted org permissions json file to its intended design * reverted valid_permission_names back to its intended state. * fixed seed data * linting fix * mostly refactored * included new frontend data (not wired) * data population refactor finished * fixed color * Added a customizable per page task limitation attribute to QueueTab that is used by task_pager to allow an adjustable maximum number of tasks per tab. (#21594) Co-authored-by: = <[email protected]> * fixed lingering css * APPEALS-42958: Consolidated Superuser Permissions Check (#21454) * consolidated backend checks to use inbound_ops_team_superuser over mail_superuser * updated superuser namespace in the frontend * APPEALS-44391: Intake Correspondence Rerouting (#21447) * cleaned up magic string usage * updated cancel routing for superusers * fixed linting issues * added rerouting for users that cannot access a specific intake * updated Review Package task to be the same user that was assigned the Intake * resolved linting issues * updated inbound ops team superuser check * refactored intake controller test * refactored reassign package task specs and reassignment on cancel * refactored task specs to be more DRY * added intake task fix to intake_form_spec * cleaned up test failures related to intake task within intake. * refactored related correspondence spec tests * updated test to click correct section * updated failing snapshots * fixed typo on prop validations * added prop to hide dropdown if review package has an efolder failed task (#21497) * APPEALS-44390: Soft Delete Correspondence Intake (#21508) * added migrations to refactor correspondence intake relationship to task instead of user/correspondence * updated model relations and controller check for an open intake * updated specs to reflect code changes. * removed leftover pry * APPEALS-43421: Attorney Selection Sticking on Dropdown after Assignment (#21401) * redo init commit * updated imp. logic * attorney widget fix --------- Co-authored-by: Calvin <[email protected]> * Add ruby CE API Gem * remove correspondence changes from schema.rb (#21468) * Revert "Add ruby CE API Gem" (#21479) This reverts commit c78afe3. * Override SCT Bulk Assign Page task limit (#21465) * Override SCT Bulk Assign Queue 15 case limit & Adjust SCT attorney assign task action label * feature/APPEALS-35707-29633-29632 (prodtest) (#21485) * 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record` * 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances * 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash * feature/APPEALS-44871 Steps for installing node in the Caseflow demo environment (#21483) (#21484) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Revert "feature/APPEALS-44871 Steps for installing node in the Caseflow demo …" (#21489) This reverts commit a626200. * Sbashamoni/appeals 44871 node14 demo fixes (#21490) (#21495) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Removed unused node env * add error rules to demo builds (#21496) (#21498) Co-authored-by: davis-dwayne <[email protected]> * added back in schema changes removed from master * draft pr (#21509) * draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * draft pr * searchable by 2 characters instead of 1 * added ability for user to search by css id * reverted changes in package.json * removed added file * fixed params.permit issue * removed organization made with includes * reverted gemfile to master branch version * Fixed linting. fixed get request back to patch * removed unused glamor * pulled gemfile from feature * removed old tests that were cancelled. fixed typo * added dryness to seed data, and fixed rubocop warnings. * fixed method name * disable_permission helper method added * added enable permission helper method * linting fix. removed lingering unused tests * fixed reek issues, moved several methods to private * moved other seed helper methods into private * removed unused variable i * experimental schema fix * fixed failing test * fixed bug so that props is now used as fallback * fixed bug for finding org users * removed permission because constants file was reverted * removed old constants file reworks now that they're reworked * bugfix for admin checked value, improved linting * removed stray comment --------- Co-authored-by: Ryan Marshall <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: Robert Travis Pierce <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: youfoundmanesh <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Jeremy Croteau <[email protected]> Co-authored-by: sbashamoni <[email protected]> Co-authored-by: davis-dwayne <[email protected]> Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]>

…21558) * updated styling for correspondence cases and tasks related/not to appeals * fixed linting issue * updated class styling to be an array to match props * updated css in intake, add appeal view, and add evidence submission view * added missing div * moved css for add task view, add appeal tasks view, and unrelated tasks view * updated existing appeal tasks view * Modified the scss file with defined variable * Modified the scss file with defined variable for other colors * adjusted button padding --------- Co-authored-by: divyadasari-va <[email protected]>

* seedcreating superusers * changing superuser definitions * auto assign seed work * updating superuser test factory for spec tests * fixing tests * fixing linting and DB column conflicts * verifying inbound ops superusers have the new superuser permission * updating fixing the seed file

* updated mail_supervisor? to inbound_ops_team_supervisor? * added admin check for inbound ops team supervisor permission * updated isMailSupervisor namespace to isInboundOpsSupervisor * updated userIsCorrespondenceSupervisor to userIsInboundOpsSupervisor * added inbound_ops_team_supervisor and added to correspondence cases spec. * fixed some tests, left binding pry to mark where it starts failing again * fixed failing tests * fixed all failing tests * fixed failing va dor field failure * fixed search bar spec * fixed more failing tests * fixed failing specs * fixed failing tests * fixed failing tests * fixed failing tests * fixed failures that emerged with fixes * potentially fixed several rspecs * resolved failing test * fixed autotext modal test * fixed more failing tests * fixed failing controller tests by changing where user is treated as supervisor * fixed failing test * fixed failing test * fixed timeout on test * several linting fixes * additional linting fixes * linting fix * linting fixes * linting fix for spacing * css and linting fix * fixed failing rspec * maybe fixed failing prs on knapsack * attempted intake_spec fix --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* added component. component renders permissions. * added userPermissions to OrganizationPermissions * updated changes * unstuck sticky checkboxes * added additional fix for checkboxes * added prop to OrganizationPermissions. Added db reading for checkbox values. * set up organization permission checkboxes to appear in correct order * fixed checkbox state. * added checkboxes children handling * removed console log * fixed checkboxes rendering when super user permission was enabled by admin * removed leftover code in OrganizationUsers, resolved linting errors. * added clarifying comment * removed unused code * added conditional check for org permissions to display checkboxes --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Removes unnecessary columns from correspondences table * Updated the datatype bigint * Commit for spec failuers * Lint fixes and some spec fixes * Revert the changes for correspondence_task_helpers.rb * Updated back with previous changes * Revert the changes for client/app/queue/correspondence/intake/components/ReturnToQueueModal.jsx * Updated the PG::ForeignKeyViolation: ERROR for package_document_types --------- Co-authored-by: HunJerBAH <[email protected]>

* added component. component renders permissions. * added userPermissions to OrganizationPermissions * updated changes * unstuck sticky checkboxes * added additional fix for checkboxes * added prop to OrganizationPermissions. Added db reading for checkbox values. * set up organization permission checkboxes to appear in correct order * fixed checkbox state. * added checkboxes children handling * removed console log * fixed checkboxes rendering when super user permission was enabled by admin * removed leftover code in OrganizationUsers, resolved linting errors. * added clarifying comment * updated seed data to include default_for_admin on superuser --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

Fix for merge conflict

* Moved the 3 checks to public method initial commit * Modified the code as per the suggestions * Lint fixes * Updated the spec fixes

* fixed css causing searchbar errors * removed dead css attributes * improved edge matching on searchbar width

Co-authored-by: HunJerBAH <[email protected]>

* Inital commit for Remove of MAX_QUEUED_ITEMS * Modified current_user * added auto assign permission check to process_tasks_if_applicable * Banner modifications for unassignable_reason in auto_assignable_user_finder.rb file * fixed duplicate warnings * bug fix for user permission checker * updated NOD error message to reflect ACs * removed redundant permission check * updated the error message for bulk capacity failure. * Updated sensitivity error message * Updated the spec file issues * fixed failing tests * Nod permission check spec * changed query type --------- Co-authored-by: divyadasari-va <[email protected]>

* new branch for inbound_ops_team_user changes * more changes * changes for database * updated changes for InboundOpsTeam * update inbound name * update name * update spec test * remove comma * namespace validation * fixed plurality * change namespace for correspondence verification * fix plurality changes * remove brackets * fixing spec test * update naming * update spec tests... again :) * update affilaited * updated correspondence access check to handle if no user is present, and removed old checks that are not needed * excluded admins from inbound ops team user check * added comment for validation check * added check for system users and allow system users to create correspondence tasks * updated seeds and correspondence validation to check current session user * fixed linting issues * updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation. * reverted mail team change from inbound ops * added saftey operator to system user check * removed factory changes and added validations to correspondence create_from_params methods * moved created methods to self and updated failing test * fixed failing tests * fixed failing correspondence tests * fixed failing tests by adding test user back into MailTeam org * fixed failing test in review package spec by adding back in MailTeam or assignment * updated failing tests and linting issues in tests * fix linting issues in organization users scss * pshing up linting fixes for correspondence.scss * finish lint clean up * fixed test failures * resolved linting issues in stylesheet * resolved failing test in intake spec * resolved failing test * fixed permission check to check current user * fixed styling issue with pagination buttons * removed Jolly Postman from seed data * upped wait time. * updated verify_correspondence_access to accept a user param * fixed linting issues in _correspondence.scss * fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet * fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473) * APPEALS-41707 - Functionality and some CSS * APPEALS-41707 - Updates * APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes * APPEALS-41707 - Additional Linting * APPEALS-41707 - More Clean up * APPEALS-42281 - displaying NOD of correspondence in review package page (#21528) * APPEALS-42281 - displaying NOD of correspondence in review package page * fixing package document type alignment * Khalin/appeals 41705 (#21450) * WIP * VA DOR update * VA DOR date text area working as intended * Functionality working as intended * Styling * CPM info removed * Fixed some failing tests * WIP * VA DOR Read Only Styling * Edit CMP Test Passing * Fix Jest Job Test * Jest test fix WIP * Jest test fix WIP #2 * ReviewForm.test.js Provider Store Update * Styling * style * styling * remove unused --------- Co-authored-by: vinner57 <[email protected]> Co-authored-by: KiMauVA <[email protected]> * Package document type styling (#21546) * bug fix for NOD update (#21544) * bug fix for NOPD update * APPEALS-42281-bug-fix - fix to update the nod on selection of correspondence document * Add data for VA 10182 (#21553) * Review Package General Info Section Spacing Change (#21559) * Review Package text spacing (#21560) * Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571) * APPEALS-45367 - Fixed Linting. Fixed unnecessary delete * Rspec fixes * update package document type NOD/NON-NOD (#21584) * update NOD * fix rubocop issues * Khalin/appeals 45567 Request Package Action Modals Updated (#21590) * Functionally complete * Jest test fix * Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572) * 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed * Fix faling tests wip * Fixed test * Update correspondence_intake_processor.rb * Update tasks.js --------- Co-authored-by: cacevesva <[email protected]> * Mail Task Position Correction (#21597) * added changes to display intake appeal button based on NOD NON-NOD (#21618) * added changes to display intake appeal button based on NOD NON-NOD * updated to display intake appeal button after editing the document type * fixing lint issues * Update correspondence_review_package_controller.rb Updated syntax instead of each to find_each --------- Co-authored-by: cacevesva <[email protected]> * Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619) * Bug Fixed NOD/Non-NOD Functioning Correctly * Triggering test --------- Co-authored-by: cacevesva <[email protected]> * Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664) * NOD/Non-NOD status Fix * Kicking off tests * Kicing off tests * Caceves/appeals 46003 (#21661) * Add inbound ops super user & adjust inbound ops normal user, disable VA DOR logic for super user * Add automatic seeding of inbound ops team super user * fix for continue button on select of yes no (#21721) * Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * Khalin/appeals 45867 (#21703) * WIP * Reverting changes * Save Changes Bug Fixed * Return To Queue button working as intended * Prevents save action in case of errorMessage * WIP * WIP * Working as intended * Removing comments * fixing tests * fixing lint error --------- Co-authored-by: vinner57 <[email protected]> * Sivakesh/appeals 44110 (#21775) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * #44110 - lint errors * Remove old seed data (#21780) --------- Co-authored-by: Ki Mau <[email protected]> Co-authored-by: vinner57 <[email protected]> Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: psivakeshva <[email protected]>

…correspondence_nod

* added previous work to new branch * removed magic strings

…djustment (#21797) * fix team management verbiage * fix verbiage spec test

…ondences.rb (#21805) * refactored seed data to prevent bug where a user wasn't available. * moved auto assign logic higher up and updated superuser selection

…0 success message. (#21820)

* Created new file for correspondence and modified some changes from correspondence_auto_assign to user * Shifted the auto_assign_permissions method to users.rb file * Nod Permissions method is shifted to users * Modified the create! method with find_or_create_by * Fix for inbound_ops_team_superuser check * Moved correspondence_types and package_document_types into new seed file * Move code from queue_correspondence to new seed * Added a document type for every correspondence * Removed all the related correspondences seed files * Deleted the merged files again * Modified the rake tasks file and renamed the file to correspondence * Modified the appeals creation for veteran from 10 to 15 * Updated the spec files with seed class * Users sepec count update

…down (#21826) * draft pr * DELETE COMMENT * satisfy line length * pushing up changes for "Create Record" button * refactored correspondence button check in review package workflow * removed useEffect that was causing the button to become enabled when it shouldn't * disable create record button if there is no correspondence type on the correspondence --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Renamed the vbms types file * Renamed the vbms types file old file

* Removed aria-label for link in veteran details * Modified the spec file of aria-label --------- Co-authored-by: HunJerBAH <[email protected]>

* remove redundant find_by's * removed comma * removed commas --------- Co-authored-by: HunJerBAH <[email protected]>

* Caceves/appeals 41709 v5 (#21878) * APPEALS-41709 - Uncorrupted Branch; First commit - Remove Columns from Correspondences * APPEALS-41709 - Drop package_document_types Table * Update remove * Updating Serializer for Correspondence * Removing portal_entry_date * Removing source_type * Removing cmp_packet_number * Removing cmp_queue_id * Removing package_document_type_id * package_document_type * Fix merge issues with table * Update Migration inheritance * Remove package_document_type from correspondence model * WIP working on safely removing old package document type * Restore queue_column * Restore correspondence_queue_column.rb * Restore client test correspondence.js * More package doc type removals * Remove unused package document type * Remove package document type and fix closing end statement * Remove package document type from spec * Fix 2 linter issues * Update queue_helpers to not use package_doc_type * Adjust docket_number & docket_name because was getting an error on the explain page * Fixed lint issue --------- Co-authored-by: KiMauVA <[email protected]> * Update migration to have safety assured * Siva-Khalin/Appeals 43239 (#21811) * Setting up skeleton for future ACs * #43239 - AC 2 * #43239 - create new route and verify access is added * #43239 - #AC2 added link to queue tab * AC1 WIP * Updating access_allowed method * WIP * #43239 - #AC4 added new correspondence_admin feature toggle * AC1 Done * #43239 - added AC5.1 and AC5.2 * #43239 - moved text to constants * AC 5 WIP * #43239 - added number field and submit button * #43239 - limiting veteran file numbers to 10 * AC 5 continued WIP * #43239 - CSS Updates * #43239 - AC 5.6.2 and AC 5.6.4 * file_number check method * invalid_file_num_error_message ruby Method * #43239 - correspondence controller specs * #43239 - removed unused code * Routes WIP * Get Correspondence Test Route Working * #43239 - generate correspondence route * #43239 - Added FE changes for success response * #43239 - removed correspondence size in the api response * Fix various minor rubocop offenses * WIP generate_correspondence * #47513 - Test Correspondence Jest Tests * #47518 - Generate Correspondence updates * #47518 #47512 - specs for BE methods * #43239 - lint * #41709 - removed columns * removed unused code * lint * lint fixes * revert Gemfile.lock --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Alexander Smith <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: psivakeshva <[email protected]> --------- Co-authored-by: KiMauVA <[email protected]> Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Alexander Smith <[email protected]> Co-authored-by: psivakeshva <[email protected]>

* Removing requirement for correspondence_type_id to be assigned * removing correspondence_type_id from being built in seeds files in queue_helpers

Co-authored-by: HunJerBAH <[email protected]>

…oller (#21940)

* comment for source change to register * refactored appeals_controller to use params safely. regression test clean. * untested correspondence_controller params change. * refactored correspondence_document_controller. regression tested. * refactored unsafe params. regression tested. * removed shared params inside concern (bad practice) * refactored param safety. regression tested. * refactored unsafe code. manually tested * refactored params to be secure. regression tested. * broke params into multiple lines * refactored missing params into secure ones. regression tested again. * refactored potential incorrect param * minor param refactor. * removed binding.pry and updated params.permit. regression tested again. * fixed param issue * updated params.permit * fixed params issue * another param fix * second attempted fix * might have actually fixed it * another fix attempt * fixed linting issues * removed unused default params * fixed rubocop complains with helper methods * changed helper methods to be a constant * moved pdf_params into separate method in correspondence_review_package_controller --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* #44296 - Updated labels * #44296 - Updated specs * #44296 - Updated labels to sync with every other label in file

* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * Spec fixes for single and multiple batch assignment * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * made changes to grammar and updated unit tests to match * refactored banner logic to let auto user finder be the source of truth for assignment errors * refactored logger to log the most recent unassignable reason from the auto assign user finder. * fixed linting errors --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

…kage modal on Review Package form (#21964) * initial commit * added .match.params to handle history props in QueueApp routing * displaying banners for the correspondence review package actions * Removing debugger * removing the comment --------- Co-authored-by: HunJerBAH <[email protected]>

* Passing rspec tests * correspondence_review_package_controller_spec.rb fix * Fixing checkbox test spec

* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * updating failed assignment header texts * Spec fixes for single and multiple batch assignment * updating failed assignment reason errors * updating tests to pass with new messages * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * Changing the banner text method name to match incoming changes from feature * adding build method for single error message * fixing a mistake in my switch case code * Fixing up some reasons for single errors * correcting capacity error wording from multiple assignments ticket * adding "to user" text and matching messages across single and multiple assignment errors * Updating comments and spacing for code readability * Reverting to feature from tests because of wacky failures * updating mail team user to inbound ops team user in test descriptions * updating single assignment and batch assignment tests to match new labels * removing deprecated methods * fixed linting errors --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: Ryan Marshall <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

#21939) * APPEALS-48218 - edit_cmp_information_rspec Updates * #48582 - Corrected test data and added initial states * APPEALS-48218 - CodeClimate Updates * APPEALS-48218 - CodeClimate Updates * Lint * Linting * CC Updates --------- Co-authored-by: psivakeshva <[email protected]>

…or does not show (#22029) * fixing an accidental bug where a bullet point containing a single error does not show * updating name

* CodeClimate TL Approved Comments * CodeClimate Updates 2 * Reek Update * Reek 2

…ment Type (#22019) * update nod * update nod * push up changes for nod * update parameters for create_correspondence_document * remove method --------- Co-authored-by: HunJerBAH <[email protected]>

* fix for the save changes button * fixing jest and rspecs * fix rspec

…was removed when merging master

…eview (#22066) * created testCommits git command * updated git-test-commits namespace and reorged file to run ruby tests then js tests * added clean push command * added clean test and user input to script * updated namespace of clean-pr and refactored to allow the use of a branch parameter * test commit * reverted test commit change * refactored git commit and reverted test code change in correspondence.rb * added formatting, fasterer, scss-lint, lint, and prettier tests * added scss commit changes * added safe auto correct option to clean-pr command

…espondence (#22092)

…Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation

* #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

This reverts commit 20a6a09.

* Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]>

…rs are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]>

…rs are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* Save Button Is Not Enabled When VA DOR Date Is Updated (#22049) * fix for the save changes button * fixing jest and rspecs * fix rspec * updated parameters in controller to permit batch id (#22084) * Update explain controller appeal_affinity to test if appeal is a correspondence (#22092) * added guard clause to response (#22113) * APPEALS-51209: UAT Test Data Workflow Does Not Create Documents When Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * removed unused task (#22143) * Ki/APPEALS-42516 - Create Details Page Shell (#22122) * Reforged * Reinstante VetCorrespondence * correspondence_details temporary fix * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <[email protected]> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <[email protected]> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * APPEALS-42516 - Controller Updates, Spec and Route details * Remove facols file --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> * Lint fixes (#22134) * Lint fixes * Updated the color variables * Updated the color variables for hsl values * Fix for MergeableSelector for corr class * Fix rubocop offenses * Continue fixing rubocop offenses * Update gemfile lint rubocop offense * MergeableSelector fix for class cf-form-textinput * Fix for the newly added lint issues * Fix for the cf-form-textinput lint issue * Fix for MergeableSelector in team_management.scss --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * Revert "Ki/APPEALS-42516 - Create Details Page Shell (#22122)" This reverts commit 667d590. * Fix flaky lint & specs --------- Co-authored-by: vinner57 <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: KiMauVA <[email protected]> Co-authored-by: IsaiahBar <[email protected]>

* fix code climate issues * fix 4 parameters isseus * fix argument error code climate * fix lint issues * lint fix * fix lint issuues * adding double quotes

* removed all glamor css. * fixed linting.

* APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <[email protected]>

* Completed Tabs link code modifications * Modified the code changes as commented

…22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221)

…OR date (#22227)

…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.

* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.

…22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221)

…OR date (#22227)

…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.

* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.

* overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors

…sks. (#22256) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks.

…22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <[email protected]>

* #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks

* Fix for pdf not loading in review package task * Added a comment line * Rubocp fix * Codeclimite fixes --------- Co-authored-by: cacevesva <[email protected]>

* WIP * Modified few changes for this relations to work * added create logic in intake * cleaned up associations * Associations and up/down migrations working * WIP Failing tests * Fixed spec/lib/helpers/association_wrapper_spec.rb * Rubocop fixes * Updated migration file * Fixing migration error * Rubocop fix * All tests passing --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]>

…ting appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: cacevesva <[email protected]>

* #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * #52600 - 508 compliance code fix * #52600 - 508 compliance code fix --------- Co-authored-by: cacevesva <[email protected]>

…o Admins (#22297) * APPEALS-49005 - Added non_admin function for more limited user list * Unneeded Prop * Update admin check --------- Co-authored-by: cacevesva <[email protected]>

* Removed non valid ce api documents types from uat * Added ce api valid vbms document type ids for uat --------- Co-authored-by: HunJerBAH <[email protected]>

…Correspondence Intake Workflow (#22308) * Kev ma/appeals 51520 seeddata fix (#22307) * Removed non valid ce api documents types from uat * Added ce api valid vbms document type ids for uat --------- Co-authored-by: HunJerBAH <[email protected]> * fixed linting issue * remove guard clause on document types * fixed flaky test --------- Co-authored-by: Kevma50287 <[email protected]>

…an Appeal (#22262) * backend serializer updated, regressions fixed * pushing up correspondence timeline * Fixed import issue. * added correspondence versions of case timeline. fixed some data appearing. * changes to timeline * Fixed the extra line issue * additional changes * additional formatting fix * additional fixes, refined taskrows * task dropdown added * checkpoint for testing * lenting fixes * fff * Fixed organization having the ability to edit tasks. * Removed stray console logs * fixed assigned_to not being displayed. lint fixes. * linting fixes * css improvements * added label method to give correct tasks * fixed show instructions bug * component cleanup * refactored out unused logic * fixed CSS, added missed AC point. * removed binding pry * Correspondence CSS Issues - Using Glamor instead of classnames (#22173) * removed all glamor css. * fixed linting. * add Errno::EISDIR to clear_cache rescue block (#22114) * APPEALS-51230: Add tmp/examples.txt to Github Actions artifacts (#22124) * add examples.txt to gha workflow * rename examples and bullet files even if failure * APPEALS-42516 - CSS Updates (#22191) * APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <[email protected]> * Completed Tabs link code modifications (#22192) * Completed Tabs link code modifications * Modified the code changes as commented * verbiage change (#22217) * APPEALS-51992: Veteran Name Does Not update when file number changed (#22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221) * made edit to review form so that only supervisors could edit the VA DOR date (#22227) * APPEALS-51383: Resolve Bugs with Inbound Ops team Queues on Switch Views Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method. * APPEALS-51552: Test Appeal Organization tables (#22237) * filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues. * Justin/APPEALS-50741 (#22219) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks. (#22256) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks. * Ki/APPEALS-42518 - All users: Can view correspondence record status (#22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <[email protected]> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22254) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * Div/appeals 50296 (#22266) * Fix for pdf not loading in review package task * Added a comment line * Rubocp fix * Codeclimite fixes --------- Co-authored-by: cacevesva <[email protected]> * Removed the Inbound ops Team from rejected_orgs (#22284) * fixed missing comma breaking code * Completed Tabs link code modifications (#22192) * Completed Tabs link code modifications * Modified the code changes as commented * Justin/APPEALS-50741 (#22219) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * Ki/APPEALS-42518 - All users: Can view correspondence record status (#22226) * APPEALS-32518 - Added recordStatus to page pathways * APPEALS-42518 - Updated Correspondence Status pathways, controller * APPEALS-42518 - Remap status to live in correspondence model * Remove unedited file linting changes * Second filechange * APPEALS-42518 - Updated RSpecs * Linting --------- Co-authored-by: cacevesva <[email protected]> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22254) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * removed unused code. fixed jest tests. * changed if to unless * changed styling of attribute for assigned_to * removed whitespace * Khalin/appeals 42564 v3 (#22304) * WIP * Modified few changes for this relations to work * added create logic in intake * cleaned up associations * Associations and up/down migrations working * WIP Failing tests * Fixed spec/lib/helpers/association_wrapper_spec.rb * Rubocop fixes * Updated migration file * Fixing migration error * Rubocop fix * All tests passing --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Vinner57/appeals 42526 Correspondence and Appeal Tasks: Can view existing appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: cacevesva <[email protected]> * Sivakesh/APPEALS-42522 - Completed Mail Tasks (#22303) * #42522 - correspondence mail tasks * #42522 - correspondence mail tasks via serializer * #42522 - Update CSS styling for frontend * #42522 - specs * #42522 - jest tests * #42522 - fixed some lint issues * #42522 - css and AC2 * #42522 - css and AC2 * #42522 - filtered correspondence mail tasks * #52600 - 508 compliance code fix * #52600 - 508 compliance code fix --------- Co-authored-by: cacevesva <[email protected]> * APPEALS-49005 - Bugfix: Reassign Correspondence Allows Reassignment to Admins (#22297) * APPEALS-49005 - Added non_admin function for more limited user list * Unneeded Prop * Update admin check --------- Co-authored-by: cacevesva <[email protected]> * APPEALS-44287: Excluding disposition held and select that appeal for distribution (#22277) * first run at an SQL query removing duplicate appeals from distribution * code refactor and excluding disposition held and select that appeal for distribution * automated test for the duplicate hearing bug * fix rubocop offense SpaceInsideBlockBraces --------- Co-authored-by: Sean Parker <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> * Kev ma/appeals 51520 seeddata fix (#22307) * Removed non valid ce api documents types from uat * Added ce api valid vbms document type ids for uat --------- Co-authored-by: HunJerBAH <[email protected]> * fixed css on margin for text * Vinner57/appeals 42526 Correspondence and Appeal Tasks: Can view existing appeals related to the Veteran (#22261) * Adding the veteran related changes in correspondence details * Adding the changes to correspondence serializer * Adding the changes to correspondence details for the veteran information * fix for code climate and table border * #50661 - Jest tests for existing appeals * #50661 - undo yarn lock file * #42526 - css, jest tests, lint and merge conflicts * #42526 - lint and jest fixes * addressing PR comments * fix rubocop * #42526 - removed AptUtil usages --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: cacevesva <[email protected]> * fixed linting error. * fixed tests * lint fix * fixed linting issue --------- Co-authored-by: Ryan Marshall <[email protected]> Co-authored-by: Rnmarshall93 <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Ki Mau <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: sulak-j <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: vinner57 <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Sean Parker <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> Co-authored-by: Kevma50287 <[email protected]>

* added back in 10182 check for nod * added guard clause for nil class errors

…ment change (#22311) Co-authored-by: cacevesva <[email protected]>

* Fix for Package document type * Lint fixes * Removed Glamor --------- Co-authored-by: cacevesva <[email protected]>

* sorting the appeals * fix lint error * fix spaces * #42526 - fixed jest and lint errors --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: psivakeshva <[email protected]>

…22325) * Updated the spec file with package document type link verification * Lint fixes

…22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]>

* Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix

Co-authored-by: cacevesva <[email protected]>

* APPEALS-42525 - Added General Information, Styling * APPEALS-42525 - Updated Tests, Linting

* Fix for Package document type * Lint fixes * Removed Glamor --------- Co-authored-by: cacevesva <[email protected]>

…ment change (#22311) Co-authored-by: cacevesva <[email protected]>

…o Admins (#22297) * APPEALS-49005 - Added non_admin function for more limited user list * Unneeded Prop * Update admin check --------- Co-authored-by: cacevesva <[email protected]>

…#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]>

* Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]>

* Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]>

Co-authored-by: cacevesva <[email protected]>

This reverts commit 2e4fbef.

* removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues * removed unused method. * fixed correspondence_serializer calling the wrong method. * Correspondence and Appeal Tasks: Tasks not related to an Appeal - fix (#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Color fix (#22379) * Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]> * update mail_task.rb (#22376) Co-authored-by: cacevesva <[email protected]> * Revert "update mail_task.rb (#22376)" (#22385) This reverts commit 2e4fbef. --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: divyadasari-va <[email protected]>

* update mail_task.rb * added method override for verifying user in correspondence mail task model * fix spec tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* adding all correspondences table * added jest tests * spec fix

* Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix * Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix modifications * Fix for banner warning message for efolder * Add skips to MST PACT test to skip temporarily --------- Co-authored-by: Christopher Aceves <[email protected]>

… Completed Correspondences (#22374) * #48957 - Add Correspondences' Status to Intake Form * #48672 - Added a spec * #42642 - updated status in spec

* Code climate fixes initial commit * Added proptypes to tooltiphelper file * Jest fixes * Updated jest snap shots * Fix for dentical blocks of code being found in multiple locations for radio input field * Lint fixes * Jest fixes * Jest fixes updating the snapshots * Codeclimate fixes for const props * testing the duplication error fix for jest * User tests 'FeatureToggle.enabled?(:correspondence_queue)' at least 3 times * Add ignore for pdf offense * Complexity fixes --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]>

…pondence type dropdown (#22333) * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added conditional aria label * #51904 - removed aria attributes * Remove aria label by * #51904 - updated snapshots to have aria-label * #51904 - updated snapshots to have aria-label * #51904 - updated jest tests * #51904 - updated jest tests * #51904 - updated jest tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]>

…east 3 times (#22444)

* Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix

* Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]>

* update mail_task.rb * added method override for verifying user in correspondence mail task model * fix spec tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* APPEALS-48371 - Correspondence Cases Spec Updates * Moved user/super to helper * Fix for rubocop violations --------- Co-authored-by: Christopher Aceves <[email protected]>

* Initial commit for Response letters * codeclimate fix for correspondence_details_controller * Fixes the lint issues and removed unnessary code * Added feature test cases for response letters * Adding the wait time for spec for get success * Spec fix by increasing the wait time * Spec fixes for correspondence details response letter tab * Spec modification * Spec modification * Spec modification * Adding sleep for the spec helper * Changing the vist link from helper to spec file * lint fix * Codeclimate fixes * Spec fixes * Spec fix * Spec fix

…d from Correspondence to existing appeals (#22332) * stable rendering and backend data * fixed null errors * fixed typo * frontend populating correctly with the exception of num_of_issues * removed console.log * Fixed docket num column * stable checkpoint for tasks added to appeal * added missing bolded text * fixed border and badge * fixed veteran naming * style and html changes * quick styling fix * off color fix * updated the way tasks are handed, changed serializer and added new one. * added all functionality * fixed css issue and empty variable controller issue * fixed failing jest tests * final jest test changes * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Fix for Inbound Ops Team shows in Assign to team Task action (#22349) * Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix * APPEALS-51237, APPEALS-51536: Optimize feature tests in intake/appeal/edit_spec.rb and optimize automatic case distribution tests (#22280) * refactoring edit_spec * move one assertion and remove duplicate test * refactor withdraw issues context * move duplicate test assertions * move duplicate test assertions to existing tests and remove duplicate tests * move assertion and remove duplicate test * consolidate SCT appeal tests * refactor SCT tests to use step blocks * consolidate a individual test into a step * move CC appeal task tests to appeals_controller_spec intead of a feature test * remove unnecessary code comments * consolidate member not admin tests * remove commented portions of test * move tests from affinity_days_levers_spec.rb * move tests from affinity_days_levers_spec.rb, last commit was from audit_lever_history_table_spec.rb * remove ama_np_dist_goals_by_docket_lever_spec.rb * remove batch_size_levers_spec.rb * remove inactive_data_elements_levers_spec.rb * remove lever_buttons_spec.rb * refactor * move jest file for convention, add snapshot * move test for admin ui not interactable for non-admins to a jest test * remove unnecessary comments, whitespace * restore jest folder structure * modify edit spec to use case details page instead of searching again * modify assertions * remove TODO comment * add assertion to allow async save actions to be executed * add check to ensure banner is gone before trying to save * refactor assertions for lever history display * fix failing dependency report tests * APPEALS-53151: Update ECR Workflow to Utilize OIDC Flow (#22348) * Reconfigure ECR login workflow to utilize Github's OIDC flow * Add permissions * Update AWS account number to one for VAEC * Update account number for main CI workflow * Try using a separate secret in test * Try using a separate secret in test * Change name of secret --------- Co-authored-by: Matthew Thornton <[email protected]> * Added a space between the intake and create record buttons (#22360) Co-authored-by: cacevesva <[email protected]> * Color fix (#22369) * APPEALS-42525 - Package Details: General Information (#22350) * APPEALS-42525 - Added General Information, Styling * APPEALS-42525 - Updated Tests, Linting * Correspondence and Appeal Tasks: Tasks not related to an Appeal - fix (#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Color fix (#22379) * Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]> * update mail_task.rb (#22376) Co-authored-by: cacevesva <[email protected]> * Revert "update mail_task.rb (#22376)" (#22385) This reverts commit 2e4fbef. * APPEALS-42525 - Switching tests to Jest (#22392) * Correspondence and Appeal Tasks: Tasks not related to an Appeal (#22394) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues * removed unused method. * fixed correspondence_serializer calling the wrong method. * Correspondence and Appeal Tasks: Tasks not related to an Appeal - fix (#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e14. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Color fix (#22379) * Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]> * update mail_task.rb (#22376) Co-authored-by: cacevesva <[email protected]> * Revert "update mail_task.rb (#22376)" (#22385) This reverts commit 2e4fbef. --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * IsaiahB/APPEALS-53208 (#22410) * update mail_task.rb * added method override for verifying user in correspondence mail task model * fix spec tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * adding all correspondences table (#22415) * adding all correspondences table * added jest tests * spec fix * Rspec test fixes (#22411) * Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix * Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix modifications * Fix for banner warning message for efolder * Add skips to MST PACT test to skip temporarily --------- Co-authored-by: Christopher Aceves <[email protected]> * APPEALS-42525 - Update Styling (#22424) * Sivakesh/Appeals-42642 - Associate Prior Mail to only show Pending or Completed Correspondences (#22374) * #48957 - Add Correspondences' Status to Intake Form * #48672 - Added a spec * #42642 - updated status in spec * Caceves/appeals 53755 code climate fixes (#22427) * Code climate fixes initial commit * Added proptypes to tooltiphelper file * Jest fixes * Updated jest snap shots * Fix for dentical blocks of code being found in multiple locations for radio input field * Lint fixes * Jest fixes * Jest fixes updating the snapshots * Codeclimate fixes for const props * testing the duplication error fix for jest * User tests 'FeatureToggle.enabled?(:correspondence_queue)' at least 3 times * Add ignore for pdf offense * Complexity fixes --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * Sivakesh/appeals 51904 - 508: Jaws doesn't read options on the correspondence type dropdown (#22333) * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added conditional aria label * #51904 - removed aria attributes * Remove aria label by * #51904 - updated snapshots to have aria-label * #51904 - updated snapshots to have aria-label * #51904 - updated jest tests * #51904 - updated jest tests * #51904 - updated jest tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * CodeClimate fixes for User tests 'correspondence_queue_enabled?' at least 3 times (#22444) * Fix for Inbound Ops Team shows in Assign to team Task action (#22349) * Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Feature/appeals 43179 (#21665) * Calvin/APPEALS-43852-cavc-levers (#21441) * enabled cavc affinity levers in UI * updated rspec * [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to… (#21456) * [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to Account for Omit/Infinity * Affinity rules applied to non genpop * Addressed comments * Addressed comments * fixed rubocop issues + added clarity to where clause --------- Co-authored-by: Calvin <[email protected]> * APPEALS-44956: Add AppealAffinity model and database table (#21526) * add migration for appeal_affinities * add AppealAffinity model and associations, update migration for new column * update index to be unique * add factory, add tests * add factory traits to appeal and case for appeal affinities * add combination trait to appeal factory * add appeal_affinity to skipped associations in ETL reporting * add a validation, test * Craig/appeals 44958 (#21564) * add new job, update affinity model validation and after save hook * add update from push job * fix job extending distribution scopes * add with appeal affinities to distribution scopes * typo * add error handling, add test file * add distributed case factory, refactor naming in job * fix factories, added tests * fix migration for null affinity start date column * fixes, added tests * more test updates * add return in job if no query results, tests for no query results * add test for after_save hook adding dist task instructions * set start dist job to queue affinity job after running * fix update job and start dist job spec * queue affinity update job from push job * code clarity * fix judge in seed file * remove comment, fix hearing factory, disable some seeds for testing * add more tests * test refactor * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory * disable new seed on reset * update seed file with vet names, add another seed category * fix distirbuted case factory? * actually fix GHA runs * lint, test fixes * change constants in new job * [Appeals 43850] Update Legacy Docket Queries to Account for the Previous Decision Judge and Type Action (#21556) * test changes for seans ticket * test changes * added joins to all required methods * fixed lint * fixed column ambiguity errors * cleaned up naming scheme * Documentation for JOIN_PREVIOUS_APPEALS constant --------- Co-authored-by: Calvin <[email protected]> * APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611) * swap distribution queries from distribution_task to appeal_affinities * update seed files to use appeal affinities instead of distribution task * clean up seed file method names * add missing Timecop.return in ama affinity case seed * fix name of a method in a seed file * remove references to distribution task in distribution scopes * fix push priority job tests * fix naming of args in one of the seed files * fix user seed, fix date format in distribution task instructions * fix tests for date format update * APPEALS-44187: Factory Bot Additions (#21438) * AC1: values for bfddec and bfmpro * AC2: case issues updated to '3' * AC3-4: attorney and judge additions * ac 5: bfdpdcn addition * AC6: case type action addition * ac7: new folder match to original * ac8: case issues set to original * AC 3/4: added associations to original * ac3/4: updated logic to handle no args * ac3/4: return sattyid * ac7:updating folder assignment * ac7: added bfkey to except block * ac7/8: update to case issue list and validations dismissed * removed byebug * ac7: added 'ticknum' to except * lint fixes * lint fixes * lint fixes * lint fixes * nested trait into form_9 factory * new addtions * added .save to case issues * resolving correspondent and titrnum associations * fixed bfdc typo * factory additions * added ssn to associated corr. * removed transient and added .save * added after create to corr factory * veteran lookup check prior to create * committing missed 'end' * moved over veteran create to case fact. * move corr. association field to case fact. * lint issues + corres. save * Calvin/APPEALS-44957-rake-affinity (#21577) * grabbed receipt dates from distributed cases * refactored for functionality + added method to grab appeals that match * using receipt date, get all related appeals * added update/creation plus cleaned prior imple. * gets most recent distributed case receipt_date * skips if receipt_date is nil for performance * if appeal affinity is nil, it will now be updated * created spec file * fixed non ready appeals * updated query to match new AC * removing comment * testing for each docket * updated spec file * added new tests to rspec * updated start date to receipt date instead of Time.now * fixed date/time rspec errors * added rails logger to know when rake task has finished * added tag for rails log * removed nonpriority dockets for direct_review and evidence_submission * fixed lint issue * fixed flaky spec test * limits distributed cases query to within the last week * APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660) * add affinity start date to explain page * add feature test to verify dates display * Sudhir/appeals 43851 (#21613) * Implement CAVC + AOD Affinity Lever for AMA Dockets * addressed comments * addressed comments * Addressed comments * added cavc_aod_affinity in case distribution lever model * addressed comments * addressed comments * updated specs * Updated specs * specs changes reverted * ama_aod and ama_non_aod queries updated * change the assertion in docket spec * Craig/appeals 46196 (#21689) * fix query, tested locally * add basic test to verify csv downloads aren't broken * APPEALS-43851: Add test to validate CAVC+AOD behavior on hearing docket appeals affinities (#21678) * add test to validate cavc+aod on hearing docket appeals * lint, test case_docket_spec fix * modify case_docket_spec again * more test fix testing * attempt to fix test again * test removing prev appeals from nonpriority queries * more test tests * feature toggle change in test * reorder new portions of query * remove unused portions of queries in case_docket * revert unneeded change to query order * revert unneeded change to query order * update rake task and spec (#21731) * APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730) * add aod hearing cases to ama affinity cases seed * fix lever spec * APPEALS-45148: Hook to clear saved affinity date (#21623) * initial imp. idea * AC1: check for affinity_start_date on assignment * AC2/3: update affinity start date w/ instr. * updates to naming, instructions, and hook logic * updates after review * rspec coverage and addtional condition * removed unused identifier * removed reduntant 'self's * added update on actual AA record * updated to save aa record and addtional rspec * added change to assignment on no record test * check for assignment * addd update to 'on_hold' status * public method to handle legacy affinity appeals * added .reload to :with_affinity_appeal * added .reload to :ready_for_distribution * updates to pass explain_spec * switched boolean values * typo * readujsted order on :create for affinity appeal * removed after(:create) * testing rspec by readding after :create * reloading in assertation * addressing lint errors * fix seeds/users_spec * add case dist lever to new tests (#21776) * fix tests, add lever to factory, fix dist scopes (#21779) * fix rubocop warning * Acd/appeals 43853 43854 (#21971) * Calvin/appeals 43853 (#21723) * initial updates * removing unnecessary variable * focused in on priority * removing non priority stuff * added general comments * added BFAC and AOD to cavc aod lever query * adding judge vacols id to query * aod affinity_start_date filter initial changes * fixed sorting * fixed rubocop issues * updated filter method * error handling * added ineligibility to queries for PREV_DECIDING_JUDGE * fixed SQL query + added comments * added exclude from affinity check into the case docket queries * error handling + fixing sql queries * rejects appeals without affinity_start_dates and nonmatching judges * fixing rubocop offenses * fixed inconsistencies between methods * fixed conditions for rejecting appeals * refactored cavc aod affinity filter to make it much easier to read * refactored code to account for AC6 * error handling for empty exclude from affinity * reverted next if block to old logic to ensure it works * added PREV_DEC_JUDGE is not null * case.rb factory changes * added more options to legacy_cavc_appeal creation * cleaned up code for simpler reading * fix for aod legacy cavc creation * added tied to option to legacy cavc appeal factory * limits are now handled correctly in query * replaced return false to next if, as return false was causing unexpected behavior * fix rspecs + one edge case * added cavc aod lever creation to rspecs * removed bfac and aod from nonpriority query * cavc aod appeals w/excluded judges are now properly being filtered * refactored excluded judges check * added to old query to fix rspec errors * modified case factory bot * query now handles when prev_deciding_judge is nil * removed unnecessary condition * fixed case factory to now have tied_to attatched to orig appeal * fixed next if block within filter * handles omit scenarios + correctly rejects with next * working on rspec (still failing) * fix for ineligble VLJ when infinite * fixed rspec suite for cavc aod filters * fixed omit scenario in cavc aod affinity filter * consolidation & readability refactor * rubocop fixes * fixed spec error * Implement CAVC Affinity for Legacy Docket (#21706) * Implement CAVC Affinity for Legacy Docket * addressed comments * Added BFAC in the query * code changes for affinitty date * Added affinity code * code refactor and removed non priority code changes * fixed syntax change * Addressed comments * refactor cavc affinity filter * refactored code * code refactor * code refactor * Updated existing specs * code refactor * Added new rspecs * code refactor and added test cases * code refactor * added test cases * fixes push_priority_spec * fixed rubocop issues * rubocop issue fixed * refactored code to make it easier to understand * refactored + fixed rspec and lint errors --------- Co-authored-by: Calvin <[email protected]> Co-authored-by: calvincostaBAH <[email protected]> * basic creation of legacy affinity cases seed data * bug fixes, added bfcorlid with veterans, fully runs now * added new appeals for affinity_and_tied_to_judge * made data have realistic bfcorlids * changes document sequence to use less digits * added new file numbers for tied_to cases to make them easier to identify --------- Co-authored-by: samasudhirreddy <[email protected]> * APPEALS-50692: Update Appeals Ready to Distribute CSV to include CAVC remand original judge (#22070) * CSV download functional * add tests, fix CSV query in CaseDocket * fix lint * Calvin/appeals 44313 (#22119) * initial seed data file * added legacy cavc and cavc aod affinity cases * update * fixed tied to for legacy appeals * added AOD versions of appeals * small lint fixes * ensured AOD cases for legacy hearings with exluded or ineligible judge * added vacols staff record creation for users without it * APPEALS-47741: Update the UpdateAppealAffinityDatesJob to add appeal_affinity records for Legacy Appeals (#22023) * AC1: changes and respective tests * adjustements after refactoring * identifier mismatch * name update * name update * added appeal affinity filter * updated comment * remove byebug * update rspec to handle hash input * added no start date test case * updated process method test * removed 'todo' comment * dried up query string * aligned conditions * update to hash quotations * update to hash quotations * added legacy to priority receipt dates from dist. * moved append to resulting list * added legacy receipt date to push job hash * uncomment call to legacy * updated dist.id to @dist_id * uncomment call to process legacy appeals * handling update to legacy docket type * current rspec status * fixed typo * fix rspec * legacy spec additions * legacy spec additions * added legacy dist. case factory * removed vacols_judge ref * updates for spec * final review * removed comment * rubocop fixes * fix rubocop warnings (#22225) * Fix rubocop and tests (#22231) * Calvin/appeals 52551 (#22293) * age_of_n_oldest_priority_appeals_available_to_judge time out changes * fixed timeout issue for distribute_priority_appeals * fixed lint errors * Craig/case docket optimization (#22294) * age_of_n_oldest_priority_appeals_available_to_judge time out changes * fixed timeout issue for distribute_priority_appeals * optimize case docket priority distribution methods * fix das deprecation distribution spec --------- Co-authored-by: Calvin <[email protected]> * Update admin_ui_spec.rb for CAVC levers being enabled --------- Co-authored-by: calvincostaBAH <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: seanrpa <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> * APPEALS-46266, APPEALS-46239: ACD Stats and Slack message updates (#22388) * APPEALS-42221 Distribution Stats: Break statistics into columns (#21717) * rebuild branch * Create 20240506140249_add_cols_to_distribution_stats.rb * unit tests and linting * APPEALS-46244, APPEALS-46245 (#22077) * remove unnecessary reporting * send slack message to console if on local or demo * add excluded judges to slack report * reporting method cleanup * added affinity date stats to distribution_stats for each docket * Update docket.rb * Update distribution_scopes.rb * unit tests and linting * unit tests and linting * Slack message update * Update push_priority_appeals_to_judges_job.rb * Update push_priority_appeals_to_judges_job_spec.rb * code climate and code review changes (#22148) * code climate and code review changes * move code out to its own class * lint fixes * revert * disable reek checks * fix method calls * Hotfix/appeals 46639 prodtest (#22389) * Initial commit and turning off queue tab variables used for the frontend pagination for the bulk assign tab for the specialty case team. * Altered the queue actions to work with the new task selection action and a new redux action to remove tasks from a cached queue state. Also updated queue table to work with the redux caching instead of local state caching. * Added in task selection function changes to TaskTable to work with the altered task selection redux action. Also added the ability to pass down the redux cache property to queue table. Refactored the UnassignedCasesPage to allow for backend pagination of queue table instead of only working via frontend loaded data from the redux store. * Added the queueTableCache reducer slice. Added a :advanced_on_docket trait to the task factory for specialty_case_team_assign_tasks. Added the caching combined reducer to the queue table reducers. * Moved columnsFromConfig and createColumnObject functions out of QueueTableBuilder.jsx into a utils file so it can be used in multiple components around the app. * Updated the setSelectionOfTaskOfUser to work with the new action and data that it should be expecting. * Updated the selectedTasksSelector to work with the new task selection reducer and action. * Added a parameter for useReduxCache for TaskTable to send down to queue table instead of always setting it to true. Removed some comments from the queueTableCacheSlice removeTaskIdsFromCache reducer method/action. Passed in the new useReduxCache property to TaskTable in the UnassignedCasesPage component for the sct bulk assign queue. * Removed code out of QueueTableBuilder that is now in queueTableUtils.js. * Fixed a bug if queueConfig was an empty hash in the UnassignedCasesPage component. * Serializer optimizations for contested issues and issue categories. Also included request issues in the includes for the sct queue to take advantage of these optimizations. * Fixed a bug where clear filters was not properly updating the get parameters anymore for queue table. * Added cavc_type trait to the sct assign task factory. * Fix code climate issues. --------- Co-authored-by: = <[email protected]> * Updates key on line 63 to the correct value. (#22267) Co-authored-by: Ron Wabukenda <[email protected]> * Hotfix/appeals-42846 Fixes incorrect spelling of SupervisorySeniorCounsel across project (#22391) * Repushing branch to fix CodeClimate and Rspec issue * Attempt to fix failed Rspec. * Revert Schema changes --------- Co-authored-by: Ron Wabukenda <[email protected]> * consolidate individual RO accessors into a single test for each RO (#22407) * Revert "Updates key on line 63 to the correct value. (#22267)" (#22417) This reverts commit def10f5. * Revert "Feature/appeals 43179 (#21665)" (#22425) This reverts commit 7613209. * Ki/APPEALS-48371 - Refactor correspondence_cases_spec.rb (#22474) * APPEALS-48371 - Correspondence Cases Spec Updates * Moved user/super to helper * Fix for rubocop violations --------- Co-authored-by: Christopher Aceves <[email protected]> * Div/appeals 42524 (#22471) * Initial commit for Response letters * codeclimate fix for correspondence_details_controller * Fixes the lint issues and removed unnessary code * Added feature test cases for response letters * Adding the wait time for spec for get success * Spec fix by increasing the wait time * Spec fixes for correspondence details response letter tab * Spec modification * Spec modification * Spec modification * Adding sleep for the spec helper * Changing the vist link from helper to spec file * lint fix * Codeclimate fixes * Spec fixes * Spec fix * Spec fix * fixed new props data breaking component * Fix lint error * updated labels * changed docket number to caps * git redo * working link * made changes based on github feedback. * fixed linter issue --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Ki Mau <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: vinner57 <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: calvincostaBAH <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: seanrpa <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> Co-authored-by: Matt Roth <[email protected]> Co-authored-by: Brandon Lee Dorner <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: VaForceZ <[email protected]> Co-authored-by: Ron Wabukenda <[email protected]>

…s Doesn't Align with Completed Tab Status (#22368) * created correspondence statuses and created correspondence status methods. * work in progress task not related to an appeal method * updated correspondence status methods * fixed bug with completed status not showing correctly * removed old comment * reverted name change * work in progress moving logic from correspondence to root task. * created correspondence status method * put back in correspondence status check * added scopes to correspondence task model * moved root task as source of truth for correspondence status and task management * fixed correspondence status names * defined new correspondence task scopes * created root task test coverage * added open package action test * test coverage for task_not_related_to_an_appeal * updated tasks_not_related_to_an_appeal test * fixed bug where mail tasks didn't inherit from correspondence and created test coverage. * created tests for correspondence_status * added in progress tests * added completed task status test * refactored test * refactored package task check and tests * refactored completed task tabs * created logic for user in progress tasks * refactored assigned tasks tab logic * reworked unassigned, action required, and pending task tabs in organization queue * fixed linting issues * fixed failing correspondence details tests * created correspondence status traits in seed file * removed unused attribute check from controller spec * updated failing tests * fixed code climate issues * fixed issue with failing test * added back in assigned to for correspondence helper * fix seed data that caused failing intake test * fixed failing tests on intake_spec * updated seed data * reworked assigned tasks tab to not include action required tasks * freeze active task names * DRY'ed up the constants in intake processor * refactored methods for code climate offenses * resolved code climate issues * Divya fix for correspondence case timeline actions * fixed linting errors and added response letter safety opperator --------- Co-authored-by: cacevesva <[email protected]>

) * resolving conflicts with feature branch * resolving conflicts with feature branch * resolvong conflicts * resolving conflicts * adding the seed data * fix lint issues * fix lint errors * fix rubocop issues * refactoring code * fix rubocop issues * spec fix --------- Co-authored-by: cacevesva <[email protected]>

* Modifed the sorting order for response letters and added the missed column * adjust spacing * adjust missing letter * adjust missing letter --------- Co-authored-by: cacevesva <[email protected]>

* WIP * cancel_corrresponence_task WIP * Modal Working * Modal WIP * modal WIP * WIP routing * WIP working routes can cancel function * WIP working banner * Redux fix WIP * WIP * Spec test created and passing * Passing jest test * created cancel action for details redux store * created action to remove task from redux store on cancel * Fixing rubocop tests * Fixed errors * Code Climate update * Adressing comments * Addressing Comments --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

…ing “view documents” (#22595) * finished link to veteran docs page. * APPEALS-55525: Disable tests for seed files and lock Chrome version to v127 in Github Actions (#22567) * add exclude pattern to github actions rspec command * add test file exclude pattern constant * lock chrome version to 127.0.6533.119 * Correspondence and Appeal Tasks: Related Appeals: Can view tasks added from Correspondence to existing appeals (#22332) * stable rendering and backend data * fixed null errors * fixed typo * frontend populating correctly with the exception of num_of_issues * removed console.log * Fixed docket num column * stable checkpoint for tasks added to appeal * added missing bolded text * fixed border and badge * fixed veteran naming * style and html changes * quick styling fix * off color fix * updated the way tasks are handed, changed serializer and added new one. * added all functionality * fixed css issue and empty variable controller issue * fixed failing jest tests * final jest test changes * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e142c2fb86472459c335622705457c51e36e. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Fix for Inbound Ops Team shows in Assign to team Task action (#22349) * Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix * APPEALS-51237, APPEALS-51536: Optimize feature tests in intake/appeal/edit_spec.rb and optimize automatic case distribution tests (#22280) * refactoring edit_spec * move one assertion and remove duplicate test * refactor withdraw issues context * move duplicate test assertions * move duplicate test assertions to existing tests and remove duplicate tests * move assertion and remove duplicate test * consolidate SCT appeal tests * refactor SCT tests to use step blocks * consolidate a individual test into a step * move CC appeal task tests to appeals_controller_spec intead of a feature test * remove unnecessary code comments * consolidate member not admin tests * remove commented portions of test * move tests from affinity_days_levers_spec.rb * move tests from affinity_days_levers_spec.rb, last commit was from audit_lever_history_table_spec.rb * remove ama_np_dist_goals_by_docket_lever_spec.rb * remove batch_size_levers_spec.rb * remove inactive_data_elements_levers_spec.rb * remove lever_buttons_spec.rb * refactor * move jest file for convention, add snapshot * move test for admin ui not interactable for non-admins to a jest test * remove unnecessary comments, whitespace * restore jest folder structure * modify edit spec to use case details page instead of searching again * modify assertions * remove TODO comment * add assertion to allow async save actions to be executed * add check to ensure banner is gone before trying to save * refactor assertions for lever history display * fix failing dependency report tests * APPEALS-53151: Update ECR Workflow to Utilize OIDC Flow (#22348) * Reconfigure ECR login workflow to utilize Github's OIDC flow * Add permissions * Update AWS account number to one for VAEC * Update account number for main CI workflow * Try using a separate secret in test * Try using a separate secret in test * Change name of secret --------- Co-authored-by: Matthew Thornton <[email protected]> * Added a space between the intake and create record buttons (#22360) Co-authored-by: cacevesva <[email protected]> * Color fix (#22369) * APPEALS-42525 - Package Details: General Information (#22350) * APPEALS-42525 - Added General Information, Styling * APPEALS-42525 - Updated Tests, Linting * Correspondence and Appeal Tasks: Tasks not related to an Appeal - fix (#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e142c2fb86472459c335622705457c51e36e. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Color fix (#22379) * Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]> * update mail_task.rb (#22376) Co-authored-by: cacevesva <[email protected]> * Revert "update mail_task.rb (#22376)" (#22385) This reverts commit 2e4fbef953eb48d7e31ceb22ec0a850ff1205c75. * APPEALS-42525 - Switching tests to Jest (#22392) * Correspondence and Appeal Tasks: Tasks not related to an Appeal (#22394) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e142c2fb86472459c335622705457c51e36e. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues * removed unused method. * fixed correspondence_serializer calling the wrong method. * Correspondence and Appeal Tasks: Tasks not related to an Appeal - fix (#22330) * removed duplicate row * fixed task text and improved code reability * enhanced key, isolated serializer issue * added filtering of additional types * APPEALS-42531 - Correspondence Cases: Pending tab: FOIA request link (#22329) * update schema * updating task_url * create folder, file and test coverage for FOIA Request * Fix minor lint error * Revert "update schema" This reverts commit d358e142c2fb86472459c335622705457c51e36e. --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * reworked data source for available actions * fixed lint offense * removed binding.pry * made changes to serializer and correspondence model * Fix for prettier offense * fixed linting issues --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Color fix (#22379) * Color fix * Lint fix --------- Co-authored-by: cacevesva <[email protected]> * update mail_task.rb (#22376) Co-authored-by: cacevesva <[email protected]> * Revert "update mail_task.rb (#22376)" (#22385) This reverts commit 2e4fbef953eb48d7e31ceb22ec0a850ff1205c75. --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * IsaiahB/APPEALS-53208 (#22410) * update mail_task.rb * added method override for verifying user in correspondence mail task model * fix spec tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]> * adding all correspondences table (#22415) * adding all correspondences table * added jest tests * spec fix * Rspec test fixes (#22411) * Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix * Correspondence Cases page Banner alert for approval and reject request approve request to reassign test fix modifications * Fix for banner warning message for efolder * Add skips to MST PACT test to skip temporarily --------- Co-authored-by: Christopher Aceves <[email protected]> * APPEALS-42525 - Update Styling (#22424) * Sivakesh/Appeals-42642 - Associate Prior Mail to only show Pending or Completed Correspondences (#22374) * #48957 - Add Correspondences' Status to Intake Form * #48672 - Added a spec * #42642 - updated status in spec * Caceves/appeals 53755 code climate fixes (#22427) * Code climate fixes initial commit * Added proptypes to tooltiphelper file * Jest fixes * Updated jest snap shots * Fix for dentical blocks of code being found in multiple locations for radio input field * Lint fixes * Jest fixes * Jest fixes updating the snapshots * Codeclimate fixes for const props * testing the duplication error fix for jest * User tests 'FeatureToggle.enabled?(:correspondence_queue)' at least 3 times * Add ignore for pdf offense * Complexity fixes --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> * Sivakesh/appeals 51904 - 508: Jaws doesn't read options on the correspondence type dropdown (#22333) * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added aria attributes * #51904 - added conditional aria label * #51904 - removed aria attributes * Remove aria label by * #51904 - updated snapshots to have aria-label * #51904 - updated snapshots to have aria-label * #51904 - updated jest tests * #51904 - updated jest tests * #51904 - updated jest tests --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> * CodeClimate fixes for User tests 'correspondence_queue_enabled?' at least 3 times (#22444) * Fix for Inbound Ops Team shows in Assign to team Task action (#22349) * Fix for Inbound Ops Team shows in Assign to team Task action * codeclimate fix * Code climate fix (#22377) * Code climate fix * Rubocop fix --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> * Feature/appeals 43179 (#21665) * Calvin/APPEALS-43852-cavc-levers (#21441) * enabled cavc affinity levers in UI * updated rspec * [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to… (#21456) * [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to Account for Omit/Infinity * Affinity rules applied to non genpop * Addressed comments * Addressed comments * fixed rubocop issues + added clarity to where clause --------- Co-authored-by: Calvin <[email protected]> * APPEALS-44956: Add AppealAffinity model and database table (#21526) * add migration for appeal_affinities * add AppealAffinity model and associations, update migration for new column * update index to be unique * add factory, add tests * add factory traits to appeal and case for appeal affinities * add combination trait to appeal factory * add appeal_affinity to skipped associations in ETL reporting * add a validation, test * Craig/appeals 44958 (#21564) * add new job, update affinity model validation and after save hook * add update from push job * fix job extending distribution scopes * add with appeal affinities to distribution scopes * typo * add error handling, add test file * add distributed case factory, refactor naming in job * fix factories, added tests * fix migration for null affinity start date column * fixes, added tests * more test updates * add return in job if no query results, tests for no query results * add test for after_save hook adding dist task instructions * set start dist job to queue affinity job after running * fix update job and start dist job spec * queue affinity update job from push job * code clarity * fix judge in seed file * remove comment, fix hearing factory, disable some seeds for testing * add more tests * test refactor * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory * disable new seed on reset * update seed file with vet names, add another seed category * fix distirbuted case factory? * actually fix GHA runs * lint, test fixes * change constants in new job * [Appeals 43850] Update Legacy Docket Queries to Account for the Previous Decision Judge and Type Action (#21556) * test changes for seans ticket * test changes * added joins to all required methods * fixed lint * fixed column ambiguity errors * cleaned up naming scheme * Documentation for JOIN_PREVIOUS_APPEALS constant --------- Co-authored-by: Calvin <[email protected]> * APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611) * swap distribution queries from distribution_task to appeal_affinities * update seed files to use appeal affinities instead of distribution task * clean up seed file method names * add missing Timecop.return in ama affinity case seed * fix name of a method in a seed file * remove references to distribution task in distribution scopes * fix push priority job tests * fix naming of args in one of the seed files * fix user seed, fix date format in distribution task instructions * fix tests for date format update * APPEALS-44187: Factory Bot Additions (#21438) * AC1: values for bfddec and bfmpro * AC2: case issues updated to '3' * AC3-4: attorney and judge additions * ac 5: bfdpdcn addition * AC6: case type action addition * ac7: new folder match to original * ac8: case issues set to original * AC 3/4: added associations to original * ac3/4: updated logic to handle no args * ac3/4: return sattyid * ac7:updating folder assignment * ac7: added bfkey to except block * ac7/8: update to case issue list and validations dismissed * removed byebug * ac7: added 'ticknum' to except * lint fixes * lint fixes * lint fixes * lint fixes * nested trait into form_9 factory * new addtions * added .save to case issues * resolving correspondent and titrnum associations * fixed bfdc typo * factory additions * added ssn to associated corr. * removed transient and added .save * added after create to corr factory * veteran lookup check prior to create * committing missed 'end' * moved over veteran create to case fact. * move corr. association field to case fact. * lint issues + corres. save * Calvin/APPEALS-44957-rake-affinity (#21577) * grabbed receipt dates from distributed cases * refactored for functionality + added method to grab appeals that match * using receipt date, get all related appeals * added update/creation plus cleaned prior imple. * gets most recent distributed case receipt_date * skips if receipt_date is nil for performance * if appeal affinity is nil, it will now be updated * created spec file * fixed non ready appeals * updated query to match new AC * removing comment * testing for each docket * updated spec file * added new tests to rspec * updated start date to receipt date instead of Time.now * fixed date/time rspec errors * added rails logger to know when rake task has finished * added tag for rails log * removed nonpriority dockets for direct_review and evidence_submission * fixed lint issue * fixed flaky spec test * limits distributed cases query to within the last week * APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660) * add affinity start date to explain page * add feature test to verify dates display * Sudhir/appeals 43851 (#21613) * Implement CAVC + AOD Affinity Lever for AMA Dockets * addressed comments * addressed comments * Addressed comments * added cavc_aod_affinity in case distribution lever model * addressed comments * addressed comments * updated specs * Updated specs * specs changes reverted * ama_aod and ama_non_aod queries updated * change the assertion in docket spec * Craig/appeals 46196 (#21689) * fix query, tested locally * add basic test to verify csv downloads aren't broken * APPEALS-43851: Add test to validate CAVC+AOD behavior on hearing docket appeals affinities (#21678) * add test to validate cavc+aod on hearing docket appeals * lint, test case_docket_spec fix * modify case_docket_spec again * more test fix testing * attempt to fix test again * test removing prev appeals from nonpriority queries * more test tests * feature toggle change in test * reorder new portions of query * remove unused portions of queries in case_docket * revert unneeded change to query order * revert unneeded change to query order * update rake task and spec (#21731) * APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730) * add aod hearing cases to ama affinity cases seed * fix lever spec * APPEALS-45148: Hook to clear saved affinity date (#21623) * initial imp. idea * AC1: check for affinity_start_date on assignment * AC2/3: update affinity start date w/ instr. * updates to naming, instructions, and hook logic * updates after review * rspec coverage and addtional condition * removed unused identifier * removed reduntant 'self's * added update on actual AA record * updated to save aa record and addtional rspec * added change to assignment on no record test * check for assignment * addd update to 'on_hold' status * public method to handle legacy affinity appeals * added .reload to :with_affinity_appeal * added .reload to :ready_for_distribution * updates to pass explain_spec * switched boolean values * typo * readujsted order on :create for affinity appeal * removed after(:create) * testing rspec by readding after :create * reloading in assertation * addressing lint errors * fix seeds/users_spec * add case dist lever to new tests (#21776) * fix tests, add lever to factory, fix dist scopes (#21779) * fix rubocop warning * Acd/appeals 43853 43854 (#21971) * Calvin/appeals 43853 (#21723) * initial updates * removing unnecessary variable * focused in on priority * removing non priority stuff * added general comments * added BFAC and AOD to cavc aod lever query * adding judge vacols id to query * aod affinity_start_date filter initial changes * fixed sorting * fixed rubocop issues * updated filter method * error handling * added ineligibility to queries for PREV_DECIDING_JUDGE * fixed SQL query + added comments * added exclude from affinity check into the case docket queries * error handling + fixing sql queries * rejects appeals without affinity_start_dates and nonmatching judges * fixing rubocop offenses * fixed inconsistencies between methods * fixed conditions for rejecting appeals * refactored cavc aod affinity filter to make it much easier to read * refactored code to account for AC6 * error handling for empty exclude from affinity * reverted next if block to old logic to ensure it works * added PREV_DEC_JUDGE is not null * case.rb factory changes * added more options to legacy_cavc_appeal creation * cleaned up code for simpler reading * fix for aod legacy cavc creation * added tied to option to legacy cavc appeal factory * limits are now handled correctly in query * replaced return false to next if, as return false was causing unexpected behavior * fix rspecs + one edge case * added cavc aod lever creation to rspecs * removed bfac and aod from nonpriority query * cavc aod appeals w/excluded judges are now properly being filtered * refactored excluded judges check * added to old query to fix rspec errors * modified case factory bot * query now handles when prev_deciding_judge is nil * removed unnecessary condition * fixed case factory to now have tied_to attatched to orig appeal * fixed next if block within filter * handles omit scenarios + correctly rejects with next * working on rspec (still failing) * fix for ineligble VLJ when infinite * fixed rspec suite for cavc aod filters * fixed omit scenario in cavc aod affinity filter * consolidation & readability refactor * rubocop fixes * fixed spec error * Implement CAVC Affinity for Legacy Docket (#21706) * Implement CAVC Affinity for Legacy Docket * addressed comments * Added BFAC in the query * code changes for affinitty date * Added affinity code * code refactor and removed non priority code changes * fixed syntax change * Addressed comments * refactor cavc affinity filter * refactored code * code refactor * code refactor * Updated existing specs * code refactor * Added new rspecs * code refactor and added test cases * code refactor * added test cases * fixes push_priority_spec * fixed rubocop issues * rubocop issue fixed * refactored code to make it easier to understand * refactored + fixed rspec and lint errors --------- Co-authored-by: Calvin <[email protected]> Co-authored-by: calvincostaBAH <[email protected]> * basic creation of legacy affinity cases seed data * bug fixes, added bfcorlid with veterans, fully runs now * added new appeals for affinity_and_tied_to_judge * made data have realistic bfcorlids * changes document sequence to use less digits * added new file numbers for tied_to cases to make them easier to identify --------- Co-authored-by: samasudhirreddy <[email protected]> * APPEALS-50692: Update Appeals Ready to Distribute CSV to include CAVC remand original judge (#22070) * CSV download functional * add tests, fix CSV query in CaseDocket * fix lint * Calvin/appeals 44313 (#22119) * initial seed data file * added legacy cavc and cavc aod affinity cases * update * fixed tied to for legacy appeals * added AOD versions of appeals * small lint fixes * ensured AOD cases for legacy hearings with exluded or ineligible judge * added vacols staff record creation for users without it * APPEALS-47741: Update the UpdateAppealAffinityDatesJob to add appeal_affinity records for Legacy Appeals (#22023) * AC1: changes and respective tests * adjustements after refactoring * identifier mismatch * name update * name update * added appeal affinity filter * updated comment * remove byebug * update rspec to handle hash input * added no start date test case * updated process method test * removed 'todo' comment * dried up query string * aligned conditions * update to hash quotations * update to hash quotations * added legacy to priority receipt dates from dist. * moved append to resulting list * added legacy receipt date to push job hash * uncomment call to legacy * updated dist.id to @dist_id * uncomment call to process legacy appeals * handling update to legacy docket type * current rspec status * fixed typo * fix rspec * legacy spec additions * legacy spec additions * added legacy dist. case factory * removed vacols_judge ref * updates for spec * final review * removed comment * rubocop fixes * fix rubocop warnings (#22225) * Fix rubocop and tests (#22231) * Calvin/appeals 52551 (#22293) * age_of_n_oldest_priority_appeals_available_to_judge time out changes * fixed timeout issue for distribute_priority_appeals * fixed lint errors * Craig/case docket optimization (#22294) * age_of_n_oldest_priority_appeals_available_to_judge time out changes * fixed timeout issue for distribute_priority_appeals * optimize case docket priority distribution methods * fix das deprecation distribution spec --------- Co-authored-by: Calvin <[email protected]> * Update admin_ui_spec.rb for CAVC levers being enabled --------- Co-authored-by: calvincostaBAH <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: seanrpa <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> * APPEALS-46266, APPEALS-46239: ACD Stats and Slack message updates (#22388) * APPEALS-42221 Distribution Stats: Break statistics into columns (#21717) * rebuild branch * Create 20240506140249_add_cols_to_distribution_stats.rb * unit tests and linting * APPEALS-46244, APPEALS-46245 (#22077) * remove unnecessary reporting * send slack message to console if on local or demo * add excluded judges to slack report * reporting method cleanup * added affinity date stats to distribution_stats for each docket * Update docket.rb * Update distribution_scopes.rb * unit tests and linting * unit tests and linting * Slack message update * Update push_priority_appeals_to_judges_job.rb * Update push_priority_appeals_to_judges_job_spec.rb * code climate and code review changes (#22148) * code climate and code review changes * move code out to its own class * lint fixes * revert * disable reek checks * fix method calls * Hotfix/appeals 46639 prodtest (#22389) * Initial commit and turning off queue tab variables used for the frontend pagination for the bulk assign tab for the specialty case team. * Altered the queue actions to work with the new task selection action and a new redux action to remove tasks from a cached queue state. Also updated queue table to work with the redux caching instead of local state caching. * Added in task selection function changes to TaskTable to work with the altered task selection redux action. Also added the ability to pass down the redux cache property to queue table. Refactored the UnassignedCasesPage to allow for backend pagination of queue table instead of only working via frontend loaded data from the redux store. * Added the queueTableCache reducer slice. Added a :advanced_on_docket trait to the task factory for specialty_case_team_assign_tasks. Added the caching combined reducer to the queue table reducers. * Moved columnsFromConfig and createColumnObject functions out of QueueTableBuilder.jsx into a utils file so it can be used in multiple components around the app. * Updated the setSelectionOfTaskOfUser to work with the new action and data that it should be expecting. * Updated the selectedTasksSelector to work with the new task selection reducer and action. * Added a parameter for useReduxCache for TaskTable to send down to queue table instead of always setting it to true. Removed some comments from the queueTableCacheSlice removeTaskIdsFromCache reducer method/action. Passed in the new useReduxCache property to TaskTable in the UnassignedCasesPage component for the sct bulk assign queue. * Removed code out of QueueTableBuilder that is now in queueTableUtils.js. * Fixed a bug if queueConfig was an empty hash in the UnassignedCasesPage component. * Serializer optimizations for contested issues and issue categories. Also included request issues in the includes for the sct queue to take advantage of these optimizations. * Fixed a bug where clear filters was not properly updating the get parameters anymore for queue table. * Added cavc_type trait to the sct assign task factory. * Fix code climate issues. --------- Co-authored-by: = <[email protected]> * Updates key on line 63 to the correct value. (#22267) Co-authored-by: Ron Wabukenda <[email protected]> * Hotfix/appeals-42846 Fixes incorrect spelling of SupervisorySeniorCounsel across project (#22391) * Repushing branch to fix CodeClimate and Rspec issue * Attempt to fix failed Rspec. * Revert Schema changes --------- Co-authored-by: Ron Wabukenda <[email protected]> * consolidate individual RO accessors into a single test for each RO (#22407) * Revert "Updates key on line 63 to the correct value. (#22267)" (#22417) This reverts commit def10f5556a8d04b8b8125e00eb35bf0d56d1c8c. * Revert "Feature/appeals 43179 (#21665)" (#22425) This reverts commit 7613209eac2913058a6a2c52ddc21194c23ab80f. * Ki/APPEALS-48371 - Refactor correspondence_cases_spec.rb (#22474) * APPEALS-48371 - Correspondence Cases Spec Updates * Moved user/super to helper * Fix for rubocop violations --------- Co-authored-by: Christopher Aceves <[email protected]> * Div/appeals 42524 (#22471) * Initial commit for Response letters * codeclimate fix for correspondence_details_controller * Fixes the lint issues and removed unnessary code * Added feature test cases for response letters * Adding the wait time for spec for get success * Spec fix by increasing the wait time * Spec fixes for correspondence details response letter tab * Spec modification * Spec modification * Spec modification * Adding sleep for the spec helper * Changing the vist link from helper to spec file * lint fix * Codeclimate fixes * Spec fixes * Spec fix * Spec fix * fixed new props data breaking component * Fix lint error * updated labels * changed docket number to caps * git redo * working link * made changes based on github feedback. * fixed linter issue --------- Co-authored-by: IsaiahBar <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Ki Mau <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: vinner57 <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: calvincostaBAH <[email protected]> Co-authored-by: samasudhirreddy <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: seanrpa <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> Co-authored-by: Matt Roth <[email protected]> Co-authored-by: Brandon Lee Dorner <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: VaForceZ <[email protected]> Co-authored-by: Ron Wabukenda <[email protected]> * APPEALS-53014 and APPEALS-53057: Correspondence Details Pending Status Doesn't Align with Completed Tab Status (#22368) * created correspondence statuses and created correspondence status methods. * work in progress task not related to an appeal method * updated correspondence status methods * fixed bug with completed status not showing correctly * removed old comment * reverted name change * work in progress moving logic from correspondence to root task. * created correspondence status method * put back in correspondence status check * added scopes to correspondence task model * moved root task as source of truth for correspondence status and task management * fixed correspondence status names * defined new correspondence task scopes * created root task test coverage * added open package action test * test coverage for task_not_related_to_an_appeal * updated tasks_not_related_to_an_appeal test * fixed bug where mail tasks didn't inherit from correspondence and created test coverage. * created tests for correspondence_status * added in progress tests * added completed task status test * refactored test * refactored package task check and tests * refactored completed task tabs * created logic for user in progress tasks * refactored assigned tasks tab logic * reworked unassigned, action required, and pending task tabs in organization queue * fixed linting issues * fixed failing correspondence details tests * created correspondence status traits in seed file * removed unused attribute check from controller spec * updated failing tests * fixed code climate issues * fixed issue with failing test * added back in assigned to for correspondence helper * fix seed data that caused failing intake test * fixed failing tests on intake_spec * updated seed data * reworked assigned tasks tab to not include action required tasks * freeze active task names * DRY'ed up the constants in intake processor * refactored methods for code climate offenses * resolved code climate issues * Divya fix for correspondence case timeline actions * fixed linting errors and added response letter safety opperator --------- Co-authored-by: cacevesva <[email protected]> * Create Associated Prior Mail: Can view all associated prior mail (#22542) * resolving conflicts with feature branch * resolving conflicts with feature branch * resolvong conflicts * resolving conflicts * adding the seed data * fix lint issues * fix lint errors * fix rubocop issues * refactoring code * fix rubocop issues * spec fix --------- Co-authored-by: cacevesva <[email protected]> * Release R2.3.0 FY24Q4.3.0 (#22517) * Hotfix/appeals 45 2 (#22198) * Trigger Build * Update email address from Hearings to Decisions --------- Co-authored-by: Ron Wabukenda <[email protected]> * APPEALS-46269: Remove the ability to enable proportions code (#22499) * remove conditional for selecting distribution algorithm * fix tests which broke when removing the toggle * Feature/appeals 42187 (#22522) * cmartine/APPEALS-42621 (#21599) * Add remove_comp_and_pen_intake feature toggle to intakes controller * Add new compensation and pension removal message to COPY.json * Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on * Frontend test updates * Add tooltip checks for review page integration tests * fix frontend test lint errors * frontend tests changes * Fix linter errors --------- Co-authored-by: kshiflett88 <[email protected]> Co-authored-by: root <root@DESKTOP-IBDKNPF> * nrithner/APPEALS-45263 (#21617) * Add remove_comp_and_pen_intake feature toggle to intakes controller * Add new compensation and pension removal message to COPY.json * Disable comp and pen radio buttons if remove_comp_and_pen_intake toggle is on * Frontend test updates * Add tooltip checks for review page integration tests * fix frontend test lint errors * frontend tests changes * Add banner for non-vha * Add banner for VHA employee * Refactor conditionals * Refactor logic for banners to display * Add dangerouslySetHtml to banner * Add test for no VHA employee with vha_claim_review_establishment disabled. * Add VHA employee scenario to display REMOVE_INTAKE_COMP_AND_PEN * Complete non vha user scenarios * Complete VHA employee scenarios * Remove comments * Fix linter errors * Remove spaces preceding question marks * Correct linting errors --------- Co-authored-by: Chris-Martine <[email protected]> Co-authored-by: kshiflett88 <[email protected]> Co-authored-by: root <root@DESKTOP-IBDKNPF> --------- Co-authored-by: Chris-Martine <[email protected]> Co-authored-by: kshiflett88 <[email protected]> Co-authored-by: root <root@DESKTOP-IBDKNPF> Co-authored-by: nicorithner-bah <[email protected]> Co-authored-by: Chris-Martine <[email protected]> * Feature/appeals 51138.rc.4.3.0 (#22523) * APPEALS-36339 (#21436) * Updated to remove obsolete levers of ACD Disable Legacy Distributions and ACD Disable Non-priority Distributions * Fixed redundant linting issue * Fixed empty line linting issue * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Removed unused node env * mbeard/APPEALS-44379 (#21451) * init commit * new questions about method * method for ready_appeals_from_levers 3rd iteration * switched to conditional * updates test and constants file * adds testing scenarios for edge cases * fixes test * adds constants to top of file --------- Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-44417 Seeds for Docket Lever Demo (#21534) Co-authored-by: Christopher Detlef <> * APPEALS-36345-updated (#21537) * Refactored exclusion table * Fixed ordering issue and testing * mbeard/APPEALS-44379 (#21530) * init commit * new questions about method * method for ready_appeals_from_levers 3rd iteration * switched to conditional * updates test and constants file * adds testing scenarios for edge cases * fixes test * adds constants to top of file * first new commit with new args * updates methods and test query * updates age_of_oldest methods params * cleans up method removes args and updates tests, fixes linting --------- Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-44346 Demo Docket Goal Lever Test Seed Data (#21524) Co-authored-by: Christopher Detlef <> * Chrisbdetlef/appeals 40705 (#21535) * Chris backend Work * APPEALS-44441. Added initial changes for individual seed * WIP * APPEALS-44441. Fixed the table css * APPEALS-44441. Added Custom and Scenario Seed components and jest tests * APPEALS-44441. Fix ScenarioSeeds jest test * APPEALS-44441. Fix CustomeSeeds Jest test * init commit * fixes linting issues * capybara test init * APPEALS-44441. Backend Integration API changes * APPEALS-44441_1. Matched the constant keys in the backend * APPEALS-44441_1. Update the param to match the backend and fixed spec * APPEALS-44441. lint fixes * APPEALS-44441. linting fixes * sharsha/APPEALS-44441. fixed the route and tests * Change route * Change variables to match front and back end * CustomSeed Jest test fix * Fix issues * Fix rubocop issues * Use existing method in the controller --------- Co-authored-by: Christopher Detlef <> Co-authored-by: SHarshain <[email protected]> Co-authored-by: Michael Beard <[email protected]> Co-authored-by: Amy Detwiler <[email protected]> * Sharsha/appeals 45531 (#21566) * Fixed rspec failures on constants * APPEALS-45531. Remove dead code --------- Co-authored-by: SHarshain <[email protected]> * Updated lever history to handle null unit values from docket levers (#21567) Co-authored-by: 631966 <[email protected]> * Sharsha/appeals 45531_1 (#21573) * APPEALS-45531. Add the controller which is used in the route * APPEALS-45531. Fix lint issue * Remove access check for this iteration * APPEALS-45531. Fix lint issue in controller --------- Co-authored-by: SHarshain <[email protected]> Co-authored-by: Christopher Detlef <> Co-authored-by: Amy Detwiler <[email protected]> * Sharsha/appeals 45531 1 (#21609) * APPEALS-45531. Add the controller which is used in the route * APPEALS-45531. Fix lint issue * Remove access check for this iteration * APPEALS-45531. Fix lint issue in controller * TEST FOR FIX * MORE TESTING * Fixed rspec issues --------- Co-authored-by: SHarshain <[email protected]> Co-authored-by: Christopher Detlef <> Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-45502. Organize route and fix the controller (#21595) Co-authored-by: SHarshain <[email protected]> Co-authored-by: Amy Detwiler <[email protected]> * Ricky/APPEALS-36345.fixes (#21612) * Updated lever history to handle null unit values from docket levers * Updated member view of exclusion table with proper text display and fixed missing css * Updated unit test and test data to test rendering of exclusionTable --------- Co-authored-by: 631966 <[email protected]> * ricky/APPEALS-44053 (#21587) * init commit, adds conditional to check for docket_type ama to method, fixes json constants to snakecase * puts statements testing * updates seeds for evidence_submission, adds method to hearing_request_docket.rb and dist_concern.rb * updated appeals dsit * final fix for PR * updates spec to reflect changes in hearing_request_docket * uncomments seeds * Ricky/appeals 43523 (#21649) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests --------- Co-authored-by: 631068 <[email protected]> * APPEALS-45898. Updated the lever_group_order values (#21639) * APPEALS-45898. Updated the lever_group_order values * APPEALS-45898. Updated order of the evidence submission priority and non-priority --------- Co-authored-by: SHarshain <[email protected]> * mbeard/APPEALS-40646 (#21645) * Init commit * adds methods and useffect first pass * fixes isIdle warning * removes important from scss * refined handleToggleChange method * updates font color for h4 * adds keys to the td and fixed proptype for loadAcdExcludeFromAffinity in casedistributionapp * Chrisbdetlef/appeals 43117.cleanup (#21671) * APPEALS-43421: Attorney Selection Sticking on Dropdown after Assignment (#21401) * redo init commit * updated imp. logic * attorney widget fix --------- Co-authored-by: Calvin <[email protected]> * Add ruby CE API Gem * remove correspondence changes from schema.rb (#21468) * Revert "Add ruby CE API Gem" (#21479) This reverts commit c78afe30620716d59d2ac31ad6eed71585d78a98. * Override SCT Bulk Assign Page task limit (#21465) * Override SCT Bulk Assign Queue 15 case limit & Adjust SCT attorney assign task action label * feature/APPEALS-35707-29633-29632 (prodtest) (#21485) * 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record` * 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances * 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash * feature/APPEALS-44871 Steps for installing node in the Caseflow demo environment (#21483) (#21484) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Revert "feature/APPEALS-44871 Steps for installing node in the Caseflow demo …" (#21489) This reverts commit a6262001f9bedabca60598c82bfe1b803f0f16c7. * Sbashamoni/appeals 44871 node14 demo fixes (#21490) (#21495) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Removed unused node env * add error rules to demo builds (#21496) (#21498) Co-authored-by: davis-dwayne <[email protected]> * APPEALS-43117 Add QA Users for testing * Fix rspecs * Fix issues with attorneys and judge teams * Fix org count --------- Co-authored-by: Isaiah Saucedo <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: youfoundmanesh <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Robert Travis Pierce <[email protected]> Co-authored-by: Jeremy Croteau <[email protected]> Co-authored-by: sbashamoni <[email protected]> Co-authored-by: davis-dwayne <[email protected]> Co-authored-by: Christopher Detlef <> * Minor fixes (#21694) * Minor fixes * Fix rspec tests and properly check for judge css id * Fix lint issue --------- Co-authored-by: Christopher Detlef <> * Fix Legacy Case issues (#21747) Co-authored-by: Christopher Detlef <> * APPEALS-46037. Fix padding in the lever history table (#21725) * APPEALS-46037. Fix padding in the lever history table * APPEALS-46037. Fix lint issues --------- Co-authored-by: SHarshain <[email protected]> * Fix Lauren Roth issue (#21813) * Users with a VACOLS::Staff entry no longer get created with the default name of Lauren Roth Co-authored-by: Christopher Detlef <> * ricky/APPEALS-44044 (#21814) * first pass at legacy_docket method and spec * second iteration of legacy_docket and spec * adds method to age_of_oldest methods and updates test scenarios * Updated testing and expanded method missing logic * Updated legacy_docket_spec file and tests * Updated boolean logic, updated rspecs and factories * Updated rspec tests to include factories * updates docket_spec line 317 and factory for disable_ama_non_priority_direct_review --------- Co-authored-by: Michael Beard <[email protected]> * updates ready_priority_nonpriority_appeals to public_send, updates test (#21844) * APPEALS-36333 first iteration of docket time goal and prior to goal (#21523) * APPEALS-36333 first iteration of docket time goal and prior to goal * APPEALS-36333 address pr comments and moved the logic to docket model * APPEALS-36333 Added specs for docket and hearing request docket models * refactored code and moved it to distribution scopes * APPEALS-36333 address pr comments and refactor code * APPEALS-43996 updated lever name in all the required files to fix spec failures * APPEALS-44000 revert hearing request docket model changes to keept it in sync with feature * APPEALS-44000 updated hearing request docket model specs * APPEALS-44000 fixed jest tests * APPEALS-44000 fixed broken rspecs * APPEALS-43996 fix rubocop warnings * APPEALS-43996 fix push priority job spec failures * APPEALS-43996 Updated case distribution lever and docker model and refactor specs * APPEALS-43996 added rake task to update case distribution lever item in db * APPEALS-43996 update docket model to handle the scenario when the lever being disabled by a user via the UI * APPEALS-43996 update section title * APPEALS-43996 revert rake task * APPEALS-43996 add new factories to case distribution lever and fix spec failures * APPEALS-45191. Added columns to the appeals ready to distribute query and made some tweaks (#21834) * APPEALS-45191. Added columns to the appeals ready to distribute query and made some tweaks * APPEALS-45191. Refactor and fix lint issues --------- Co-authored-by: SHarshain <[email protected]> * refactor the logic and fix docket spec failures * changed the call times to 3 times * APPEALS-36333 fixed the docket time goal to check the existence of the item before using the public send to get the value --------- Co-authored-by: SHarshain <[email protected]> Co-authored-by: SHarshain <[email protected]> Co-authored-by: 631966 <[email protected]> * updated the seeds to align with the work completed * Updated Toggle Switch behavior when clicked while idle (#21874) * Csv research (#21892) * APPEALS-44911. Change the pure react components to functional components * APPEALS-44911. Redux implementation * APPEALS-44911. CSS changes for custom seed preview * APPEALS-44911. tweak css * csv and etc * CSS for buttons * jest tests for the reducer and action types * Jest test --------- Co-authored-by: SHarshain <[email protected]> Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-46057. CleanUP (#21914) * more jest tests * Disable scenario seeds * Lint fixes * APPEALS-46057. disable all scenario seeds * APPEALS-46057. Refactor the TestSeed wrapper to be a functional component and fixed jest test * APPEALS-46057. Jest job in GHA complaining on test --------- Co-authored-by: SHarshain <[email protected]> * updates line of test to correctly build lever item (#21918) Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-45191. Updated the query to return the date based on the calculation (#21928) * APPEALS-45191. Updated the query to return the date based on the calculation * APPEALS-45191. Lint fix --------- Co-authored-by: SHarshain <[email protected]> * Chrisharsha/appeals 43962 (#21929) * Sharsha/appeals-44911_1 (#21784) * APPEALS-44911. Change the pure react components to functional components * APPEALS-44911. Redux implementation * APPEALS-44911. CSS changes for custom seed preview * APPEALS-44911. tweak css --------- Co-authored-by: SHarshain <[email protected]> * Chrisbdetlef/appeals 44910 (#21838) * Initial * Add JSON parsing and multiple calls to rake tasks * Pre-caby tets * Add capybara tests and add IDs to buttons --------- Co-authored-by: Christopher Detlef <> --------- Co-authored-by: SHarshain <[email protected]> Co-authored-by: cdetlefva <[email protected]> * APPEALS-43962. Lint fixes (#21932) Co-authored-by: SHarshain <[email protected]> * Ricky/APPEALS-47293 (#21925) * First pass implementation of fixing seeding rspecs * Second pass at fixing errors in rspecs * Revert updates to test if rspec passes * Fixed linting issues in test_docket_seeds_controller_spec --------- Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-48292 updated the column to be a string (#21954) * APPEALS-48292 updated the column to be a string * APPEALS-48292 added comment to the control_group field in the migration * APPEALS-48292 added column comment to the schema, changed migration so that it can be rolled back * APPEALS-48598 fix logic when Start Distribution Prior to Docket Time Goal toggle is false (#21948) * APPEALS-48598 fix logic when Start Distribution Prior to Docket Time Goal toggle is false * APPEALS-49004 added spec to check when Start Distribution Prior to Docket Time Goal toggle is on * APPEALS-49004 fixed lint issues in docket.rb * APPEALS-48898. Created Distributable AMA Non-priority Appeals Query (#21949) * APPEALS-48898. Created Distributable AMA Non-priority Appeals Query * APPEALS-48898. Renamed the column and update the method --------- Co-authored-by: SHarshain <[email protected]> * APPEALS-49100. getting value from the start_distribution_prior_to_goal (#21968) Co-authored-by: SHarshain <[email protected]> * mbeard/APPEALS-46257 (#21976) * updates routes and frontend urls to namespace * removes superfluous <a> tags * Ensure that legacy appeals are being created (#21981) * Ensure that legacy appeals are being created * Remove puts --------- Co-authored-by: Christopher Detlef <> * APPEALS-49403. Added buttons Docket Lever Seed (#21989) * APPEALS-49403. Added buttons Docket Lever Seed * sharsha/APPEALS-49403. Updated the endpoint URL path * APPEALS-49403. Lint fix --------- Co-authored-by: SHarshain <[email protected]> * APPEALS-44000 added check to skip priority appeals in docket model (#21992) * Feature/appeals 36234 masterupgrade (#22003) * sbashamoni/APPEALS-43724 Node 16 version upgrade changes (#21966) (#21975) * Update node verstion to 16 in git workflow * Update node verstion to 16 in nvm and dockerfile for demo * Update node version in yarn.lock and package.json and .nvmrc file * Update node's version path to node16 in docker-bin/env.sh * Update and upgrade to node16 in client * More updates to yarn.lock and package.json * Fix tests by Adam Shaw * Upadate snapshot for ScheduleVeteran.test.js.snap * Doing some code clean up * Doiing some more clean up * Add and remove spaces to match master * One more space to take care of * One more space to take care of again * One more space to take care of again --------- Co-authored-by: ramon-chavez <[email protected]> * init master merge branch --------- Co-authored-by: sbashamoni <[email protected]> Co-authored-by: ramon-chavez <[email protected]> * Remove AOD trait from non-priority legacy appeal creation (#22013) Co-authored-by: Christopher Detlef <> * Sharsha/appeals 49461 (#22018) * sharsha/APPEALS-49461. initial commit * sharsha/APPEALS-49461. fix --------- Co-authored-by: SHarshain <[email protected]> * mbeard/APPEALS-49421 (#22014) * init commit fixes ama_np_ capybara test to expect user as admin, and first attempt test_docket_seeds test * removes previous chane for TASKS_LOADED * fixes capybara for test seeds controller button ids --------- Co-authored-by: Amy Detwiler <[email protected]> * APPEALS-49403. Updated the buttons label (#22025) Co-authored-by: SHarshain <[email protected]> * mbeard/APPEALS-49585 (#22020) * init commit for non member view input * fixes css issue for docket-lever-right * Added a hyphen between value and unit for member only view * replaces hyphen with comma * Init commit replaces th with div for 508 compliance (#22036) * Chrisbdetlef/appeals 47008 1 (#22040) * Allow judges to see legacy cases and attorneys to be assigned cases * Remove testing function * Update spec to reflect new user count in seed file --------- Co-authored-by: Christopher Detlef <> * got rid of extraneous file * got rid of yarn lock orig * APPEALS-50734. Remove Legacy appeals from the query (#22071) Co-authored-by: SHarshain <[email protected]> * APPEALS-46087 fix css table width issues for case distribution lever history table (#22024) * Feature/appeals 36234.merge master.20240701 (#22075) * APPEALS-47277 remove Vegas office (#21876) * APPEALS-47277 remove Vagas office * Removed Texas ID from other files and updated tests * Snapshot update --------- Co-authored-by: Ron Wabukenda <[email protected]> Co-authored-by: Raymond Hughes <[email protected]> * hotfix/APPEALS-22403 (#21942) * add identifier for filenumber or ssn in filenumber search * linting * codeclimate linting * update match call to return boolean --------- Co-authored-by: Ron Wabukenda <[email protected]> Co-authored-by: Raymond Hughes <[email protected]> * APPEALS-46907: Update to Determination of Gen Pop Legacy Cases (#21986) * Isaiah/merge 46910 (#21983) * removed BFHINES checks and modified tests * removed lingering bfhines test * modified test * most recent updates on tests for passing status * removed refs to cavc updates * Skip flaky test ro_viewhearsched_spec --------- Co-authored-by: Isaiah Saucedo <[email protected]> * APPEALS-44916: Case Distribution Affinity Calculations (#21899) * APPEALS-44956: Add AppealAffinity model and database table (#21526) * add migration for appeal_affinities * add AppealAffinity model and associations, update migration for new column * update index to be unique * add factory, add tests * add factory traits to appeal and case for appeal affinities * add combination trait to appeal factory * add appeal_affinity to skipped associations in ETL reporting * add a validation, test * Craig/appeals 44958 (#21564) * add new job, update affinity model validation and after save hook * add update from push job * fix job extending distribution scopes * add with appeal affinities to distribution scopes * typo * add error handling, add test file * add distributed case factory, refactor naming in job * fix factories, added tests * fix migration for null affinity start date column * fixes, added tests * more test updates * add return in job if no query results, tests for no query results * add test for after_save hook adding dist task instructions * set start dist job to queue affinity job after running * fix update job and start dist job spec * queue affinity update job from push job * code clarity * fix judge in seed file * remove comment, fix hearing factory, disable some seeds for testing * add more tests * test refactor * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory * disable new seed on reset * update seed file with vet names, add another seed category * fix distirbuted case factory? * actually fix GHA runs * lint, test fixes * change constants in new job * APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611) * swap distribution queries from distribution_task to appeal_affinities * update seed files to use appeal affinities instead of distribution task * clean up seed file method names * add missing Timecop.return in ama affinity case seed * fix name of a method in a seed file * remove references to distribution task in distribution scopes * fix push priority job tests * fix naming of args in one of the seed files * fix user seed, fix date format in distribution task instructions * fix tests for date format update * Calvin/APPEALS-44957-rake-affinity (#21577) * grabbed receipt dates from distributed cases * refactored for functionality + added method to grab appeals that match * using receipt date, get all related appeals * added update/creation plus cleaned prior imple. * gets most recent distributed case receipt_date * skips if receipt_date is nil for performance * if appeal affinity is nil, it will now be updated * created spec file * fixed non ready appeals * updated query to match new AC * removing comment * testing for each docket * updated spec file * added new tests to rspec * updated start date to receipt date instead of Time.now * fixed date/time rspec errors * added rails logger to know when rake task has finished * added tag for rails log * removed nonpriority dockets for direct_review and evidence_submission * fixed lint issue * fixed flaky spec test * limits distributed cases query to within the last week * APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660) * add affinity start date to explain page * add feature test to verify dates display * update rake task and spec (#21731) * APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730) * add aod hearing cases to ama affinity cases seed * fix lever spec * APPEALS-45148: Hook to clear saved affinity date (#21623) * initial imp. idea * AC1: check for affinity_start_date on assignment * AC2/3: update affinity start date w/ instr. * updates to naming, instructions, and hook logic * updates after review * rspec coverage and addtional condition * removed unused identifier * removed reduntant 'self's * added update on actual AA record * updated to save aa record and addtional rspec * added change to assignment on no record test * check for assignment * addd update to 'on_hold' status * public method to handle legacy affinity appeals * added .reload to :with_affinity_appeal * added .reload to :ready_for_distribution * updates to pass explain_spec * switched boolean values * typo * readujsted order on :create for affinity appeal * removed after(:create) * testing rspec by readding after :create * reloading in assertation * addressing lint errors * fix seeds/users_spec * add case dist lever to new tests (#21776) * remove unnecessarily included module from job (#21827) * APPEALS-47211: Improve Performance of Distribution Queries (#21840) * rework ready_for_distribution scope * fix non-hearing docket distribution bug * restart tests * added null checks for appeal affinity in distribution queries, update tests (#21893) * add check for appeal being active to distribution and associated slack message (#21902) * Update users_spec.rb --------- Co-authored-by: calvincostaBAH <[email protected]> Co-authored-by: Isaiah Saucedo <[email protected]> * hotfix/APPEALS-45177: TaskTable Default Sorting Fix (#21772) * Updated the TaskTable component to use the defaultSort property instead of the defaultSortIdx property for queue table since that property is not used anywhere. Added a default sorting hash to the UnassignedCasesPage component and now pass that down to TaskTable. Removed references to defaultSortIdx. * Added the type column default sort to the AssignedCasesPage widget as well. * Added a parenthesis for clarity around a boolean. Moved the defaultSortingHash out into a constants file. --------- Co-authored-by: Robert Travis Pierce <[email protected]> * APPEALS-47106 Caseflow Swagger (#21993) * Add Rswag and convert existing API documentation (#21778) * add rswag * Update Gemfile.lock * Setup yaml UI * remove and reroute old swagger files * update format and servers values * Update route_docs_controller.rb * Update cmp_controller.rb * cmp endpoint yaml * cmp endpoint to return 501 * CMP endpoint swagger flies * update swagger files * adjust server order, add auth token * cmp parameter name change * add comments * Update users_controller.rb * unit tests and linting * lint fixes * Update swagger_helper.rb * APPEALS-48048 Swagger Updates (#21909) * update servers to not include a host * remove host for server * remove generated swaggers from definitions * remove internal API endpoints from having generated swagger * IDT servers fixes * disable CMP swagger in prod and prodtest * set authorization correctly * fix what is required for CMP upload * fix linting issues, update lint rake task to autocorrect for rubocop, add rubocop make command * Update decision_reviews.yaml * Update ama_issues.yaml * Update vacols_issues.yaml * Update swagger.yaml * fix check failures * Update docs_controller_spec.rb * fix unit tests * Update fetch_all_active_legacy_appeals_job_spec.rb * Update rswag_ui.rb * Update lint.rake * Update decision_reviews_spec.rb * Update fetch_all_active_legacy_a…

* WIP * cancel_corrresponence_task WIP * Modal Working * Modal WIP * modal WIP * WIP routing * WIP working routes can cancel function * WIP working banner * Redux fix WIP * WIP * Spec test created and passing * Passing jest test * created cancel action for details redux store * created action to remove task from redux store on cancel * Fixing rubocop tests * Fixed errors * Code Climate update * Adressing comments * Addressing Comments * Switch Record Status + Code Clean Up * Sucess & Error banner updated * Code climate WIP * Fixing failing tests * Resolving last code climate issue * Remove comma --------- Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

…2560) * WIP * cancel_corrresponence_task WIP * Modal Working * Modal WIP * modal WIP * WIP routing * WIP working routes can cancel function * WIP working banner * Redux fix WIP * WIP * Spec test created and passing * APPEALS-49727 - Complete Task Modal Work * APPEALS-49727 - Updates * APPEALS-49727 - Working Complete Action * APPEALS-49727 - Banner Updates * APPEALS-49727 - Update Completed Tasks * APPEALS -49727 - Functionality completed * APPEALS-49727 Testing updates, Linting Cleanup, Test Data * APPEALS - 49727 -Testing updates, Linting Cleanup, Test Data * Linting * APPEALS-49727 - Lint updates * Updated Optionality for modal - Submit on empty text * Removed unused import * APPEALS-49727 - Removed unneeded task filters --------- Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: Christopher Aceves <[email protected]>

* WIP * cancel_corrresponence_task WIP * Modal Working * Modal WIP * modal WIP * WIP routing * WIP working routes can cancel function * WIP working banner * Redux fix WIP * #49703 - initial commit * #49703 - added CorrespondenceChangeTaskTypeModal * WIP * #49703#49828 - Task type dropdown options * #49703 #49816 - submit button behaviour * Spec test created and passing * test * Passing jest test * created cancel action for details redux store * created action to remove task from redux store on cancel * Fixing rubocop tests * Fixed errors * #49703 #54132 - success banner action * #49703 - lint * #49703, #55639 - update redux store with type and instructions * #49703, #55639 - update redux store with type and instructions * #49703, #49705 - Update backend tests * #49703, #49705 - Update backend tests * #49703, #54132 - Update error warning banner * revert changes * #49703, #49704 - Update frontend tests * #49703 - lint * #49703 - lint * #49703 - addressing a lint issue --------- Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: cacevesva <[email protected]>

* Cancel task text * Kicking off tests * Changing this back

* Created a popup Modal * Provide the organizations into the dropdown * Redux store action update * Updated the redux store with name(label) * Modified the action method * Updated the select dropdowm with previous org * Fix for view task instructions * Resolve conflicts * Fix for view task instructions and sending them as array * Removed unnessary things from task_action_repo * Lint fixes * Spec fix for correspondence_tasks_controller_spec file * Removing the array for instructions in the spec * Updated the banner alert for error banner * fix for that text change and code climate fix * Codeclimate fix for available_actions is controlled by argument 'user' --------- Co-authored-by: cacevesva <[email protected]>

* #49703 - Updated task type options * #49703 - lint --------- Co-authored-by: cacevesva <[email protected]>

* Modified the status banner wording to Other motion task fix * Removed the console log

* fix code climate * fix lint issuues * fix lint error --------- Co-authored-by: cacevesva <[email protected]>

* Adding a route for the other motion assign modal * working on creating a modal * editing task action repo * committing prior changes from trying to get routing to work * updating with some of Khalin's changes to hopefully avoid merge conflicts * working on redux for user dropdown list * adding in code for reassigning * adding validation for the dropdown to enable submit * moving data to new "reassign users" which is dynamically built * fixing the submit button clickablility * removing some testing data and adding in some missing semicolons * removing unneccesary code * editing user iteration to choose the right task if there are multiple tasks related to an appeal * Continue setting up the payload for the submit button * working on the submit button * updating the user dropdown * editing the task actions for "reassigning" tasks when currently assigned to a user * finxing linting errors, codeclimate, and removing extraneous code * Adding rspec test case * saving the task after editing instructions * working on fixing task instructions * Working on banner actions * Adding in banner alerts * finishing up the banner actions * adding back files from the feature with minor adjustments to fix errors * adding back a change from feature that I thought may have been problematic but was ultimately okay * adding back available options to other_motion_correspondence_task, as bug ticket to fix the root cause has been noted https://jira.devops.va.gov/browse/APPEALS-56844 * removing showActionsDropdown traces from other files * removing old commented code * oushing up latest banner attempts * Fixing assign/reassign modal logic, and general code cleanup * Fixing the tab page title * making sure options are correctly returned * editing old code references * editing banners and fixing cancel correspondence mistype * cleaning up the banner json file * editing the capitalization from the modal * fixing the cancel banner * fixing linting errors * CC Fix * linting errors * renaming method for better context * Rspec fix - duplicate variable * code fixing * fixing the available actions list --------- Co-authored-by: vinner57 <[email protected]> Co-authored-by: Kevin Ma <[email protected]>

…eritance (#22663) * adjusted action scope and restricted actions to users within assigned org * removed unused methods * removed unused task type * removed unused stubbed actions * resolved change to acd work

* code climate fix * fix OtherMotionCorrespondenceTask spec * working on linting errors * Making uglier code to appease the linter...? Yeah, I'm confused too * fixing rspec test from button name change * another rspec and linting fix --------- Co-authored-by: Deepak <[email protected]>

* added props for modals needed to match reassignment * added logic to change user actions when reassignment happens * fixed bug where task actions were showing after reassign org. * fixed linting issues * removed duplicate prop validations

… Completed status (#22726) * APPEALS-51359 - Details Access and Rerouting * APPEALS-51359 - Testing Updates * Updated Spec --------- Co-authored-by: cacevesva <[email protected]>

* Updated FetchDocumentsForReaderJob with guard clause * Added guard clause for AppealsForReaderJob --------- Co-authored-by: cacevesva <[email protected]>

* adjusted action scope and restricted actions to users within assigned org * removed unused methods * Added specs for Assign to team and Change task type actions * removed unused task type * removed unused stubbed actions * Added FOIA request task feature test * Updating the specs with DIY concept * Fixing code climate issues * Added few more specs * Code climate fixes * Codeclimate fix * Codeclimate fix * Removing orgs from helper and moving them to constants * Added status to the correspondece creation in the spec * Fix for failing spec --------- Co-authored-by: HunJerBAH <[email protected]>

* #49886 - added actions jest test * added All correspondence mail tasks test data * code climate issue fix * lint --------- Co-authored-by: HunJerBAH <[email protected]>

* Typo fix * Added safe navigation operator * Remove permissions from ruby view props * Update component to save value to state instead of from props * rename hash key * updated var ref to state * Update for code spacing * Bugfix for sticky checkbox logic

* Added missing columns in the serializer prepareAppealForSearchStore function * Removed console log * Removed unused imports --------- Co-authored-by: cacevesva <[email protected]>

…elation

…m Task action (#22819) * updated can_receive_task? logic for inbound ops team * updated comment

* Unit draft test for Other Motion task drop down * Updates to test in new file * Small fix for context relevance * Adding more to the accessing the task portion of the test. * Context changes * user_array is at the top of the file now * Working test but currently failing * Root task changed * Fixed user initializers * New test approach * refactored mail task available actions * verified user can create mail task test * cleaned up test variable definitions * reworked test context to iterate through mail tasks * created test for correspondence mail_task reassign_user test * created test for reassign_users for correspondence mail task * created tests for assignable organizations * fixed codeclimate issues * fixed bug where only org users from first organization were showing in the list * updated test and created new test condition * override feature envy in Reek --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* #APPEALS-54789 - added Save changes button * #APPEALS-57731 - Created Save changes success banner * #APPEALS-54791 - Save changes button is enabled * #APPEALS-54791 - Save changes button behavior on tab change * #APPEALS-54791 - Save changes button behavior on tab change * #APPEALS-42568 - Saving Related correspondences to database * #APPEALS-42568 - controller action * #APPEALS-42568 - route update * #APPEALS-42568 - updated route to post * #APPEALS-42568 - updated route to post

* Initial commit- Added the Add letter button and reusing the newletter componet * Added submit logic * Able to add response letter * Modified the updated function * Modified the updated redux function * Updated the redux store with values * Modified the code according to DRY * Lint fixes * Added feature test specs * Updating the feature tests for this feature * Lint fixes * Removed the line that is twice added * Modified the routes file

* #APPEALS-42568 - Saving Related correspondences to database * #APPEALS-42568 - added inbound ops check * #APPEALS-42568 - fixed sorting issue * #APPEALS-42568 - removed tab change functionality * #APPEALS-42568 - removed tab change functionality * #APPEALS-42568 - removed redundant action * #APPEALS-42568 - Jest Tests * #APPEALS-42568 - rspecs * #APPEALS-42568 - lint * #APPEALS-42568 - fixed failing rspecs

* creating correspondences and the tasks for the spec tests * adding in other task data for Ryan's work * changing to 3 correspondence with each task type * working on writing tests, and still working on the test data * adding in changes for verifying the routes for the other four tests * attempting to fix the data creation duplication issue * Update data setup and added remaining test cases * Use regex for label text matching * changing the expect to make sure every page shows up regardless of what other tasks are present * editing the expect to hopefully fix if there is a finnicky test * adding regex in case of weird newline edge cases for more accurate matching, and separated test cases * removing extraneous code and comments * fixing jest and lint errors unrelated to my work * missed a semicolon --------- Co-authored-by: Kevin Ma <[email protected]> Co-authored-by: cacevesva <[email protected]>

…als: Can link additional appeals (#22872) * conflicts resolved * Adding the spec for save correspondence appeals * conflicts resolved * conflicts resolved * #APPEALS-42568 - Saving Related correspondences to database * conflicts resolved * #APPEALS-42568 - removed redundant action * conflicts resolved * #APPEALS-42568 - rspecs * #APPEALS-42568 - lint * #APPEALS-42568 - fixed failing rspecs * conflicts resolved * fix failing specs * lint fix * fixing the select order of checkboxes * fix lint errors * fix lint and rubocop --------- Co-authored-by: Razor Talent <[email protected]> Co-authored-by: psivakeshva <[email protected]>

* Working but the checkboxes ceep shifting around * Front-end changes working as intended & started backend functionality * Handle save button WIP * route info update * Functionality working as intended * Removing flash banner on update * small fixes * Tests WIP * Working test and code clean up * More complete test * Working with latest changes in feature. * code climate fixes * current_user is needed sor the update to save * Fixing linting errors

* Added datepicker feature date restriction * trying to fix the flakey test * trying to fix the flakey test by adding wait time for the button * Modified spec changes to resolve the flakey test fix * Modified spec changes to resolve the flakey test fix --------- Co-authored-by: cacevesva <[email protected]>

#22938) * fixing the checkbox sorting issue * remove duplicate spec * fixing the jest cases * fixing the unchecked issue * show success banner

* Initial commit for Navigation Updates for Existing Appeals * Lint fixes * Lint fixes for styles * Trying to fix the flakey test spec * Trying to fix the flakey test spec * Trying to fix the flakey test spec for response letter * Trying to fix the flakey test spec for response letter * Trying to fix the flakey test spec for response letter * Trying to fix the flakey test spec for response letter * Fixing the flakey test spec that is failing * lint fixes * Trying to fix the flakey test for response letters spec * Added skip to one of the test spec * Lint fixes

* Added a quick for expanded and collapsed section * Added jest file modification

* Checkbox sorting is fixed * Save button fix --------- Co-authored-by: cacevesva <[email protected]>

… Information (#22937) * filtered related correspondece values * added new correspondence_details serializer * created new appeal serializer and updated frontend to handle new values * added correspondence type to serializer * fixed bug where appeal id was not matching with previously linked appeals * fixed failing test * fixed failing tests

* #APPEALS-58115 - added collapsible header * #APPEALS-58115 - updated box border color * #APPEALS-58115 - added a jest test to verify there is plus button * #APPEALS-58115 - added a jest test to verify there is plus button * #APPEALS-58115 - fixed a failing a jest test * #APPEALS-58115 - fixed a failing a spec

* WIP all styles have been moved * Fixing linting warnings * Aria-label added * Kicking off tests --------- Co-authored-by: cacevesva <[email protected]>

* mostly fixed * fixed css issues on grey timeline. * fixed missing key issue * fixed labels and data shape. * Fixed staged data to use real data. * removed redundant prop * Fixed task action dropdown * fixed linting issue * Kev ma/appeals 55015 (#22764) * Typo fix * Added safe navigation operator * Remove permissions from ruby view props * Update component to save value to state instead of from props * rename hash key * updated var ref to state * Update for code spacing * Bugfix for sticky checkbox logic * Div/appeals 57463 (#22779) * Added missing columns in the serializer prepareAppealForSearchStore function * Removed console log * Removed unused imports --------- Co-authored-by: cacevesva <[email protected]> * added polymorphic association to correspondence task Correspondence relation * fixed null task issue * updated serialized info and passed appeal into CorrespondenceTasksAdded instead of correspondence. * setup way to load appeals into the Queue redux store to display task actions * created logic to load serialized tasks into store (but they overwrite each other) * created logic to add appeal tasks to the redux store. * added TaskSnapshot to display appeal task actions * pushed up fix that resolved routing crashes from correspondence * removed wrapping class for task rows to meet UI/UX requirements. Also disabled the task action dropdown per requirements. * Refactored component to use different name. * fixed 6 failing tests * fixed several failing tests. * changed shape of mocked data in details test * adding more data to staged props in test * fixed task display for tasks added when empty * reverted jest test files from their extreme size. * added back in correspondenceAppeal map * removed console log * fixed dead import. * fixed failing tests from div wrappers hiding task actions * updated tests to be less flaky --------- Co-authored-by: Kevma50287 <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

… Edit Information (#22944) * APPEALS-42563 - Working Modal, minus Save patch request * APPEALS-42563 - Fixed Modal, missing ApiSave * APPEALS-42563 - ApiUtil fix * APPEALS-42563 * Test Updates * Remove loadCorrespondence * Removed unused correspondenceInfo action; linting --------- Co-authored-by: cacevesva <[email protected]> Co-authored-by: HunJerBAH <[email protected]>

* unlinked checkboxes now sort by vaDateOfReceipt * Post method added --------- Co-authored-by: cacevesva <[email protected]>

* Fixed the duplication of correspondence appeals adding to the database * Removed puts * fixing the jest fails * fixing the jest fails * Trying to fix the lint issues --------- Co-authored-by: cacevesva <[email protected]>

Co-authored-by: cacevesva <[email protected]>

* Provided the instructional text * Jest fixes * Adjusted the paragraph text --------- Co-authored-by: cacevesva <[email protected]>

* bug fixes * fix rspec * fix rspec --------- Co-authored-by: cacevesva <[email protected]>

…ng an appeal (#23045) * fix to the sorting issue * resolving bugs * resolved conflicts with branch changes and feature changes * added state refresh logic to CaseListTable --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: cacevesva <[email protected]>

* update search count * remove nested ternary operator --------- Co-authored-by: cacevesva <[email protected]>

* APPEALS-42563 - User Access Fix * Spec test user access update --------- Co-authored-by: cacevesva <[email protected]>

Feature/appeals 34965 #22154

Are you sure you want to change the base?

Feature/appeals 34965 #22154

Commits on May 2, 2024

Commits on May 3, 2024

Commits on May 6, 2024

Commits on May 14, 2024

Commits on May 17, 2024

Commits on May 21, 2024

Commits on May 22, 2024

Commits on May 23, 2024

Commits on May 24, 2024

Commits on May 29, 2024

Commits on May 30, 2024

Commits on May 31, 2024

Commits on Jun 3, 2024

Commits on Jun 4, 2024

Commits on Jun 5, 2024

Commits on Jun 6, 2024

Commits on Jun 12, 2024

Commits on Jun 13, 2024

Commits on Jun 14, 2024

Commits on Jun 17, 2024

Commits on Jun 18, 2024

Commits on Jun 20, 2024

Commits on Jun 21, 2024

Commits on Jun 24, 2024

Commits on Jun 25, 2024

Commits on Jun 26, 2024

Commits on Jun 27, 2024

Commits on Jun 28, 2024

Commits on Jul 2, 2024

Commits on Jul 3, 2024

Commits on Jul 5, 2024

Commits on Jul 9, 2024

Commits on Jul 10, 2024

Commits on Jul 11, 2024

Commits on Jul 12, 2024

Commits on Jul 15, 2024

Commits on Jul 16, 2024

Commits on Jul 17, 2024

Commits on Jul 18, 2024

Commits on Jul 19, 2024

Commits on Jul 22, 2024

Commits on Jul 23, 2024

Commits on Jul 24, 2024

Commits on Jul 25, 2024

Commits on Jul 26, 2024

Commits on Jul 29, 2024

Commits on Jul 30, 2024

Commits on Jul 31, 2024

Commits on Aug 1, 2024

Commits on Aug 2, 2024

Commits on Aug 5, 2024

Commits on Aug 7, 2024

Commits on Aug 8, 2024

Commits on Aug 9, 2024

Commits on Aug 12, 2024

Commits on Aug 13, 2024

Commits on Aug 14, 2024

Commits on Aug 15, 2024

Commits on Aug 16, 2024

Commits on Aug 20, 2024

Commits on Aug 22, 2024

Commits on Aug 23, 2024

Commits on Aug 26, 2024

Commits on Aug 28, 2024

Commits on Aug 29, 2024

Commits on Aug 30, 2024

Commits on Sep 3, 2024

Commits on Sep 4, 2024

Commits on Sep 5, 2024

Commits on Sep 6, 2024

Commits on Sep 9, 2024

Commits on Sep 10, 2024

Commits on Sep 11, 2024

Commits on Sep 13, 2024

Commits on Sep 17, 2024

Commits on Sep 19, 2024

Commits on Sep 20, 2024