Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker-in-docker: Add retries to the docker-init script until docker daemon starts #637

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Docker-in-docker: Add retries to the docker-init script until docker daemon starts #637

merged 2 commits into from
Aug 7, 2023

Conversation

samruddhikhandale
Copy link
Member

Closes: #634

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner August 4, 2023 16:49
@samruddhikhandale samruddhikhandale mentioned this pull request Aug 4, 2023
Closed
@AndriiTsok
Copy link

@samruddhikhandale Thank you!

I hope this one will be prioritized. We experiencing a big dev experience issue working with inner loop env with a k8s cluster within the Codespaces. Every 3rd run fails, and we required to do full container rebuild.. sometimes multiple.

jkeech
jkeech reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that verifies that the retries are working as expected? Left one comment about a breaking change. At minimum, this feels like a minor version bump to me since adding retries on the docker start is a new feature.

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
@samruddhikhandale
Copy link
Member Author

Can you add a test that verifies that the retries are working as expected? Left one comment about a breaking change. At minimum, this feels like a minor version bump to me since adding retries on the docker start is a new feature.

@jkeech Thanks for the review! Added a test which tests the retry logic and bumped the minor version. Also, see #637 (comment)

jkeech
jkeech approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion

test/docker-in-docker/test-scripts/docker-test-init.sh Show resolved Hide resolved
@samruddhikhandale samruddhikhandale merged commit bbb24d1 into main Aug 7, 2023
11 of 12 checks passed
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/dnd-retry-docker-init branch August 7, 2023 23:00
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeech jkeech jkeech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker-in-docker: Add retry mechanism into the docker init script (Failed to connect to Docker)
3 participants
@samruddhikhandale @AndriiTsok @jkeech