-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support multi-arch builds for releases #1218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
+ Coverage 52.74% 52.75% +0.01%
==========================================
Files 84 84
Lines 7616 7616
==========================================
+ Hits 4017 4018 +1
+ Misses 3310 3309 -1
Partials 289 289 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
9d84f78
to
b270e62
Compare
Signed-off-by: Andrew Obuchowicz <[email protected]>
b270e62
to
61f0522
Compare
/retest |
2 similar comments
/retest |
/retest |
@AObuchow: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
FWIW: I tested the release script with the buildx changes (and QEMU + buildx GH action setup) on my fork here and ensured that calling the release script without the dry-run parameter would build for all platforms. |
The e2e test seems to have broken:
Merging anyway as this PR only modifies the release script + GH release action which are not tested in e2e test. |
What does this PR do?
Uses docker buildx for building the devworkspace-controller image and project clone image in the release script.
Also sets up QEMU and a docker buildx builder in the
release.yml
workflow so that buildx will have a multi-arch builder setup prior to runningmake-release.sh
Note: excuse the merge commit, I'll remove it and rebase this PR before merging.
What issues does this PR fix or reference?
Part of #559
Is it tested? How?
Not tested as it requires running the release github action. Though I will try and simulate this on my fork and report back before having this merged, just wanted to get @amisevsk's eyes on it incase there's something that I'm missing in this fix.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che