Log more config errors #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatcherK
force-pushed
the
feature/handle-missing-configs
branch
from
439ec01 to
d78b1f8
Compare
|
wakibi
requested changes
Apr 2, 2024
Comment on lines
+47
to
61
| if (config.dataID && !config.baseAPIUrl) { | ||
| window.console.error('Invalid chart config: baseAPIUrl is required!'); | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| if (!(config.data || config.url || config.dataID)) { | ||
| window.console.error('Invalid chart config: one of data/url/dataID is required!'); | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| if (!config.mapping.subCounty) { | ||
| window.console.warn('Potentially invalid chart config: mapping.subCounty may be required!'); | ||
|
|
There was a problem hiding this comment.
Maybe add these in a validation function? I see it repeated and it's rather long lines of code
There was a problem hiding this comment.
They are already in a function
wakibi
reviewed
Apr 2, 2024
Comment on lines
89
to
+102
| if (!config.mapping.subCounty) { | ||
| window.console.error('Invalid table config: mapping.subCounty is required!'); | ||
| window.console.warn('Potentially invalid table config: mapping.subCounty may be required!'); | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| if (config.dataID && !config.baseAPIUrl) { | ||
| window.console.error('Invalid table config: baseAPIUrl is required!'); | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| if (!(config.data || config.url || config.dataID)) { | ||
| window.console.error('Invalid table config: one of data/url/dataID is required!'); |
There was a problem hiding this comment.
Hmm I don't see the repeatition, the error messages are different, and the config variables checked for are also different
There was a problem hiding this comment.
There are two validation functions, one for tables and another for charts
wakibi
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.