Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): setupos unit tests #3661

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

andrewbattat
Copy link
Member

@andrewbattat andrewbattat self-assigned this Jan 28, 2025
@github-actions github-actions bot added the feat label Jan 28, 2025
@@ -132,20 +132,20 @@ function validate_domain_name() {
IFS='.' read -ra domain_parts <<<"${domain_name}"

if [ ${#domain_parts[@]} -lt 2 ]; then
log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}"
log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}" || return $?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The || return $? is necessary for the exit code to propagate up to the test_validate_domain_name unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant