feat(node): setupos unit tests

ic-os/components/setupos-scripts/BUILD.bazel

@@ -73,3 +73,15 @@ sh_test(
     srcs = ["test-kernel-cmdline-function-runner"],
     data = [":functions.sh"],
 )
+
+sh_test(
+    name = "test_setupos",
+    srcs = ["test-setupos.sh"],
+    args = [
+        "$(execpath check-network.sh)",
+    ],
+    data = [
+        "check-network.sh",
+    ],
+    tags = ["manual"],
+)

ic-os/components/setupos-scripts/check-network.sh

@@ -132,20 +132,20 @@ function validate_domain_name() {
     IFS='.' read -ra domain_parts <<<"${domain_name}"
 
     if [ ${#domain_parts[@]} -lt 2 ]; then
-        log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}"
+        log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}" || return $?
     fi
 
     for domain_part in "${domain_parts[@]}"; do
         if [ -z "$domain_part" ] || [ ${#domain_part} -gt 63 ]; then
-            log_and_halt_installation_on_error 1 "Domain validation error: domain part length violation: ${domain_part}"
+            log_and_halt_installation_on_error 1 "Domain validation error: domain part length violation: ${domain_part}" || return $?
         fi
 
         if [[ $domain_part == -* ]] || [[ $domain_part == *- ]]; then
-            log_and_halt_installation_on_error 1 "Domain validation error: domain part starts or ends with a hyphen: ${domain_part}"
+            log_and_halt_installation_on_error 1 "Domain validation error: domain part starts or ends with a hyphen: ${domain_part}" || return $?
         fi
 
         if ! [[ $domain_part =~ ^[a-zA-Z0-9-]+$ ]]; then
-            log_and_halt_installation_on_error 1 "Domain validation error: invalid characters in domain part: ${domain_part}"
+            log_and_halt_installation_on_error 1 "Domain validation error: invalid characters in domain part: ${domain_part}" || return $?
         fi
     done
 }

ic-os/components/setupos-scripts/test-setupos.sh

@@ -0,0 +1,81 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+# ------------------------------------------------------------------------------
+# Test harness for check-network.sh
+# ------------------------------------------------------------------------------
+
+CHECK_NETWORK_SCRIPT="${1:-./check-network.sh}"
+
+# ------------------------------------------------------------------------------
+# Override "source" so that sourcing /opt/ic/bin/config.sh and /opt/ic/bin/functions.sh
+# does not fail in our test environment.
+# ------------------------------------------------------------------------------
+function source() {
+    if [[ "$1" == "/opt/ic/bin/config.sh" || "$1" == "/opt/ic/bin/functions.sh" ]]; then
+        echo "MOCKED: ignoring source of '$1' (file not present in test environment)"
+        return
+    fi
+    builtin source "$1"
+}
+
+# ------------------------------------------------------------------------------
+# Mocked out functions
+# ------------------------------------------------------------------------------
+
+function log_and_halt_installation_on_error() {
+    local exit_code="$1"
+    return "${exit_code}"
+}
+
+function log_start() {
+    local script="${1}"
+}
+
+function log_end() {
+    local script="${1}"
+}
+
+# ------------------------------------------------------------------------------
+# Unit tests
+# ------------------------------------------------------------------------------
+
+function test_validate_domain_name() {
+    echo "Running test: test_validate_domain_name_valid"
+    domain_name="example.com"
+    # If domain_name is valid, validate_domain_name should never call
+    # log_and_halt_installation_on_error, so it should exit 0.
+    if validate_domain_name; then
+        echo "  PASS: valid domain: $domain_name"
+    else
+        echo "  FAIL: valid domain: domain_name"
+        exit 1
+    fi
+
+    echo "Running test: test_validate_domain_name_invalid"
+    domain_name="example."
+    if ! validate_domain_name; then
+        echo "  PASS: domain $domain_name validation failed as expected"
+    else
+        echo "  FAIL: domain $domain_name validation was expected to fail but didn't"
+        exit 1
+    fi
+    domain_name="&BadDOMAIN.com"
+    if ! validate_domain_name; then
+        echo "  PASS: domain $domain_name validation failed as expected"
+    else
+        echo "  FAIL: domain $domain_name validation was expected to fail but didn't"
+        exit 1
+    fi
+}
+
+# ------------------------------------------------------------------------------
+# Run tests
+# ------------------------------------------------------------------------------
+source "${CHECK_NETWORK_SCRIPT}"
+
+test_validate_domain_name
+
+echo
+echo "All tests passed."